From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1850D21155D4D for ; Tue, 25 Sep 2018 03:26:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A110300206A; Tue, 25 Sep 2018 10:26:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-71.rdu2.redhat.com [10.10.120.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75D1D608E0; Tue, 25 Sep 2018 10:26:10 +0000 (UTC) To: Jiaxin Wu , edk2-devel@lists.01.org Cc: Ye Ting , Fu Siyuan References: <20180925034445.14896-1-Jiaxin.wu@intel.com> <20180925034445.14896-5-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: Date: Tue, 25 Sep 2018 12:26:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180925034445.14896-5-Jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 25 Sep 2018 10:26:11 +0000 (UTC) Subject: Re: [Patch 4/6] NetworkPkg/TcpDxe: Add the clarification compared to Tcp4Dxe in MdeModulePkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 10:26:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to Tcp4Dxe in MdeModulePkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/TcpDxe/TcpDxe.inf | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/TcpDxe/TcpDxe.inf b/NetworkPkg/TcpDxe/TcpDxe.inf > index eb693a147f..56cfd16b98 100644 > --- a/NetworkPkg/TcpDxe/TcpDxe.inf > +++ b/NetworkPkg/TcpDxe/TcpDxe.inf > @@ -1,12 +1,17 @@ > ## @file > # TCPv4 I/O and TCPv6 I/O services. > # > # This module provides EFI TCPv4 Protocol and EFI TCPv6 Protocol to send and receive data stream. > -# It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on > -# which network stack has been loaded in system. > +# It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on which network > +# stack has been loaded in system. This driver supports both IPv4 and IPv6 network stack. > # > +# Notes: > +# 1) This driver can't co-work with the Tcp4Dxe driver in MdeModulePkg. > +# 2) This driver includes more bugs fix and supports more features (e.g. IPv6, TCP Cancel suggestion: "bugs fix" --> "bug fixes" > +# function) than the Tcp4Dxe driver in MdeModulePkg. So, we recommand to use this driver suggestion: "recommand to use" --> "recommend using" > +# even both of them can be used. "even" --> "even though" With those: Reviewed-by: Laszlo Ersek Thanks! Laszlo > # > # Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License >