Re: [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Hi,

On 2/21/19 10:13 PM, Philippe Mathieu-Daude wrote:
> Part of my assignment is to review OVMF and ArmVirt patches,
> having my address listed will help me to catch the related
> patches.

I had a misunderstanding regarding how EDK2 treats a 'R:' tag, as I
understood it as similar to Linux/QEMU, which is simply "reviewers
should be CCed on patches".
Since EDK2 R: tag seems somehow different, but the description is not
explicit:

  R: Package Reviewer: Cc address for patches and questions. Reviewers
     help maintainers review code, but don't have push access.

Can someone improve the documentation?

Meanwhile please disregard this inappropriate patch.

Thanks,

Phil.

> 
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
>  Maintainers.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2f..3c17038fab 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -82,6 +82,7 @@ M: Laszlo Ersek <lersek@redhat.com>
>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>  R: Julien Grall <julien.grall@arm.com>
>     (Xen modules)
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
>  
>  BaseTools
>  W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> @@ -225,6 +226,7 @@ R: Marc-André Lureau <marcandre.lureau@redhat.com>
>     (TPM2 modules)
>  R: Stefan Berger <stefanb@linux.ibm.com>
>     (TPM2 modules)
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
>  S: Maintained
>  
>  PcAtChipsetPkg
>