* [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer
@ 2019-02-21 21:13 Philippe Mathieu-Daude
2019-02-27 11:44 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daude @ 2019-02-21 21:13 UTC (permalink / raw)
To: edk2-devel; +Cc: Ard Biesheuvel, Laszlo Ersek, Philippe Mathieu-Daude
Part of my assignment is to review OVMF and ArmVirt patches,
having my address listed will help me to catch the related
patches.
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
Maintainers.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7772926b2f..3c17038fab 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -82,6 +82,7 @@ M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
R: Julien Grall <julien.grall@arm.com>
(Xen modules)
+R: Philippe Mathieu-Daudé <philmd@redhat.com>
BaseTools
W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
@@ -225,6 +226,7 @@ R: Marc-André Lureau <marcandre.lureau@redhat.com>
(TPM2 modules)
R: Stefan Berger <stefanb@linux.ibm.com>
(TPM2 modules)
+R: Philippe Mathieu-Daudé <philmd@redhat.com>
S: Maintained
PcAtChipsetPkg
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer
2019-02-21 21:13 [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer Philippe Mathieu-Daude
@ 2019-02-27 11:44 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-27 11:44 UTC (permalink / raw)
To: edk2-devel, Laszlo Ersek
Hi,
On 2/21/19 10:13 PM, Philippe Mathieu-Daude wrote:
> Part of my assignment is to review OVMF and ArmVirt patches,
> having my address listed will help me to catch the related
> patches.
I had a misunderstanding regarding how EDK2 treats a 'R:' tag, as I
understood it as similar to Linux/QEMU, which is simply "reviewers
should be CCed on patches".
Since EDK2 R: tag seems somehow different, but the description is not
explicit:
R: Package Reviewer: Cc address for patches and questions. Reviewers
help maintainers review code, but don't have push access.
Can someone improve the documentation?
Meanwhile please disregard this inappropriate patch.
Thanks,
Phil.
>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> Maintainers.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2f..3c17038fab 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -82,6 +82,7 @@ M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> R: Julien Grall <julien.grall@arm.com>
> (Xen modules)
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> BaseTools
> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> @@ -225,6 +226,7 @@ R: Marc-André Lureau <marcandre.lureau@redhat.com>
> (TPM2 modules)
> R: Stefan Berger <stefanb@linux.ibm.com>
> (TPM2 modules)
> +R: Philippe Mathieu-Daudé <philmd@redhat.com>
> S: Maintained
>
> PcAtChipsetPkg
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-27 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-21 21:13 [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer Philippe Mathieu-Daude
2019-02-27 11:44 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox