From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.66; helo=mail-wm1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5064D20886F3C for ; Wed, 27 Feb 2019 03:44:25 -0800 (PST) Received: by mail-wm1-f66.google.com with SMTP id o10so4234409wmc.1 for ; Wed, 27 Feb 2019 03:44:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=617EseJxMd5IPzhIJ8UFFkkaiLiSKG65Zn/8aAPr9aE=; b=W95tL9VlszmCtKw59tbHnxC1DAvyPQUJkgZb0SU1+OegLkumPXfA0TrPL6l1Maq1jX LVWqTNbOqyf9k2BzUNJ0NzEILDI1YhnrTWwgq+pAK/jwYmYai1cS7gIgq7wpqSHgFIn5 7Uu63QIPoMV03+VyK7YZIgXu6Oh4HOQwEwfcc/a4MA5cfuaLOXAZEMssODYgnuzEwr8R tRPwTnGabM6+3p3yxh8/b5M2aDVV9kBFJCKnSo3o5ZofswplQxuLP0BVtr1Bsl4aComW 7TLH3XwEhj80hvsawRtszAYWlumNrhxubS6dk8mo3ZiYZ85auW5FA+3b71pnY4ZkqnQF vITg== X-Gm-Message-State: AHQUAubO1F4VBr6OF3OJv6yJ+R+e9A3GqYCH5P5QXb1uQ3Y+9MLk3+7R CDN9qmHSuMXeFzbDYUwld6Y0RVdTAhk= X-Google-Smtp-Source: APXvYqxol1h3J3moEzy8cNBTaFvquo2ddHQ69WDeQ2fGvuBHntshCTJMoyCvytmFi24J/i+R9tW6gw== X-Received: by 2002:a1c:4009:: with SMTP id n9mr1952166wma.132.1551267863381; Wed, 27 Feb 2019 03:44:23 -0800 (PST) Received: from [10.32.224.213] (red-hat-inc.vlan560.asr1.mad1.gblx.net. [159.63.51.90]) by smtp.gmail.com with ESMTPSA id w10sm9740465wrn.32.2019.02.27.03.44.22 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 03:44:22 -0800 (PST) To: edk2-devel@lists.01.org, Laszlo Ersek References: <20190221211348.22132-1-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Wed, 27 Feb 2019 12:44:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190221211348.22132-1-philmd@redhat.com> Subject: Re: [PATCH] Maintainers.txt: Register myself as OvmfPkg/ArmVirtPkg reviewer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 11:44:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi, On 2/21/19 10:13 PM, Philippe Mathieu-Daude wrote: > Part of my assignment is to review OVMF and ArmVirt patches, > having my address listed will help me to catch the related > patches. I had a misunderstanding regarding how EDK2 treats a 'R:' tag, as I understood it as similar to Linux/QEMU, which is simply "reviewers should be CCed on patches". Since EDK2 R: tag seems somehow different, but the description is not explicit: R: Package Reviewer: Cc address for patches and questions. Reviewers help maintainers review code, but don't have push access. Can someone improve the documentation? Meanwhile please disregard this inappropriate patch. Thanks, Phil. > > Signed-off-by: Philippe Mathieu-Daude > --- > Maintainers.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 7772926b2f..3c17038fab 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -82,6 +82,7 @@ M: Laszlo Ersek > M: Ard Biesheuvel > R: Julien Grall > (Xen modules) > +R: Philippe Mathieu-Daudé > > BaseTools > W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools > @@ -225,6 +226,7 @@ R: Marc-André Lureau > (TPM2 modules) > R: Stefan Berger > (TPM2 modules) > +R: Philippe Mathieu-Daudé > S: Maintained > > PcAtChipsetPkg >