From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.733.1664808343615491278 for ; Mon, 03 Oct 2022 07:45:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=FWr1jYhj; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id A0E6420C31BC; Mon, 3 Oct 2022 07:45:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A0E6420C31BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1664808343; bh=nV3DMX+m/TjEI5fxqfqzJnHisR0ewDh2iTsDAZ8Mh/E=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=FWr1jYhjXyO1xD0MOZlnfV6S31GxF4iVYSxyrArjFFzyIqwDhq+987u9k5cBoAj6P iAfirr+Nh7187Yn2eWmvoPYxTCeh/d53m79g/y90ZcKB3IGHGqYwhN0kUu9yIlrLbG rSeQzvBSsLcWctVAijC9BvWevDD/0DDfRFUR2FUE= Message-ID: Date: Mon, 3 Oct 2022 10:45:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file From: "Michael Kubacki" To: devel@edk2.groups.io, Jian J Wang Cc: Michael D Kinney Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <20220907050530.512-1-mikuback@linux.microsoft.com> <20220907050530.512-2-mikuback@linux.microsoft.com> <742e1908-50f7-1042-e8c6-2baab289034c@linux.microsoft.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Another reminder. On 9/22/2022 9:06 PM, Michael Kubacki wrote: > Review reminder >=20 > On 9/15/2022 3:36 PM, Michael Kubacki wrote: >> Hi Jian, >> >> Can you please provide a review for this patch? >> >> Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series=20 >> will be ready once this patch is reviewed. >> >> Thanks, >> Michael >> >> On 9/7/2022 1:05 AM, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4050 >>> >>> Adds the package as a supported package to .pytool/CISettings.py >>> and adds a CI YAML for the package so it can be run in CI. >>> >>> Cc: Jian J Wang >>> Signed-off-by: Michael Kubacki >>> --- >>> =C2=A0 .pytool/CISettings.py=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 1 + >>> =C2=A0 SignedCapsulePkg/SignedCapsulePkg.ci.yaml | 90 +++++++++++++++= +++++ >>> =C2=A0 2 files changed, 91 insertions(+) >>> >>> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py >>> index cf9e0d77b19b..306e27893e58 100644 >>> --- a/.pytool/CISettings.py >>> +++ b/.pytool/CISettings.py >>> @@ -62,6 +62,7 @@ class Settings(CiBuildSettingsManager,=20 >>> UpdateSettingsManager, SetupSettingsManag >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "UefiCpuPkg", >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "FmpDevicePkg", >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ShellPkg", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 "SignedCapsulePkg", >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "StandaloneMmPkg", >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "FatPkg", >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "CryptoPkg", >>> diff --git a/SignedCapsulePkg/SignedCapsulePkg.ci.yaml=20 >>> b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml >>> new file mode 100644 >>> index 000000000000..5f48613bd79f >>> --- /dev/null >>> +++ b/SignedCapsulePkg/SignedCapsulePkg.ci.yaml >>> @@ -0,0 +1,90 @@ >>> +## @file >>> +# Core CI configuration for SignedCapsulePkg >>> +# >>> +# Copyright (c) Microsoft Corporation >>> +# >>> +# SPDX-License-Identifier: BSD-2-Clause-Patent >>> +## >>> +{ >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/LicenseCheck >>> +=C2=A0=C2=A0=C2=A0 "LicenseCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [] >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 "EccCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## Exception sample looks= like below: >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## "ExceptionList": [ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ##=C2=A0=C2=A0=C2=A0=C2=A0= "", "" >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## ] >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ExceptionList": [ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ## Both file path and dir= ectory path are accepted. >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [] >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/CompilerPlugin >>> +=C2=A0=C2=A0=C2=A0 "CompilerPlugin": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "SignedCapsule= Pkg.dsc" >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/HostUnitTestCom= pilerPlugin >>> +=C2=A0=C2=A0=C2=A0 "HostUnitTestCompilerPlugin": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "" # Don't sup= port this test >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/CharEncodingChe= ck >>> +=C2=A0=C2=A0=C2=A0 "CharEncodingCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [] >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/DependencyCheck >>> +=C2=A0=C2=A0=C2=A0 "DependencyCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDependencies":= [ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "MdeModulePkg= /MdeModulePkg.dec", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "MdePkg/MdePk= g.dec", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "SecurityPkg/= SecurityPkg.dec", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "SignedCapsul= ePkg/SignedCapsulePkg.dec" >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # For host based unit tes= ts >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDependencies-H= OST_APPLICATION":[ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "UnitTestFram= eworkPkg/UnitTestFrameworkPkg.dec" >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # For UEFI shell based ap= ps >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AcceptableDependencies-U= EFI_APPLICATION":[], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreInf": [] >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/DscCompleteChec= k >>> +=C2=A0=C2=A0=C2=A0 "DscCompleteCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreInf": [""], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "SignedCapsule= Pkg.dsc" >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/HostUnitTestDsc= CompleteCheck >>> +=C2=A0=C2=A0=C2=A0 "HostUnitTestDscCompleteCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreInf": [""], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DscPath": "" # Don't sup= port this test >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/GuidCheck >>> +=C2=A0=C2=A0=C2=A0 "GuidCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreGuidName": [], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreGuidValue": [], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFoldersAndFiles": = [], >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreDuplicates": [], >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/LibraryClassChe= ck >>> +=C2=A0=C2=A0=C2=A0 "LibraryClassCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreHeaderFile": [] >>> +=C2=A0=C2=A0=C2=A0 }, >>> + >>> +=C2=A0=C2=A0=C2=A0 ## options defined .pytool/Plugin/SpellCheck >>> +=C2=A0=C2=A0=C2=A0 "SpellCheck": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AuditOnly": True,=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # Failures need to be= reviewed=20 >>> and resolved in the future >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreFiles": [],=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # use gitignore synta= x to=20 >>> ignore errors in matching files >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ExtendWords": [],=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # words to extend to = the=20 >>> dictionary for this package >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreStandardPaths": []= ,=C2=A0=C2=A0 # Standard Plugin defined paths=20 >>> that should be ignore >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "AdditionalIncludePaths":= [] # Additional paths to spell=20 >>> check (wildcards supported) >>> +=C2=A0=C2=A0=C2=A0 } >>> +}