From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.65; helo=mail-wm1-f65.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F8D821959CB2 for ; Wed, 28 Nov 2018 07:02:16 -0800 (PST) Received: by mail-wm1-f65.google.com with SMTP id 125so2983337wmh.0 for ; Wed, 28 Nov 2018 07:02:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3sulv+cKimWHBnGzcDJcHnGPq5uL+lEu55apk/M63qc=; b=gd3sQa1vOWKm+8kGArcQJkogaAHYHFHkhzBNl+4yBJZb3HzNEK3HJB0/YB6xYQ9FE6 HQmdv9McBVaxZeRk2jHuptU0cpNfdKTscC9ItybFddziLF+5SziT6o8rrgQ6sHL5w1LD 2MmW1k3xAsfK9+xT5GHyXqap83OaB82Td2pOAiAtcGIEl67N783PS5+fEFqn4EJwrUzK lfeRTA5Dyp7tz4qv8Z+0bYEGwksJXBd+Qj35ToBJse16+xMDmwAdgmfoYvD+CWt+xIJJ b5+n3ojEdU1N/lXeIW21f8GREqkMzlIh7vUHO58Dyajo+ZGRS8D7BNkJdJhk1BzP1hx7 y9PQ== X-Gm-Message-State: AA+aEWYT8rngVLx9qpOhNVnKtzImUM5T/yu2g3RpjiJEkzjtkdSyIa2h MiFJU5+SAF2vk5Ixe5FRiXXSEw== X-Google-Smtp-Source: AFSGD/VKHQHmIpEVp9xM0E8z8TpJIedt6VHFqT4f/mbwqULURUJGoCewrM/+UfQuCEvvuM8c8AGz9w== X-Received: by 2002:a1c:9e0d:: with SMTP id h13mr3148795wme.150.1543417334770; Wed, 28 Nov 2018 07:02:14 -0800 (PST) Received: from ?IPv6:2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9? ([2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9]) by smtp.gmail.com with ESMTPSA id o67sm2336130wmo.18.2018.11.28.07.02.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 07:02:14 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Laszlo Ersek , Leif Lindholm , Eric Auger , Andrew Jones , Julien Grall References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-12-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Wed, 28 Nov 2018 16:02:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181128143357.991-12-ard.biesheuvel@linaro.org> Subject: Re: [PATCH v3 11/16] ArmVirtPkg/PrePi: base GCD memory space size on CPU's PA range X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 15:02:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 28/11/18 15:33, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 1 - > ArmVirtPkg/PrePi/PrePi.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf > index 1587bd92f206..034ddb41cb48 100755 > --- a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf > +++ b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf > @@ -85,7 +85,6 @@ [FixedPcd] > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c > index f6abe2f2016b..61de6cfd4ae6 100755 > --- a/ArmVirtPkg/PrePi/PrePi.c > +++ b/ArmVirtPkg/PrePi/PrePi.c > @@ -80,7 +80,7 @@ PrePiMain ( > BuildStackHob (StacksBase, StacksSize); > > //TODO: Call CpuPei as a library > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); > > // Set the Boot Mode > SetBootMode (BOOT_WITH_FULL_CONFIGURATION); >