Re: [edk2-devel] [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs

["Michael Kubacki" <mikuback@linux.microsoft.com>]

I found two locations:

Silicon\Intel\CoffeelakeSiliconPkg\Cpu\Library\PeiCpuPolicyLib\PeiCpuPolicyLib.c

Silicon\Intel\IntelSiliconPkg\Feature\Flash\SpiFvbService\SpiFvbServiceMm.c

On 6/30/2021 2:45 AM, Ni, Ray wrote:
> Ok. I understand your patch just merges the existing PCDs from individual XXSIliconPkgs to IntelSiliconPkg.
> Are there any modules that use these PCDs in XXSiliconPkgs?
> 
> 
> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Wednesday, June 30, 2021 10:27 AM
> To: Ni, Ray <ray.ni@intel.com>
> Cc: devel@edk2.groups.io; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Lou, Yun <yun.lou@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
> Subject: Re: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs
> 
> Unfortunately, those cannot be used in the silicon packages.
> 
> This is not new to this series, see existing code:
> 
> https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec#L460
> 
> https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec#L481
> 
> https://github.com/tianocore/edk2-platforms/blob/086a3a3ce6c42c859ee5943eb2c4b6edcefdc241/Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec#L845
> 
> This series consolidates them to one silicon package declaration.
> 
> We can clean up further but this series has been out for 2+ months, rebasing 40 patches is costly, and incremental changes can continue to be made in the future. I originally made this series to prepare the code for some Standalone MM changes and those are still waiting to be rebased.
> 
> On 6/29/2021 1:09 AM, Ni, Ray wrote:
>> Michael,
>> Below PCDs are in MinPlatformPkg. Can you use them instead of adding new ones in IntelSiliconPkg?
>>
>>     ## Indicates the MMIO base address of the microcode FV in flash.
>>     
>> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE60000|UINT3
>> 2|0x30000004
>>
>>     ## Indicates the size of the microcode FV in flash.
>>     
>> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A0000|UINT3
>> 2|0x30000005
>>
>>     ## Indicates the offset of the microcode FV relative to the beginning of flash.
>>     
>> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x00660000|UIN
>> T32|0x30000006
>>
>>     ## Indicates the offset of the actual microcode content relative to the beginning of the microcode FV.
>>     
>> gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x300
>> 00007
>>
>>
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Friday, June 25, 2021 2:21 PM
>> To: devel@edk2.groups.io
>> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
>> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone@intel.com>
>> Subject: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add
>> microcode FV PCDs
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
>>
>> Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries modules in IntelSiliconPkg to be able to use this PCD.
>>
>>     gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase
>>     gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize
>>     gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset
>>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> ---
>>    Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++
>>    1 file changed, 3 insertions(+)
>>
>> diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
>> b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
>> index 097c4ca4d795..fb8391000347 100644
>> --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
>> +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
>> @@ -91,6 +91,9 @@ [PcdsFeatureFlag]
>>    [PcdsFixedAtBuild]
>>      gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF800000|UINT32|0x00000007
>>      
>> gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x00800000|UINT32|0x0000000
>> 8
>> +
>> + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE60000|UI
>> + NT
>> + 32|0x00000009
>> + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A0000|UI
>> + NT
>> + 32|0x0000000A
>> + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x00660000|
>> + UI
>> + NT32|0x0000000B
>>    
>>    [PcdsFixedAtBuild, PcdsPatchableInModule]
>>      ## Error code for VTd error.<BR><BR>
>> --
>> 2.28.0.windows.1
>>
> 
> 
> 
> 
>