public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Matthew Carlson <macarl@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
Date: Fri, 7 Feb 2020 09:31:50 +0000	[thread overview]
Message-ID: <f3282f7d50d94037b71ce17c0ca81ca5@intel.com> (raw)
In-Reply-To: <20200207083725.13080-1-zhichao.gao@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Friday, February 7, 2020 4:37 PM
> To: devel@edk2.groups.io
> Cc: Matthew Carlson <macarl@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
> 
> From: Matthew Carlson <macarl@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2482
> 
> Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added
> for type 17. One is "Extended Speed", the other is "Extended
> Configured Memory Speed". The lack of these field may cause strange
> error in some operating systems.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> V2:
> 
> 1. fix some typo.
> 2. Do not update the copyright.
> 
>  MdePkg/Include/IndustryStandard/SmBios.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
> index 8b3c4d7ba9..def874be28 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1843,6 +1843,11 @@ typedef struct {
>    UINT64                                    VolatileSize;
>    UINT64                                    CacheSize;
>    UINT64                                    LogicalSize;
> +  //
> +  // Add for smbios 3.3.0
> +  //
> +  UINT32                                    ExtendedSpeed;
> +  UINT32                                    ExtendedConfiguredMemorySpeed;
>  } SMBIOS_TABLE_TYPE17;
> 
>  ///
> --
> 2.16.2.windows.1


      reply	other threads:[~2020-02-07  9:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  8:37 [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17 Gao, Zhichao
2020-02-07  9:31 ` Liming Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3282f7d50d94037b71ce17c0ca81ca5@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox