From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, eric.dong@intel.com
Cc: Ray Ni <ray.ni@intel.com>,
Chandana Kumar <chandana.c.kumar@intel.com>,
Star Zeng <star.zeng@intel.com>
Subject: Re: [edk2-devel] [Patch v3 6/6] UefiCpuPkg/RegisterCpuFeaturesLib: Start all processors simultaneously.
Date: Fri, 26 Jul 2019 12:38:29 +0200 [thread overview]
Message-ID: <f3484f29-fe6c-50cb-b66a-782775920d54@redhat.com> (raw)
In-Reply-To: <20190724070727.14976-7-eric.dong@intel.com>
On 07/24/19 09:07, Dong, Eric wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
>
> For semaphore type register, it required all processors to do the
> task at the same time.
> Current logic begins BSP's task after all APs have finished their tasks.
> This will caused set semaphore task hang if semaphore has package
> level type.
> This patch use new EDKII_PEI_MP_SERVICES2_PPI to start all processors at
> the same time to fix the potential hang issue.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Chandana Kumar <chandana.c.kumar@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> .../CpuFeaturesInitialize.c | 2 +-
> .../DxeRegisterCpuFeaturesLib.c | 6 +-
> .../PeiRegisterCpuFeaturesLib.c | 66 ++++++++++++++-----
> .../PeiRegisterCpuFeaturesLib.inf | 1 +
> .../RegisterCpuFeatures.h | 2 +-
> 5 files changed, 54 insertions(+), 23 deletions(-)
My testing did not cover this patch.
Thanks
Laszlo
prev parent reply other threads:[~2019-07-26 10:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 7:07 [Patch v3 0/6] UefiCpuPkg: Enable Edkii Mp Services2 Ppi Dong, Eric
2019-07-24 7:07 ` [Patch v3 1/6] UefiCpuPkg/Include/MpInitLib.h: Add MpInitLibStartupAllCPUs API Dong, Eric
2019-07-26 10:36 ` [edk2-devel] " Laszlo Ersek
2019-07-24 7:07 ` [Patch v3 2/6] UefiCpuPkg/MpInitLib: " Dong, Eric
2019-07-26 10:36 ` [edk2-devel] " Laszlo Ersek
2019-07-24 7:07 ` [Patch v3 3/6] UefiCpuPkg/MpInitLibUp: " Dong, Eric
2019-07-25 8:53 ` [edk2-devel] " Ni, Ray
2019-07-26 10:37 ` Laszlo Ersek
2019-07-24 7:07 ` [Patch v3 4/6] UefiCpuPkg: Add new EDKII_PEI_MP_SERVICES2_PPI Dong, Eric
2019-07-25 8:53 ` Ni, Ray
2019-07-26 10:37 ` [edk2-devel] " Laszlo Ersek
2019-07-24 7:07 ` [Patch v3 5/6] UefiCpuPkg/CpuMpPei: Produce EDKII_PEI_MP_SERVICES2_PPI Dong, Eric
2019-07-25 8:55 ` Ni, Ray
2019-07-26 10:38 ` [edk2-devel] " Laszlo Ersek
2019-07-24 7:07 ` [Patch v3 6/6] UefiCpuPkg/RegisterCpuFeaturesLib: Start all processors simultaneously Dong, Eric
2019-07-25 8:59 ` Ni, Ray
2019-07-26 10:38 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3484f29-fe6c-50cb-b66a-782775920d54@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox