From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.32338.1629992196381553559 for ; Thu, 26 Aug 2021 08:36:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=nzs8IWBo; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id E74D620B8615; Thu, 26 Aug 2021 08:36:34 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E74D620B8615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1629992195; bh=X2pBSvmn1AQWywrH/ufaPud3K9RQtc3lJB7ofjptO/I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=nzs8IWBoZQKzvsddV4fZr/t+000DJFNdSYVgGrBDhVGe74dkbPNeddg/nHw222KWg J4cXTRAeFhLKJjUUaX+z7QpRo8ifOshmjmPmf7YJdZXzZIrx+7rZ9jK6jYgoY9I5f1 bk3tVNTpzkWZlEKBUTmSt5M3fxwbN17VPEgwob2w= Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com Cc: Chasel Chiu , Michael Kubacki , Benjamin Doron References: <20210826035546.1771-1-nathaniel.l.desimone@intel.com> From: "Michael Kubacki" Message-ID: Date: Thu, 26 Aug 2021 11:36:34 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210826035546.1771-1-nathaniel.l.desimone@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Reviewed-by: Michael Kubacki On 8/25/2021 11:55 PM, Nate DeSimone wrote: > Added EFI_INVALID_PARAMETER to the EcRead() > function's list of return values. > > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Benjamin Doron > Signed-off-by: Nate DeSimone > --- > .../Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h | 9 +++++---- > .../KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c | 9 +++++---- > 2 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h b/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h > index 7c58e592d9..e95accc465 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h > @@ -7,7 +7,7 @@ > Make sure you meet the requirements for the library (protocol dependencies, use > restrictions, etc). > > -Copyright (c) 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -109,9 +109,10 @@ LpcEcInterface ( > @param[in] Address Address to read > @param[out] Data Data received > > - @retval EFI_SUCCESS Command success > - @retval EFI_DEVICE_ERROR Command error > - @retval EFI_TIMEOUT Command timeout > + @retval EFI_SUCCESS Command success > + @retval EFI_INVALID_PARAMETER Data is NULL > + @retval EFI_DEVICE_ERROR Command error > + @retval EFI_TIMEOUT Command timeout > **/ > EFI_STATUS > EcRead ( > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c > index d14edb75de..14a746172b 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c > @@ -1,7 +1,7 @@ > /** @file > Common EC commands. > > -Copyright (c) 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -16,9 +16,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > @param[in] Address Address to read > @param[out] Data Data received > > - @retval EFI_SUCCESS Command success > - @retval EFI_DEVICE_ERROR Command error > - @retval EFI_TIMEOUT Command timeout > + @retval EFI_SUCCESS Command success > + @retval EFI_INVALID_PARAMETER Data is NULL > + @retval EFI_DEVICE_ERROR Command error > + @retval EFI_TIMEOUT Command timeout > **/ > EFI_STATUS > EcRead ( >