From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F85F81E82 for ; Fri, 11 Nov 2016 04:33:00 -0800 (PST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8EB2834A7; Fri, 11 Nov 2016 12:33:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-102.phx2.redhat.com [10.3.116.102]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uABCX16B022083; Fri, 11 Nov 2016 07:33:02 -0500 To: Jeff Fan References: <20161111115740.8024-1-jeff.fan@intel.com> Cc: edk2-devel@ml01.01.org, Feng Tian , Jiewen Yao , Michael D Kinney , Paolo Bonzini From: Laszlo Ersek Message-ID: Date: Fri, 11 Nov 2016 13:33:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161111115740.8024-1-jeff.fan@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 11 Nov 2016 12:33:03 +0000 (UTC) Subject: Re: [PATCH 0/2] Place APs to suitable state on Legacy OS boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 12:33:00 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/11/16 12:57, Jeff Fan wrote: > Currently, DxeMpLib only places APs into specified c-state in Exit Boot Service > callback function for UEFI OS boot. We need to put APs into specified c-state > for legacy OS boot also. > > https://bugzilla.tianocore.org/show_bug.cgi?id=210 > > Jeff Fan (2): > UefiCpuPkg/DxeMpLib: Rename MpInitExitBootServicesCallback() > UefiCpuPkg/DxeMpLib: Place APs to suitable state on Legacy OS boot > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 18 +++++++++++++++--- > 2 files changed, 16 insertions(+), 3 deletions(-) > >>From a cursory look, it looks good to me, but I think I'll leave the official review on this to Mike et al :) Also, a meta-hint: when you post a cover letter for a patch series, it is best to collect all the CC's from the patches, sort them uniquely, and then add the resulting CC list to the cover letter as well. This way every CC'd person will receive the high level description for the entire set. https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 * finally, add all of the Cc: tags to the cover letter that you used across all of the patches. This will ensure that even if a maintainer is involved in reviewing one or two of your patches across the series, he or she will get a copy of your cover letter, which outlines the full feature or bugfix. Thanks, Laszlo