From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.71]) by mx.groups.io with SMTP id smtpd.web12.6780.1666787680360300375 for ; Wed, 26 Oct 2022 05:34:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=FUwkbijr; spf=pass (domain: arm.com, ip: 40.107.7.71, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cBDpnEIseP7y9QKG8ZjUAtKgIqwHmeFwmlXfga70dmSHOnyOjgwujPmpEpKD33E54Y89TaWWsUQsIHmrY4lCr4bmqezCl8T49kjGG/sSz30xu+yGzUR4NO7ZLAQXzbsQiInynDFGZlGrArgsu1w0pefAeMH+oZIqs98sFqlXoKyg409PP8T0eWfMbgvcvktJtKxSqeoWL9BoxuzYpouEr9m8yKxDc+6lUU4pREjrxswnQRd4EXb/bvNFjAA0+LrJ1xFPM8wFdmEi++xq7WWFysE5EPle2SzgVGY0Awj1Po0qUwyC5cVppDngEr864wKbPh3dwET5/ghEMQRLDuil+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e1k/Xgh9te5HcAJKI2SFMQHm2xGuoT0XV8Rq6nPoOX0=; b=BFzenr+Dr6U69r1WmJrnmIyN/Wc3oc8SbidCdRypqqVUR5uhYvXqpD5GmfwBquCfKQH+9oyN8XQ8ColVomsKkiJyQK5ns+pNFGn9O1E2aPghjWWCGzXdZbyZv15UNVbFXlxXdfEN1bRiXpaxZ301fANNl/IJY4H4GQB4eUp8PyBBzAR0g2gR/prQWjhg7nn4a88xz4O9WKEm5f+rbn0mxrZMA+Ma88ne1Ey3MCMisWQ8F5ULhrpi29X2q/N6u99fdXro/RGbfHVEDKdL8N/4Le1BIQD9ALFCLvM3vhxO8/n6GkA3hV8J9mfOKIqBo/UzSJZ0K8Y8sjpDZPkz2ESNXA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e1k/Xgh9te5HcAJKI2SFMQHm2xGuoT0XV8Rq6nPoOX0=; b=FUwkbijry+fR4/3SIVUyNb92+MFboE/FR5729XmTAUQtckd9WDiytuJNeIib0zVEVpvBh/+OYzqfPUFHTzuaEzq/gKRpm2NMp5nUITjD0gNoc8SyIUEGuC80nBjvaBwnhxwFvHs4hciCuwevpsSJNQHrCT+WPWD7v3rilFvMfLE= Received: from AS9PR06CA0716.eurprd06.prod.outlook.com (2603:10a6:20b:49f::24) by AS2PR08MB10036.eurprd08.prod.outlook.com (2603:10a6:20b:64d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Wed, 26 Oct 2022 12:34:36 +0000 Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49f:cafe::6d) by AS9PR06CA0716.outlook.office365.com (2603:10a6:20b:49f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend Transport; Wed, 26 Oct 2022 12:34:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend Transport; Wed, 26 Oct 2022 12:34:36 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 26 Oct 2022 12:34:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9687fd4aadf1f5ad X-CR-MTA-TID: 64aa7808 Received: from 47c98d2ce509.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FB891A16-1A2A-4996-8B89-A8F7BFBEF487.1; Wed, 26 Oct 2022 12:34:30 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 47c98d2ce509.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:34:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OAjt5iaPjW5VJGeYrP3A3Pe+/7mg/b3ycz+5EGKqzMi/4CGv8rF0jkdYJhpUNjYlfrgVxCvawH1O3meSUL6L41OnMoBeNTcuZWCTY+uNewWm++uqsCPQhQdJ+nEdk6cI0WO72H0OQDjca10LesenQTTmLctQ49xCVKxnsyD0CqtM1bwHRjYka5vVO7jz6q5B6fo6mlIDGpathaI3Z9cUxrgOpC6d9fT9Z268adFLA8vjyAPzLfkg1xAg8SOQ6Di0Fnq2knM8pdZkt7eo61vNE9DwiYL2uoBwhfnAOBx8wi1tEdrykin6RMOVPT07uY4YAOe0lImPnt8ZoesJ6TUFyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e1k/Xgh9te5HcAJKI2SFMQHm2xGuoT0XV8Rq6nPoOX0=; b=O/K9CK+0123Yq+g3S2hfmcNfV/jnPlkPXTQfBRC+gRJlTgt4TCEEAEe6wnd18sNtla04i48xVz6sMTS6+3jwoGPrpzzgZBWbTHe7qwHzldX7RUJDSe5lCf1JyJtoaC7FS5OFLRpTkf3C3LsCHEs7TbNoMNCbWU5AcGm97vY5Rxcwm0w3K7Rh4K8pdq4qrVWcuxtm6H7pfmeJQv8/P4LdKxynk00QznYczZD0khwAaU6GsH0E9EaLFk7/onxmq/oj8I85WA4hG8weZ5CM2joNS+VdjFub/3twHWaqFVi4TMW1wg37Jh96tEmXUNkISf9pmhBfgbzl1mQxqB3nVH1YgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e1k/Xgh9te5HcAJKI2SFMQHm2xGuoT0XV8Rq6nPoOX0=; b=FUwkbijry+fR4/3SIVUyNb92+MFboE/FR5729XmTAUQtckd9WDiytuJNeIib0zVEVpvBh/+OYzqfPUFHTzuaEzq/gKRpm2NMp5nUITjD0gNoc8SyIUEGuC80nBjvaBwnhxwFvHs4hciCuwevpsSJNQHrCT+WPWD7v3rilFvMfLE= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DBAPR08MB5813.eurprd08.prod.outlook.com (2603:10a6:10:1a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 12:34:28 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:34:28 +0000 Message-ID: Date: Wed, 26 Oct 2022 13:34:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 06/14] DynamicTablesPkg: Fix wrong/missing fields in CmObjParser To: Pierre.Gondois@arm.com, devel@edk2.groups.io Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-7-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-7-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P265CA0180.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DBAPR08MB5813:EE_|AM7EUR03FT046:EE_|AS2PR08MB10036:EE_ X-MS-Office365-Filtering-Correlation-Id: c7f655e6-122a-41ff-ea31-08dab74e7162 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lFgwk7fK3bEaGj6SrKX1uwwFgoWE9z1oRtKxovdObXkW3iFlR0/Nu646moxFM1HGE+pAuFDPHubKI/EKK4aDe2Ce+EuKOZ9dd38r35wjduJDm54lSbi/VUQRePXDZau06mWbsRDDFs0t0i8LsZNsP6t0OJoC9IpeKclaryaKrrrx2y1/Y6G/WsqJ7iNiOf3tNWxiAssw0wOrQKYlft7+x8PqLNLIoEuqGjoEDUmmf24mfJQniYnUKF4Edmg4g/pE5luEIcE3to1v6lpqxRoZkVauxX9UzLOJAZOyjCe8vTS1pu0Ir5O35NQy4+f3Lz1UV6GYdO5n6eMU10WEQdAzrDYPmaLH3ZqP/qCWhKTDOTRiblTU1eiZhuMyMOALLVM5yvtRP+4MLjdUgdsLQy+wDabwEUqVQcuFgp283+Far0/2qE4p9wzl1K9QtzK4zzjdINi8ODaTbM+4WzXhwOW3T7k6W87IR3/Q9B8bhXW/Ss9tfVV+RcmYy7NVp/q3ZffSY598/MCdW6czpZNRjnDO9QgrcrwtlO2Y/54B7h7FZjrs7t8IbJIGvLlQEppp4MksxYxvABStUTprZwiaXFFzqaVEyKbrnUqiklLM/yyAXCndDMAQF976L0U/Det6MgnABjj5WwIkuWZV07YL8MQbz4KETNgn3dbzFVyApdkwVoGfKi5H/usLGCJ6+4kf5tcmwtwo/EVcBF9FzN9fCe7hogYiBkrAgZjmTahxfCH7/PtvhiYiOsscVqfNIMu2ukHnFKUbU907rPdF9UC8tv0B/n7Gojyx8d5iVh3lu2ccBf8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(451199015)(38100700002)(6512007)(36756003)(186003)(2906002)(31686004)(83380400001)(41300700001)(2616005)(26005)(8936002)(5660300002)(44832011)(6486002)(478600001)(86362001)(31696002)(6506007)(8676002)(66556008)(66946007)(66476007)(4326008)(53546011)(316002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5813 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4fab8ee3-47a3-46a0-93e9-08dab74e6c28 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p0JXcHQvdsPTGG02wrnVXO7oqd/QGimmDo5zbBH5URZZy5nJbmtEOMtpEugA26T0JQUkm4JhKplopcGXMr1LmgCyiW9Lw/tqY2GJD1KQBtH2OH2NewEL+PHkNwSn4XSuny9+YOGfcwycjIR6CCHL4haChXK3w359GqjYlKY+PK0wk6kuUHdi8qUwGue4qMO4MKxLwMDLftluOe3A1FGyOPiZDoNnloMBRS+3QSudDwtfXphEScjVbPqLhOhFyUCvAgaVI4IaiA47rtIl7Os1ixPkYJZb4a2q/O4f5yJ9F0kw3KiNPxneLI//lpHjrq0dIi2yXlSktJYwJ9nr2nXcyZtnYvH45obIIrsbZs0PyTY8gH9vt+61cQgzBQVr4oy69LZwZxmTfWAtFUii9KYNzT2sHsnccpiZ4Jkq03T/EfK/GCP0KkJh1yz6I5ZPBgi1qmBh4Y2YrMpvEGLc56U9G1J7VOF2UaVz6uqgJSTcHnUJjxweY0YjF28hm3VKBA3ReE2pRNtkkRZE5019ZXUIKqoZlUjAKqjSXNhp5WeWj9bsyXNBXcodMT9xZQcvjJUNfadav7zgSXXdTawqkgN0ctLS1FRxGJxAdAKIUZjJelOCaZlGihTaq+8HPsVUczcnfeh2kXIsqWEogEJuW+xR7bbdd1gZJTMNGSMfI0hSCBVi9Zvuj1qAK4Xzfpau3mp3l5b5CW3SPUprMUvO5SfIzOoyxNx2gbcYld1P8j+Sd8XmFdkDncRvxbE3hEeGMDWYpgDD7FN8HN2oXEbHWaAF46D+QURjJCnPpV2d8amKxxYsP3Y8mBT2dx/AeypbDcaK X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(6029001)(4636009)(396003)(39860400002)(376002)(136003)(346002)(451199015)(46966006)(40470700004)(36840700001)(478600001)(31686004)(82310400005)(82740400003)(6486002)(356005)(81166007)(40480700001)(8936002)(47076005)(36860700001)(54906003)(316002)(31696002)(53546011)(86362001)(26005)(83380400001)(41300700001)(2906002)(5660300002)(336012)(6506007)(186003)(36756003)(6512007)(70586007)(40460700003)(8676002)(2616005)(4326008)(70206006)(44832011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:34:36.3361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7f655e6-122a-41ff-ea31-08dab74e7162 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10036 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, I have one comment marked inline as [SAMI]. I believe other than that change this patch should be good. Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Add missing fields to the following CmObjParser objects: > - EArmObjGicDInfo > - EArmObjCacheInfo > and fix wrong formatting of: > - EArmObjLpiInfo > > Signed-off-by: Pierre Gondois > --- > .../ConfigurationManagerObjectParser.c | 24 ++++++++++--------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > index 040aaa4cbb17..2126beba8b9f 100644 > --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c > @@ -303,7 +303,8 @@ STATIC CONST CM_OBJ_PARSER CmArmProcHierarchyInfoParser[] = { > { "ParentToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > { "GicCToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > { "NoOfPrivateResources", 4, "0x%x", NULL }, > - { "PrivateResourcesArrayToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL } > + { "PrivateResourcesArrayToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > + { "LpiToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, > }; > > /** A parser for EArmObjCacheInfo. > @@ -315,7 +316,8 @@ STATIC CONST CM_OBJ_PARSER CmArmCacheInfoParser[] = { > { "NumberOfSets", 4, "0x%x", NULL }, > { "Associativity", 4, "0x%x", NULL }, > { "Attributes", 1, "0x%x", NULL }, > - { "LineSize", 2, "0x%x", NULL } > + { "LineSize", 2, "0x%x", NULL }, > + { "CacheId", 4, "0x%x", NULL }, > }; > > /** A parser for EArmObjProcNodeIdInfo. > @@ -400,14 +402,14 @@ STATIC CONST CM_OBJ_PARSER AcpiGenericAddressParser[] = { > /** A parser for EArmObjLpiInfo. > */ > STATIC CONST CM_OBJ_PARSER CmArmLpiInfoParser[] = { > - { "MinResidency", 4, "0x%x", NULL }, > - { "WorstCaseWakeLatency", 4, "0x%x", NULL }, > - { "Flags", 4, "0x%x", NULL }, > - { "ArchFlags", 4, "0x%x", NULL }, > - { "ResCntFreq", 4, "0x%x", NULL }, > - { "EnableParentState", 4, "0x%x", NULL }, > - { "IsInteger", 1, "%d", NULL }, > - { "IntegerEntryMethod", 8, "0x%llx", NULL }, > + { "MinResidency", 4, "0x%x", NULL }, > + { "WorstCaseWakeLatency", 4, "0x%x", NULL }, > + { "Flags", 4, "0x%x", NULL }, > + { "ArchFlags", 4, "0x%x", NULL }, > + { "ResCntFreq", 4, "0x%x", NULL }, > + { "EnableParentState", 4, "0x%x", NULL }, > + { "IsInteger", 1, "%d", NULL }, > + { "IntegerEntryMethod", 8, "0x%llx", NULL }, > { "RegisterEntryMethod", sizeof (EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE), > NULL, NULL, AcpiGenericAddressParser, > ARRAY_SIZE (AcpiGenericAddressParser) }, > @@ -417,7 +419,7 @@ STATIC CONST CM_OBJ_PARSER CmArmLpiInfoParser[] = { > { "UsageCounterRegister", sizeof (EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE), > NULL, NULL, AcpiGenericAddressParser, > ARRAY_SIZE (AcpiGenericAddressParser) }, > - { "StateName", 16, "0x%a", NULL }, > + { "StateName", 16, "NULL", PrintString }, [SAMI] I think the format specifier should be NULL and not enclosed in quotes. If you agree I will fix this before merging. > }; > > /** A parser for EArmObjPciAddressMapInfo.