From: "Laszlo Ersek" <lersek@redhat.com>
To: Gary Lin <glin@suse.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Liran Alon <liran.alon@oracle.com>,
Nikita Leshenko <nikita.leshchenko@oracle.com>
Subject: Re: [PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec
Date: Wed, 15 Jul 2020 17:45:14 +0200 [thread overview]
Message-ID: <f3f75bfe-5d29-22f9-68df-eea412e1177f@redhat.com> (raw)
In-Reply-To: <20200715082031.30978-1-glin@suse.com>
On 07/15/20 10:20, Gary Lin wrote:
> The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the
> previous toke value is 0x39.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> OvmfPkg/OvmfPkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index 65bb2bb0eb4c..2b0f137cbcce 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -172,7 +172,7 @@ [PcdsFixedAtBuild]
> gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiMaxTargetLimit|7|UINT8|0x39
>
> ## Microseconds to stall between polling for MptScsi request result
> - gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40
> + gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x3a
>
> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8
> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9
>
Thank you for the patch!
I've updated the subject:
OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec token value
I've also fixed two typos in the commit message (s/toke value/token
value/, twice).
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
I'm trying to merge this via <https://github.com/tianocore/edk2/pull/797>.
But, the PR seems stalled -- github appears unable to find the very
commit that I just pushed with the branch.
And this time even <https://www.githubstatus.com/> seems to confirm the
issue -- it says "Some services are degraded". ... Oh wait, it's
progressed to an "incident" even:
https://www.githubstatus.com/incidents/phnch1rww464
Really frustrating. I've got stuff to do, and now I get to cirle back to
this merge request... when exactly? Sigh.
Laszlo
next prev parent reply other threads:[~2020-07-15 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 8:20 [PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec Gary Lin
2020-07-15 10:22 ` Liran Alon
2020-07-15 15:45 ` Laszlo Ersek [this message]
2020-07-15 16:51 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f75bfe-5d29-22f9-68df-eea412e1177f@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox