From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.9702.1594827927036695042 for ; Wed, 15 Jul 2020 08:45:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mr+K5mhw; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594827926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BMNg7RJ2UYNRpMWVF0GhyBRF904fAEH9Mr5UAHB8LQQ=; b=Mr+K5mhwwSKclozFia3wfi6LljxmU94sZWgGfaaz18tQosTs5gwmvhOZggv29Ucl219Z6H errEXEHQfLrVERG4DYn5JReevmYzG2V1DVZl8/Pdjutf+oNqMmF7zyJiqTMsiv0ZDKDjfQ Zf9r5ni8JMUKsX+52KML4LP7tAZgSSI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-0ToJDoiwPk2tvOoyppvWfA-1; Wed, 15 Jul 2020 11:45:18 -0400 X-MC-Unique: 0ToJDoiwPk2tvOoyppvWfA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7B2A1932481; Wed, 15 Jul 2020 15:45:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-3.ams2.redhat.com [10.36.114.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3130B10013C2; Wed, 15 Jul 2020 15:45:15 +0000 (UTC) Subject: Re: [PATCH 1/1] OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec To: Gary Lin , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel , Liran Alon , Nikita Leshenko References: <20200715082031.30978-1-glin@suse.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 15 Jul 2020 17:45:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200715082031.30978-1-glin@suse.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/15/20 10:20, Gary Lin wrote: > The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the > previous toke value is 0x39. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Liran Alon > Cc: Nikita Leshenko > Signed-off-by: Gary Lin > --- > OvmfPkg/OvmfPkg.dec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index 65bb2bb0eb4c..2b0f137cbcce 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -172,7 +172,7 @@ [PcdsFixedAtBuild] > gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiMaxTargetLimit|7|UINT8|0x39 > > ## Microseconds to stall between polling for MptScsi request result > - gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x40 > + gUefiOvmfPkgTokenSpaceGuid.PcdMptScsiStallPerPollUsec|5|UINT32|0x3a > > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT32|0x8 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT32|0x9 > Thank you for the patch! I've updated the subject: OvmfPkg/OvmfPkg.dec: Adjust PcdMptScsiStallPerPollUsec token value I've also fixed two typos in the commit message (s/toke value/token value/, twice). Reviewed-by: Laszlo Ersek I'm trying to merge this via . But, the PR seems stalled -- github appears unable to find the very commit that I just pushed with the branch. And this time even seems to confirm the issue -- it says "Some services are degraded". ... Oh wait, it's progressed to an "incident" even: https://www.githubstatus.com/incidents/phnch1rww464 Really frustrating. I've got stuff to do, and now I get to cirle back to this merge request... when exactly? Sigh. Laszlo