From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0083.outbound.protection.outlook.com [104.47.38.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7BB9221C9E7BC for ; Tue, 11 Jul 2017 11:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XjZarydgGwPUxJqodG1ypOmteRj8kKRvEu1svqvEsb8=; b=KrnTN1x+HVzO9kW1l1BB1LhqGE86Gqn/DqHs3vRfRog09kbVd6GPlYO5y95jLcawoJ0gAb8u3CWOyQWTYUV9VPcpKK2/jMJO2Bqe+HAYpeHgZE3ECwGssuY/ipkzK/fh0Oye7F8l1AkdzU3q6T90sj+q1oeKIaDkoxhP1NoOyn0= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from [10.236.136.62] (165.204.77.1) by SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.13; Tue, 11 Jul 2017 18:13:53 +0000 Cc: brijesh.singh@amd.com, Jordan Justen To: Laszlo Ersek , edk2-devel@lists.01.org References: <1499792934-9258-1-git-send-email-brijesh.singh@amd.com> <3b31ba2f-04ba-1aa1-5baf-d2a13d3570b8@redhat.com> From: Brijesh Singh Message-ID: Date: Tue, 11 Jul 2017 13:13:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <3b31ba2f-04ba-1aa1-5baf-d2a13d3570b8@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR21CA0063.namprd21.prod.outlook.com (10.172.93.153) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e73c779-0abd-4ff6-3add-08d4c8889717 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 3:2igcdrvzVomFtxpqptuN61WBSiZ6oHdnVn3LimSJQfGstREM8NBn8ayq9iUxnq9F6LJ2SPk3DiTLAfZ99HsfBIQfe+eqg+Olx+IWM7IRVWpgahBDzcqJjwBdbnt+Z5ApO1jZVgK2IgwjPqniYqBc7ae6DvA8PXWqNTL2ybHcGMpCqMJIa4CycaSBJ5uXlGbA0dIxpqf0qr+x1XdfU+4wVB5cjZzU+XperZ94ds/bvrQ5NvalM/+pc67cR2xkypDscVHU4mKzQP40KFCvgNkPTwFLX2UhWV9WiDpOi9cchDEdwW8ciNHR1ZfOohf3J7ybKdgvIWo1osl7xw83c8h56whyWC96Cf3UOAkmotalhYUiJXVv2A4QRWYjU4ioB8pPnyF+gFxu8wevUGMZfpf38+Xcg5WVajnQJT/ZUOorqOjLiGIqmIJIfQVume7AAmL6IV/9LPCCXwkzk2dGJ8EJ/+nAuW3dBLDjNpjiSPfWU1qPbfl8JKq77wUjLBBsTdUgxEypeQdMVRpR7rG1esV6Zk2F+tVsRr3xb6OueviOi2EYNd1zgpBWq04f8y6SuOfdDHR43ZwidjlIktg/+QbS1d6hAnjtO6C7lJUD39RON0lgFus3BEMCHsRI4lBxjbk6oYUqCw6zFcxj6rogDEXdR8K+glfFLTkt+oJHi8CLmGtqjQ/EI0U9SkBiFQckyK0skNKn9dJqsSbssK8kbJTG3xRHBYlu17gR8QWlKEgywjhjycsdW4kuzSfLrmkgt70WUuntbzI7ISC5OYiZpdRiuw== X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 25:yTcP4AE2vD4I06fIw8VIbBiUqoYX979+7mZQGIvm+uGY+NMfr0/C5mdiDk3gFZgSDCT7Sz/YC/5L5ZQoopVGakGo0gASkK9LLBTd3LXigjdGVzgBZsdixnFT6bGNLj+ajBb+KoVzhyoKI2SktIhpBpF4Lyge2bmTd9+1rItXsHakPD2fxKWbgAXULDF+1fu5ZqYUnUMhZ5WNoX43KzIpBbHd0ZTIYbonirSCkZwENnZ85VFGkSh3ReTRX+piD/1XiSHQlPCDDUPXa497JBIz2nTBgW0PMktvF5p8scHe3CA1nFYziAtJ7LLutuh4nwhICOyKhF4FV5HueSQ1nMOpqDPyf8ji7zOjAz1VMxrP/M98j9wHt0kvHy8JcnwzTNPBnTFo3vhSZiqNJnuhA2IWomIkUI8+bT57nLOj/8v2ykqnoNF867a58QHUoizqWLkYIEiKTt1geMqQeNBLzh4ikhlPpGphIeRfjfZ5ifP+TjUEQBwSbLb1WP/UBCuLZ3IjPJBtPi+SHz3tBbUs+q5yo77M24iaMftTGDckO0I8wYmiKBx6/oPmovL1Tt26W3f+W0WzvSXwWtpZWg87soLkcdvd3u0YEgc/xlw9eshXvtQsg2aeBEfuAqC2ye92bXTAt2yVN3Ug1Fxb/h/9SYtiKtrEd6X1Yz8LY5BStw9hXh0tuoTs3S+ToioPVBdhWCjpOi5X7ps8Rf2LL9Zwc4sXMKgkoYC9KPxBvaH62v/3eL9qqpp7Nca6pn7p8KtEkFa+T5lYCI39LP3p+EXN24Gaou/8j+OZFxtC87ER7LNHipfy3aip2ImQNkB1VUfsL7DrxjYmUYJrSulex58KSnWiIGum3jSGOFnvNS9ZNnKOCTCqdud7tbjoG/WsXAP8BUuky3RxKUauZ7OOG4AjwATABtWJaE99u8Ibr5MTnm86yjs= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 31:Z69SUXmJyrPs8Cc7DkU8IzrT+b1Mq5kZvkijuqohtsnn+vQ/+DHVkiLzJTGtgyZeneHixSgyjbNTW774PoirabO+GJ2qtC9WDafwikpE+HQpGANT+qCVbPl9Ezw3Usm1pGCIuEjhlXWLkcar9NlBtI9VnNs6aUrcMQgIZhu1//yTIu0GxtjNeYuBf2/XCV6XdWgJSmNcRH44xhO2+vvyESBrtU4Wn/dH6S2j1Pdwf5SrTXo5yqpG7TUFfe+GNJ5A7tBqeDognjFA62cjdOJOs7TDgWrcyoUcaAaJCvfONak4uh+ttLGBampiHx+3go3KIC5CknWZnu9C5bLyL1CpZNmBcZlfipAhpZYUU3CK4JIRsSenkwFXF/nsGNpECVA/XALkAhI8vC+Vg/HqU3S6viJWDSubRuGj29rucREsLwJgxvz1VmIOaH4sMTt/RvDTMgaT0JKZjWqi8/Inf8s2l5Oqe7nTOcfSZbX/uhW4xX9x2XLF9chVckIoEaNGpMpwPfqC6HFor5sqeFJ66GmuosvPKRl4i/sLKOfmU08RmsJW9sEqtGa6SPc1nsJlFZI62Ya3UjP18xIF7Gh9YhCpTNT6eGqDgotw77tpu9FT7w8JQdgChpD7zAJhPfEBrAxEd6nH6f2NWU50fqo+P0XKLvsw35YHVyKiW4pGlFRBDSA= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 20:M1KPXaVVUK/vawk0qQcyDRVxVgxknHGa+JEe0YGjG/QgTDGm23LKOzqAR6llTGh8d4f/6HofOfeYiBPRO2M627EhrctoxhcFzdBUwwuKuy9oJqF8A6EYiQfZGKcUDiik3Na1cGPUuTVrlxdMAot5X2aLoENFwlLU3ET+hesTlS7Fm7P0tito1USnley2aUYW/ksHdQ2pgy1lmx5V2XlyAookJGmmGSfouwTCOgr2QX91PCucl7Llm4YkdR4OTBPv7woZj9Y5Zp7YtEC4INzBLwor6KbBk5ccxxMQ+lUFXeMtt3X2PTM+qFFO0qid2Col+DnYJRkp1k/LF1mBQeoLWYLV+hVDZVIIV/7kEumOC9rPvg80mL43QRG8bWTXEnUZot2j9L9qoZXl2Z/w5qL/WS9K1SykaVmU0Qlr1/BTHIYTWdX7jE/G43t5CzYcnn+cvwSLPdeqK7xRdcpN1BIrhAr4a2r62Yy6pVTam72aWV0WN8s/TK2K2hwnTXDcBGmj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(767451399110)(167848164394848)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:SN1PR12MB0158; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzQ6dVE3KzV4NFhTdFB2dEd3V2E3SGNHUWtLdU1Z?= =?utf-8?B?M0pnUitIMTNUbUtxMDF3UVVvQ09aMTZRekxqd3ZWMExUZWE5UTlqUGVRREpq?= =?utf-8?B?UGozdVVDK1Nva3BLV0c5U0pDa08yQ0JaeWY3dU04Z3Q3aTZlTGlKdVJLLzlM?= =?utf-8?B?Z1gwUkhZcGhqQmZ2ZVZvL3dJNm1xSVdWRURjN1huWENwbkttZmpmODd5dzFh?= =?utf-8?B?Q05YU29RMmVabGh5K0NkSjBBOVh4amtoenhDRmxmMGs5MkxTR0VVSjVucUww?= =?utf-8?B?ajZoZkN2Z091ckxrd1hJQTd1TTJqYVVqODhNeHJYbGtnbEtKQWJkRmJWdXZ4?= =?utf-8?B?d0lYL3VXb3JqNWwzL0NodW9oZVB1K09QMzJUTW1VSEVnZ3FUVFZaMFJVUFhC?= =?utf-8?B?ZTRBWm9haXpOVUY1N0Q2NXh2c0QwUnhUUi8yaXBYNXc3cmJtNXY4MzZmdmFp?= =?utf-8?B?L1dFSk53bUZGVzMrSU1ESDFEQVhZUlNIa3BvWWZ4d1Z5eXZ6eVRHMTdXeHBt?= =?utf-8?B?NEIzY3FLK2ZIa3kwYVJSUzhzNjZxdWt0K3BmeE5ROHQxRjVGZ1Y5b1RzRWtH?= =?utf-8?B?cGsyeVFoc3VydHV0SEFMckppMmtWd00rdWk0QnNRRVltZTI0SEJ1Wmw3Yktn?= =?utf-8?B?WlFvVk5NNGtFaXV2UEt0aGtsQnFOcTlleW5UVCtBSFhucGFoVGRiczBkcC9K?= =?utf-8?B?NlFoUDd0emlZR3NHVGkzZFhMRENZRzgwZ1VWUTROWnB2Rko0MGMwOVVLUGxu?= =?utf-8?B?VlA0dTM3NWRtU1A0aGRRemVNcHJoc3pVM1VzVTBtcnkrbTBXZTBlSGgyUUJK?= =?utf-8?B?UU90S21wSGY1SjR3VXZxK1B5MnpKcWxEMEh3Y1ROY1hBN1dDeThMd28wWEFk?= =?utf-8?B?U21TeWkrNzJFT1I5UkRsQVlsTGVuazVjRjJkaWhkQkxmK0x1UzQ0dytkQlRS?= =?utf-8?B?cGNvNU9sS0JncjFVYXdkOGFOcHVabmkyNldpSTZoeFVabStEREhydEV5bFhV?= =?utf-8?B?VkFyK0lUUE9kTDM3Q0kzdWFlVlJrK1N6ckMvTmozQzlxbU5JemFRNUdIbUsx?= =?utf-8?B?MENrMTNkZmMvVTBWQTQ5aVZtMHVZa0IzbkhKQTZkbkcxNlJxUHBtZVdhYUtC?= =?utf-8?B?cmdrUC9GS1lNT0ZCWlFRTDJZMnFsQ1o2eTBaeTRKTUZtMFoxUmJnQ1ArbXN6?= =?utf-8?B?ZGRPbWxrbHRHNDRYalJBNE9PeHNQbFpxTUd0aHhmMDlyc3lwc0xUWGdNS3Z3?= =?utf-8?B?SGxacWlyempWRjE0c1Zkb3hUclBiTEVkTDZmdW1LSk9CYUxSZlNqc1AzQytw?= =?utf-8?B?OGdRRUxwS1FZZXlwQXkrNnI0TEpxRzFBYjE4RXZLN0h3aUtqa0ZGTkJZcnB2?= =?utf-8?B?YmNLVHBwRjcrcmNXTWFYcEJoeGJ4TklhVzd2bkZwQVJicGE3QkFWZWlwYldW?= =?utf-8?B?K0tPMG8xYk9NNXg2SU5tQ0ZZV3FtbDNKTGZGYW16M3NPVnFtdnBOM3lVTHkw?= =?utf-8?B?dVlZRkxQZXdDR1ZlS0ZaTUZhR0M4eEtrT0o5enkvQXh3L0diNlJNUTk5ckxM?= =?utf-8?B?S0NlK3Q2cnhhSEFha0l5eUE5bjI0TEIxeGpENDM5R1RLeTR4RFVYaDY1ZENn?= =?utf-8?B?b2NDeWxhTDRJNncvRWx5Zm9sY1Jabmw5NlBDYWFtTXkyVTFVODAzWXBMdUVU?= =?utf-8?B?T2tobk8zVDZZbGxtUENLK3VlZ0RWcHdDNTkrVjZZdHlVN0owWDlRSi8yMGFq?= =?utf-8?B?MHNyRjhPQkROcW5XcXFBTGFSLzByNyttOHAyRTM0UU9LQlIyU0l3NDlMVmN3?= =?utf-8?Q?d+EJcKVkKp3+?= X-Forefront-PRVS: 0365C0E14B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6029001)(6009001)(6049001)(39410400002)(39850400002)(39860400002)(39400400002)(39840400002)(39450400003)(377454003)(24454002)(83506001)(23676002)(47776003)(53546010)(90366009)(5660300001)(8676002)(81166006)(229853002)(230700001)(66066001)(966005)(42186005)(31686004)(4001350100001)(25786009)(189998001)(33646002)(7350300001)(86362001)(110136004)(4326008)(76176999)(305945005)(54356999)(6246003)(53936002)(2950100002)(65826007)(77096006)(50986999)(38730400002)(6486002)(31696002)(7736002)(36756003)(2906002)(6116002)(6306002)(50466002)(3846002)(478600001)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0158; H:[10.236.136.62]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOnR1bFlYRHpkWGg5N2FCclNQMFdjU0RZd0pJ?= =?utf-8?B?WVB2RVpoUURRU3d2bThXeG5VVWJPNUwzbEhqemRkWE53RHpqN2tXM1hTVVNP?= =?utf-8?B?SkR1NHB1clRmZXR4bXdsbHNqcEJDSVo3MDFmb3Y0OGIrWWliU0YxMCtHQWNT?= =?utf-8?B?WnNBa1NhY2ZqZm1oMUlHeXk4empuK1BsSTE4aVpPUzJxbWRNTjY5VnNEVDYy?= =?utf-8?B?WmcxdFZZa25lMjNHUHZNRXpxby95anFtRWJoNkVMdkp5WHJ5QjBKUVdjdEto?= =?utf-8?B?NEF0akI0VnJDZXhPZG53dmZhdVJHTDJ0ZER2Z0l2b2h1cXRWVHB4V1R3ZTRk?= =?utf-8?B?OFREdjNVUHByWG5SYzZybHBIRFRNTWRrVWtXcXBYY2pSeUNPeVkzSVI3VGtO?= =?utf-8?B?VDRCdDRpTGxnM0QycnZmdSs2UTNmRTFOVlJiM2Y3Q3ZId2JpcE5ZVFNzT0V3?= =?utf-8?B?SURwVGUrdysyV2h6OVE5NGVBTDIxVDZseXRCNU40ZlE3Rk9lOGpBZVU0YnRH?= =?utf-8?B?Uzdaem1uN3lSWGJLaHJlTHZCNmRLczltN0M3SncwYnJwaUhrcVRhMXVyaWwv?= =?utf-8?B?Tkxyckc1S3Bxb1doNC9DaUY3REdMTWVSbnZjNU85bEdvVGYyWjZzcXVrc2RK?= =?utf-8?B?NEFFdWZ2UW5CYmk3ZWZGd2kxbVRJMGczYmh0ZzlOMUpBS3RtZ1BIM3lzRjVq?= =?utf-8?B?bkI5Wm4zMGtyWmxrdlh0RzdEc21YU3dUenIrcTc5dnRFTHIwT01QMmxlTkJ4?= =?utf-8?B?QXlRbG8rOGRyVmlLZFlDOWxXYWtOVS8vMHNyZWlTSU9kZnJTdktjRTVTOXBT?= =?utf-8?B?Yy9Sc1RLQWVyYUhEOG5LcXJoV3VjSFZJWUVPQnRqWDlRMlZWY2RUUFJqbXlw?= =?utf-8?B?aHBzZU5mMWl4WWN0UzZXTVhIdWNQcmVoZ0RMTTBBRXlnOGExR0IvdDZJNFJm?= =?utf-8?B?UWR1VnJJZ1cvK3U2UkViVVM3S1N3VFpBdnVQbzBGRWc4ZUx0UmQzSnV1elUw?= =?utf-8?B?UEM2N3FUbWMzeW92ejNYOTlTM3ZTRklGWVhBZDExS1NubWNhcThTamxjZC8y?= =?utf-8?B?UnVTMjhINFE5MTdOWWoyVDJtV2FKTm9zRG9DL1VNdnZUWlFSUmJXbmhwUHJq?= =?utf-8?B?QXZ4SmxyVk8yNisybGpaS0lmRm9kUDdsY2VLK3hDTDJqZnJsK3dFTnhwelBt?= =?utf-8?B?UU5OVTFEQTl4cmVDSTNHM0oyREZCL2d1cklDOFM5Y2plUVk3TDFwZXNHTUVN?= =?utf-8?B?d0JWcGNVcEMxNDdlaEQxYlN4b3Fhck1SNWFLUEYrbEdITk5yQk1VanhITkZt?= =?utf-8?B?Wjh2VnRXczhFK1FhYk9lejZ0eGlCY1gzcFgzV1YxZzRxcjd1RHNxMml6NUVF?= =?utf-8?B?VlIrd0dRZEhMQWdPNCs1NFJQZGthcHkvUTRzMHEzaWMrOERJWjFya0xLNFp3?= =?utf-8?B?WkZJd2lBSlhtNmdyZDBzcVRtVmVSMDdyRGM2a0hPdDdNNnFkOTBCZ2s1T04y?= =?utf-8?B?M0MxakRvQWxlbTlScWZZVnJKQVBicWlwV3BPK2dSRWVJVllDVUR5ejYvaG1q?= =?utf-8?B?QmMvdUNLek5EMldkRmEvYmRDdThTQnpMMU1oS0JGMGhDMUF2bTVQZjY2aHRL?= =?utf-8?B?QmdQSlFxRTBDUlpOVzNJT2VLbEhsT09ESk5raE9Sd0ZGalVkOXdkMmRrejNX?= =?utf-8?B?cUFBbDNaU0ZMTVVvRHNxQ1ZmNlR2NzdyZkNmSmxtYWFSOXZrK003T2RQWnpz?= =?utf-8?B?N2ExaHI0eUt2MVlDVGZxd3FVVWFzZlVpT0htd00ySVVZNC9EZjl0d2o4Rllw?= =?utf-8?B?MFFFTjZkajkrMzRaOWorUEsxN1FicGd3czZoT0JKdWRJcTBVYWVYc3ZwemtK?= =?utf-8?Q?lCQZVdnmApo=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzY6ZTByZ1RvZk4rTFJtckkvV1QwRVdTRDNjalFP?= =?utf-8?B?ZnpQbmgvazhmUFVRTkxWaVE2Nll6MS9EVmJHNFhZeS9Vc3FjQ2NwVmRmdFRy?= =?utf-8?B?Z3R3TWM0V1FHTlFRa0I4SngwT0N5a0xmZHNDNEVUWTJLU1dZUDQ3TUJYNUpq?= =?utf-8?B?enpuSExrcnFoYTEvU2JjNzh6alcyaTVQZzJ2V2ZaKzdrN2s1NzYvOUh5R3RI?= =?utf-8?B?SWJIaXhoeWlRZzhkTWJMU2FhbjZvdkhTaFlINFY4cXpIdHQwUGJ4dWpnNmM0?= =?utf-8?B?clZYVDJ1OEFRYjhtRU9wSVRxRS8wd1FsNWNDbjBxSUFlczBZWlNlSUdCRm9T?= =?utf-8?B?RmEzcU14M3NKVUJKcUFBZy9LeWpRTkxQVStpSmx6d3VxdXIwVFlnTFVQSVRl?= =?utf-8?B?QkxuRkdTRXBDa0FjSTArSkhmT3hDSWRhd0JJUEdMcXVmWmQ0Ylh2TGMvK2lJ?= =?utf-8?B?dWRFaU92bi96MVd3M0l5ZzZ1UVZGTzVCQkNnSFUwNmtvcWh1QXU3UzJoNy9n?= =?utf-8?B?VzBZYngyamN4VWlOcmlTUURWYzUyYTJWYTJTNS95NkY5WjU1bWVUMU0zY00z?= =?utf-8?B?RDlVSGJpN25QZkNrZGdUa1o2cVZXNkpZWXhCcWVYTW9zS1czQmFZc3dQcmVZ?= =?utf-8?B?TUhYemRYcmRBM2RkZVhZVGlLYXpxL0V1bmViODhXVC9nOFVncWRUZjA5T1ZG?= =?utf-8?B?bFdZejBzenh4ZENKeWtMVk1EUEI1VGVjeGpBY2lLMG9nY0lxSU0wdldIR1kr?= =?utf-8?B?b2VMbTZDc29IYndtV0lISzB0amJ0bkVEQlg3c3hMcVlTczRlbHRpTzZEY2lJ?= =?utf-8?B?ZnFOaFRuVUh5eGhzUUp2aUlqV3Q4RXdqYzNoQlZ6SFpVYXFNTHUrWGR5bjU3?= =?utf-8?B?S0tsQW1VRnh5TC9yYm9ESXRHc0RjU253WjIwQ1M1eEUzZzYzbzdlTG9jaE95?= =?utf-8?B?aHQ3dmVwcGhJbVZVSXFydzNFQi9hMERYaGZ3ODlBZ0FwMG5IeXV6dzNndXpz?= =?utf-8?B?QlQ4U1FLNW5PNXEvT1ZCRFlqTnMyRzM5RTQxU1BDSnE4SDVvbnJFOHVQUGht?= =?utf-8?B?elZFYk1xMVl6OFduN3M4OG92Y3lVenNEVUtJWTN3TTVhdENYUC9mSlFMdndK?= =?utf-8?B?TVl0blJiTTNZYmFocUlueFZXbWlzZ3JmRkRIWjBkamU1TGdpSTZZekFGanpV?= =?utf-8?B?U0tCR1UwWU1tUHpkVERNN281aXVkb0ZTNFRTc0RBTU5LY05vNXgxcGVaSVox?= =?utf-8?B?bGFyeEtrTlFiNWpRSVVJK1pJTVRMbGZuMTNiOHY3eUQvbWtIVUQvVHJ5cUdz?= =?utf-8?B?VFRWYTNmZVFaSCtOalpxaVRqM1ErcnZTS3Nic05QTXRaZnpsQk1rNDN5WXEw?= =?utf-8?Q?0BHSxWY?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 5:GiwpmZt5yub1Ol1THQdK/zTFwz7N9dYszMZIZPlAbJOTn87cP9DzD8zjC9dioy039kScXJKbdnBngbKOvYDd+RnHz+vpAIT/5OjPIWgPJih5ibMMyS2IWa/T8n+kDokSNPZ/7yRws/QELkeYNM71TSRBkEwtFOW1vBUe3c7J0kFRF67jHPVuQ3JhS4GhIIAnBSFmtgqtC/UIPxl6dcbt224KMu3iWgwyvVoIF977iXE0/kfjmlewWWfRPjEud4Ck18Xe5EsJeyqP2P8U5Pi4O1b45DmuqIioNbbUSjSfm/qHLUi7iIWIR4p+buyFum/W2knkOAfjrhCgQad5yoW7X/+6gLVxYC4IIt6Y3JJUWZy+hOru3BArwSfe6ZOeE6LWoCtzmyrX49j93MP6ckDx82KS+gOTXYi/rJhYTaz9psV/m0mDQxjWUvpurLH90OZx17JVkMfxDIl6cft8ZYTMvrBylF52kt9CKyU0rEobhM/DKfLww1H0qZsYFxeCVyHn; 24:Mhb+0IxNx3I2KVWYazMQoE0x6Br+19/vnni9ec90oXrdpZCNPg+FyOR+PNHyj718iLR3YbB2pE6M2Y6LDH5ihWmOoADiBcMC8M3WUbS658c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 7:R2/FhkMPdQGhfTJ9J+OytdfMuVyKIW0EUObd9hey2p36wRtohRdSHD+7JULGwZvR+WiFx9w/egYdX5yEyBcqQWeDqS7I9Oayo/it4xr65ygP01CLtyZHk4ClAI+JDuK7fuOz5KGmSucA8ZCbGCL2oB0gYpLxL6/fk7W80wKPX/uJRsqR7CSiAjvNH0kF1L9N/4/zudrj2PixIjQIJnCX+ScejAgtp33BybmuF2YCmpjoLmlve2dmqLVHSr3YEWuyftsfH08nRhIiz/hoG3+9rSUMSY1W1ZdGfUGsd+JwZxPbSJ3uO+6JGGsiEJoiaxL0NnuqlAGC4BMKkSXchTOvhWzbQlTaCH/duBmSIzP/x5oiZc99Rilqo7yIGyAMwvmedhK/XQNtwhqRPZoZaTFSbm4aOdklYA1iTNDUPavL/QzWnAeM6n5ZzRJ7kdNvH/08S3qa7YPBdAURqaGW5GbKoqIddfMxXQWmtzYrd+28y/1Nq06YZvaNW4F5qjvfQh647LIN2FrtU7pVDnacZKA8sq1Run66Lc9XTvMJjAJtcg00+B/+6E8b33wNMV+4BUZfRHGV8LvHC7LiecO2NESA8/uh8t8GGGWiSyCaAwNKiB0Jc8rHcohP4oJXdEO0wwJbs108gPYLADiZ962CmOzU7XM/hEZo7kkYpf03FqJcq2XhfdJBHIDKvBwJHxgHovZ9tkj6GdZ1/fcghevSnzvqe/uKKZwXNUaiPZ6mLLjg7Wo43wPB7FBB4FRZxnLZejSeNGTQPSUpnPSfqKr5/yqSxm507Mz/L9ND/xU9B/TI1V4= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 20:Wc9qBcSJJIaLZnYnPyHFNVRkoDuNlomEU14yFaXKvOy4crho5lcvXdkYInILV08RkMXMPOVDJ0tAJS3ZjPOFTWXD8+xGpP9eIB7uwpw9mKhlIcKvTLOVOyL5ePBz0uRTMzI7xTLrUuu4g5UF+K21T5huYhYo4p6sHS6HeH3hzDokaWpCKg3jfNNdajlzZ1fNvblGU/eUqf6VFA528W3455nDTGQaRtoGzdQiKNoh5cW7/a68TQs+N9JRR3DeRZqY X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2017 18:13:53.6134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Subject: Re: [PATCH 1/1] OvmfPkg/QemuFwCfgLib: Suppress GCC49 IA32 build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 18:12:09 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/11/2017 12:34 PM, Laszlo Ersek wrote: > Hi Brijesh, > > On 07/11/17 19:08, Brijesh Singh wrote: >> NumPages variable was introduced in commit 66c548be509d. In this commit >> we allocate an intermediate buffer when SEV is enabled. The 'BounceBuffer' >> variable points to the intermediate buffer pointer and NumPages variables >> stores the number of pages. Later in the code, 'BounceBuffer' variable is >> checked to see if we need to free the intermediate buffers. The code looks >> correct, suppress the warning. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Reported-by: Laszlo Ersek >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Brijesh Singh >> --- >> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c >> index dbebd36b1853..1b21ef094dc5 100644 >> --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c >> +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c >> @@ -72,7 +72,7 @@ InternalQemuFwCfgDmaBytes ( >> volatile FW_CFG_DMA_ACCESS *Access; >> UINT32 AccessHigh, AccessLow; >> UINT32 Status; >> - UINT32 NumPages; >> + UINT32 NumPages = 0; >> VOID *DmaBuffer, *BounceBuffer; >> >> ASSERT (Control == FW_CFG_DMA_CTL_WRITE || Control == FW_CFG_DMA_CTL_READ || >> > > In edk2 we don't initialize local variables in the ISO C sense of > "initialization" -- please use a separate assignment, plus add a code > comment like mentioned here: > > https://bugzilla.tianocore.org/show_bug.cgi?id=607 > Thanks for quick review Laszlo, I will update the patch with those comments. -Brijesh