Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

[Rebecca Cran]

Sorry, I've fixed the subject line and added maintainers to the Cc list.

This patch also changes the domain from intel.com to example.com, to be 
more applicable to consumers outside Intel.


--

Rebecca Cran


On 2/22/19 8:38 PM, Rebecca Cran wrote:
> The current servers listed appear to be unusable. I suspect most
> people will get correct DNS servers via DHCP, but the defaults
> should work for anyone.
> ---
>   StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
> index 3ac16ac230..724e6297b2 100644
> --- a/StdLib/Efi/StdLib/etc/resolv.conf
> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> @@ -1,13 +1,13 @@
>   #
>   #   Domain name
>   #
> -domain          intel.com
> +domain          example.com
>   
>   ;
>   ;   Name Servers
>   ;
> -nameserver      206.63.63.61
> -nameserver      216.251.100.1
> +nameserver      8.8.8.8
> +nameserver      8.8.4.4
>   
>   ; nameserver      10.248.2.1
>   ; nameserver      10.22.224.204

Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

[Laszlo Ersek]

On 02/23/19 04:41, Rebecca Cran via edk2-devel wrote:
> Sorry, I've fixed the subject line and added maintainers to the Cc list.
> 
> This patch also changes the domain from intel.com to example.com, to be
> more applicable to consumers outside Intel.
> 
> 
> -- 
> 
> Rebecca Cran
> 
> 
> On 2/22/19 8:38 PM, Rebecca Cran wrote:
>> The current servers listed appear to be unusable. I suspect most
>> people will get correct DNS servers via DHCP, but the defaults
>> should work for anyone.
>> ---
>>   StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf
>> b/StdLib/Efi/StdLib/etc/resolv.conf
>> index 3ac16ac230..724e6297b2 100644
>> --- a/StdLib/Efi/StdLib/etc/resolv.conf
>> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
>> @@ -1,13 +1,13 @@
>>   #
>>   #   Domain name
>>   #
>> -domain          intel.com
>> +domain          example.com
>>     ;
>>   ;   Name Servers
>>   ;
>> -nameserver      206.63.63.61
>> -nameserver      216.251.100.1
>> +nameserver      8.8.8.8
>> +nameserver      8.8.4.4
>>     ; nameserver      10.248.2.1
>>   ; nameserver      10.22.224.204
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Can you please repost the patch with an updated subject line / commit
message? That way we can apply it with git-am without tweaking on the
maintainer side.

In v2, you can include:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

(If reposting is too much burden, I can do the changes manually once the
ShellPkg maintainers okay the patch; it's just that the less a
maintainer has to update a patch, the safer / more robust the process is.)

Thanks
Laszlo

Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

[Rebecca Cran]

On February 25, 2019 at 3:11:16 AM, Laszlo Ersek (lersek@redhat.com(mailto:lersek@redhat.com)) wrote: 

> 
> Can you please repost the patch with an updated subject line / commit
> message? That way we can apply it with git-am without tweaking on the
> maintainer side. 





Sure!






Rebecca

Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers.

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, February 25, 2019 2:11 AM
> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Daryl McDaniel <edk2-
> lists@mc2research.org>
> Subject: Re: [edk2] [PATCH] StdLib: Update resolv.conf to use Google's DNS
> servers.
> Importance: High
> 
> On 02/23/19 04:41, Rebecca Cran via edk2-devel wrote:
> > Sorry, I've fixed the subject line and added maintainers to the Cc list.
> >
> > This patch also changes the domain from intel.com to example.com, to be
> > more applicable to consumers outside Intel.
> >
> >
> > --
> >
> > Rebecca Cran
> >
> >
> > On 2/22/19 8:38 PM, Rebecca Cran wrote:
> >> The current servers listed appear to be unusable. I suspect most
> >> people will get correct DNS servers via DHCP, but the defaults
> >> should work for anyone.
> >> ---
> >>   StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
> >>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf
> >> b/StdLib/Efi/StdLib/etc/resolv.conf
> >> index 3ac16ac230..724e6297b2 100644
> >> --- a/StdLib/Efi/StdLib/etc/resolv.conf
> >> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> >> @@ -1,13 +1,13 @@
> >>   #
> >>   #   Domain name
> >>   #
> >> -domain          intel.com
> >> +domain          example.com
> >>     ;
> >>   ;   Name Servers
> >>   ;
> >> -nameserver      206.63.63.61
> >> -nameserver      216.251.100.1
> >> +nameserver      8.8.8.8
> >> +nameserver      8.8.4.4
> >>     ; nameserver      10.248.2.1
> >>   ; nameserver      10.22.224.204
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> 
> Can you please repost the patch with an updated subject line / commit
> message? That way we can apply it with git-am without tweaking on the
> maintainer side.
> 
> In v2, you can include:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> (If reposting is too much burden, I can do the changes manually once the
> ShellPkg maintainers okay the patch; it's just that the less a
> maintainer has to update a patch, the safer / more robust the process is.)
> 
> Thanks
> Laszlo

[PATCH] StdLib: Update resolv.conf to use Google's DNS servers

[Rebecca Cran]

The current servers listed appear to be unusable. I suspect most
people will get correct DNS servers via DHCP, but the defaults
should work for anyone.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
 StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
index 3ac16ac230..724e6297b2 100644
--- a/StdLib/Efi/StdLib/etc/resolv.conf
+++ b/StdLib/Efi/StdLib/etc/resolv.conf
@@ -1,13 +1,13 @@
 #
 #   Domain name
 #
-domain          intel.com
+domain          example.com
 
 ;
 ;   Name Servers
 ;
-nameserver      206.63.63.61
-nameserver      216.251.100.1
+nameserver      8.8.8.8
+nameserver      8.8.4.4
 
 ; nameserver      10.248.2.1
 ; nameserver      10.22.224.204
-- 
2.21.0

Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers

[Laszlo Ersek]

On 03/08/19 03:14, Rebecca Cran via edk2-devel wrote:
> The current servers listed appear to be unusable. I suspect most
> people will get correct DNS servers via DHCP, but the defaults
> should work for anyone.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
> index 3ac16ac230..724e6297b2 100644
> --- a/StdLib/Efi/StdLib/etc/resolv.conf
> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> @@ -1,13 +1,13 @@
>  #
>  #   Domain name
>  #
> -domain          intel.com
> +domain          example.com
>  
>  ;
>  ;   Name Servers
>  ;
> -nameserver      206.63.63.61
> -nameserver      216.251.100.1
> +nameserver      8.8.8.8
> +nameserver      8.8.4.4
>  
>  ; nameserver      10.248.2.1
>  ; nameserver      10.22.224.204
> 

Thanks! Looks good. We should push this soon, after the
edk2-stable201903 tag is made. Jaben, please let me know if you need me
to push this.

Thanks
Laszlo

Re: [PATCH] StdLib: Update resolv.conf to use Google's DNS servers

[Laszlo Ersek]

On 03/08/19 03:14, Rebecca Cran via edk2-devel wrote:
> The current servers listed appear to be unusable. I suspect most
> people will get correct DNS servers via DHCP, but the defaults
> should work for anyone.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
> index 3ac16ac230..724e6297b2 100644
> --- a/StdLib/Efi/StdLib/etc/resolv.conf
> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> @@ -1,13 +1,13 @@
>  #
>  #   Domain name
>  #
> -domain          intel.com
> +domain          example.com
>  
>  ;
>  ;   Name Servers
>  ;
> -nameserver      206.63.63.61
> -nameserver      216.251.100.1
> +nameserver      8.8.8.8
> +nameserver      8.8.4.4
>  
>  ; nameserver      10.248.2.1
>  ; nameserver      10.22.224.204
> 

Pushed as commit a24a37dba42c.

Thanks!
Laszlo