public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>,
	"Gao, Junhao" <junhao.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] question about qemu+kvm+ovmf+winxp
Date: Mon, 14 Oct 2019 14:59:42 +0200	[thread overview]
Message-ID: <f43d2e5a-6b38-de61-81b1-afca088fe070@redhat.com> (raw)
In-Reply-To: <26980775fc87acc8c4d180626d853607e9f20b0e.camel@infradead.org>

On 10/11/19 16:35, David Woodhouse wrote:
> On Fri, 2019-10-11 at 16:27 +0200, Laszlo Ersek wrote:
>> On 10/11/19 09:44, Gao, Junhao wrote:
>>> Hi David 
>>>
>>>        I have found this compiled OVMF-with-csm.fd can support winxp booting up.
>>>        OVMF-with-csm.fd path: https://www.kraxel.org/repos/jenkins/seabios/seabios.git-csm-1.12.0-33.63.g43f5df7.x86_64.rpm
>>>        Then could you help to provide me the compile method and base code to reproduce this OVMF-with-csm.fd?
>>
>> Ah, good point, I should have remembered that Gerd offers a CSM build in
>> his repo!
>>
>> So, you can easily look up the build instructions, in Gerd's SeaBIOS and
>> OVMF RPM "spec" files. Check out these git repositories:
>>
>>   https://git.kraxel.org/cgit/jenkins/seabios/
>>   https://git.kraxel.org/cgit/jenkins/edk2/
>>
>> Specifically:
>>
>>   https://git.kraxel.org/cgit/jenkins/seabios/tree/seabios.git.spec
>>   https://git.kraxel.org/cgit/jenkins/edk2/tree/edk2.git.spec.template
> 
> Right, thanks.
> 
> Ultimately it's as simple as:
> 
>  • Build SeaBIOS with CONFIG_CSM
>  • Drop the resulting Csm16.bin into OvmfPkg/Csm/Csm16/ in the EDK2 tree
>  • Build EDK2 with -DCSM_ENABLE
> 
> Someone else mailed me recently to say they'd copied the Csm packages
> over from OvmfPkg to Quark and had Windows booting on Galileo boards.  
> 
> Hm, I wonder if we should move the CSM support out of OVMF and into
> somewhere more generic, since it really is generic and not platform-
> specific?

We moved the CSM infrastructure under OvmfPkg because IntelFrameworkPkg
/ IntelFrameworkModulePkg were slated for removal, and this was how we
could salvage the CSM:

https://bugzilla.tianocore.org/show_bug.cgi?id=1811

We could likely move it out of OVMF, but if the destination is still the
edk2 tree -- which I would strongly prefer, as long as we support the
CSM at all --, then it will take a new top level directory (CsmPkg, for
example).

No other package maintainer was willing to maintain the CSM, and even
under OvmfPkg, I agreed to it only if you'd assume its reviewership. So
now you'd likely have to introduce CsmPkg, and become its sole (or
primary) maintainer.

I'm 100% OK with that. (Both as OvmfPkg co-maintainer, and as one of the
stewards that might have to ACK (I think?...) the creation of another
top-level directory).

Thanks
Laszlo

      parent reply	other threads:[~2019-10-14 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 14:37 question about qemu+kvm+ovmf+winxp Junhao Gao
2019-10-10 18:10 ` [edk2-devel] " Laszlo Ersek
2019-10-11  1:32   ` Junhao Gao
     [not found]   ` <15CC73B09CF3FDD9.17220@groups.io>
2019-10-11  7:44     ` Junhao Gao
2019-10-11 14:27       ` Laszlo Ersek
2019-10-11 14:35         ` David Woodhouse
2019-10-12  6:13           ` Junhao Gao
2019-10-12  6:27             ` Andrew Fish
2019-10-14 12:59           ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43d2e5a-6b38-de61-81b1-afca088fe070@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox