From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: <devel@edk2.groups.io>, <jeremy.linton@arm.com>, <abner.chang@amd.com>
Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed
Date: Tue, 12 Mar 2024 09:56:30 -0700 [thread overview]
Message-ID: <f446f9ef-84da-4d87-bdaf-928f489fbff1@quicinc.com> (raw)
In-Reply-To: <CAMj1kXHOY6C1NahbT1u0hES7Hp3QBWZ8ML7x1rH7aiE8170LZQ@mail.gmail.com>
On 2024-03-12 09:50, Ard Biesheuvel wrote:
> On Tue, 12 Mar 2024 at 17:38, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>>
>> On 2024-03-12 08:17, Ard Biesheuvel wrote:
>>> From: Ard Biesheuvel <ardb@kernel.org>
>>>
>>> NonCoherentIoMmuSetAttribute() does nothing except return
>>> EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI
>>> bus driver will fail a PCI I/O Map() operation if the SetAttributes
>>> fails.
>>>
>>> So return EFI_SUCCESS instead.
>>
>> It's unclear to me why this change is safe (looking forward).
>> Does NonCoherentIoMmuDxe also imply no IoMmu actually exists?
>>
>
> Basically. NonCoherentIoMmuDxe is just a vehicle to allow
> NonCoherentDmaLib to be plugged into the PCI host bridge driver. It is
> not intended to ever do anything more than that.
Not that it needs to happen for this
(Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>)
but maybe we ought to consider renaming it then?
DummyIoMmuDxe?
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116695): https://edk2.groups.io/g/devel/message/116695
Mute This Topic: https://groups.io/mt/104886877/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-12 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 15:17 [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed Ard Biesheuvel via groups.io
2024-03-12 16:38 ` Leif Lindholm
2024-03-12 16:50 ` Ard Biesheuvel
2024-03-12 16:56 ` Leif Lindholm [this message]
2024-03-12 16:58 ` Ard Biesheuvel
2024-03-12 17:14 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f446f9ef-84da-4d87-bdaf-928f489fbff1@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox