From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F0912AC1EC5 for ; Tue, 12 Mar 2024 16:56:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=T9aOrVkSZ7fNFSLahjXgkLY/mWeZTYAsBXUKggXE2PQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710262596; v=1; b=0pCcXOTXNGJFIdgSNzYAcsm0N+8DwwrjYqBK45hyIxggLyCyJBxHAB8rGovU+JKloqwSxqo7 /pSb2+YdxQnCrFzMPu8wqJm98ftjl2V//D/uGTZtoWEK7H4n335/Dsgpg/q4Wmz+RzgGvCcl27i GhvJBw+Kw09Jny2fnUtN+C6V5puZq27u1PGfpOEHtJXk33Y3JfiDIi3b3w9h5cLFzX3v7uoyRa1 GzcYDGs3D9ifkx+uNoCc2uDwi4It4C1ffeSqR68Ao6FG/P61KyVlMLNs/pU7VJiUyU0YCJCbmfC AoxHDSUmf/GxhVncKtqmqCU0/zV/IxvtVDipQZ20sOjkw== X-Received: by 127.0.0.2 with SMTP id 8qeNYY7687511xCkxmDvlIlh; Tue, 12 Mar 2024 09:56:36 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.1656.1710262595964141830 for ; Tue, 12 Mar 2024 09:56:36 -0700 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42CC6T5u016623; Tue, 12 Mar 2024 16:56:32 GMT X-Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wtprj8pws-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 16:56:32 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42CGuVSV009501 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2024 16:56:31 GMT X-Received: from [10.110.22.181] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 12 Mar 2024 09:56:30 -0700 Message-ID: Date: Tue, 12 Mar 2024 09:56:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed To: Ard Biesheuvel CC: , , References: <20240312151716.2154180-1-ardb+git@google.com> <74a4fb99-5d29-44ac-93bd-caea7367d08e@quicinc.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: H4XOfvDf3XfwuqHAOenz2Us7vYxuvR70 X-Proofpoint-ORIG-GUID: H4XOfvDf3XfwuqHAOenz2Us7vYxuvR70 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 09:56:36 -0700 Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Eh0v89wW6oQzBrhLLFV7ZYkPx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0pCcXOTX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-03-12 09:50, Ard Biesheuvel wrote: > On Tue, 12 Mar 2024 at 17:38, Leif Lindholm w= rote: >> >> On 2024-03-12 08:17, Ard Biesheuvel wrote: >>> From: Ard Biesheuvel >>> >>> NonCoherentIoMmuSetAttribute() does nothing except return >>> EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI >>> bus driver will fail a PCI I/O Map() operation if the SetAttributes >>> fails. >>> >>> So return EFI_SUCCESS instead. >> >> It's unclear to me why this change is safe (looking forward). >> Does NonCoherentIoMmuDxe also imply no IoMmu actually exists? >> >=20 > Basically. NonCoherentIoMmuDxe is just a vehicle to allow > NonCoherentDmaLib to be plugged into the PCI host bridge driver. It is > not intended to ever do anything more than that. Not that it needs to happen for this (Reviewed-by: Leif Lindholm ) but maybe we ought to consider renaming it then? DummyIoMmuDxe? / Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116695): https://edk2.groups.io/g/devel/message/116695 Mute This Topic: https://groups.io/mt/104886877/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-