From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 97C8BAC04C4 for ; Tue, 24 Oct 2023 05:54:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ymw2QJm75mEp9QCY9VOtg8YDLwd3tLuTSwSnA9vCmVU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698126845; v=1; b=dAvQx/dYJltR9mVx/rEB0sDjzR+qaW2pMHX5+XArUAePXmJa61pGAt5UYtccJ3rO+8ldxXB9 Jrc3Sj3F2OdZ0oqlLXbVAhcUCtx90wZxsR46YY9z4k2eMcAL8I9CCQyXawmBYFjpTI8fRWt9Qmi DuNcbvD48qVZf6oDLdVuUU50= X-Received: by 127.0.0.2 with SMTP id 1lbfYY7687511xKjM6dO16xf; Mon, 23 Oct 2023 22:54:05 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.11853.1698126840726459328 for ; Mon, 23 Oct 2023 22:54:04 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="367220282" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="367220282" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 22:54:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="931925283" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="931925283" X-Received: from shpfwdbuild003.ccr.corp.intel.com ([10.239.56.82]) by orsmga005.jf.intel.com with ESMTP; 23 Oct 2023 22:54:02 -0700 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Wei6 Xu , Ard Biesheuvel , Sami Mujawar , Ray Ni Subject: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV. Date: Tue, 24 Oct 2023 13:53:54 +0800 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DYzBPUHVF6znFiZhGtlIPuIax7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="dAvQx/dY"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. When an inner FV is uncompressed, StandaloneMmCore will miss the FV and all the MM drivers in the FV will not be dispatched. Add checks for uncompressed inner FV to fix this issue. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Signed-off-by: Wei6 Xu --- StandaloneMmPkg/Core/FwVol.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c index 1f6d7714ba97..1a85d80eb9f7 100644 --- a/StandaloneMmPkg/Core/FwVol.c +++ b/StandaloneMmPkg/Core/FwVol.c @@ -104,6 +104,17 @@ MmCoreFfsFindMmDriver ( break;=0D }=0D =0D + Status =3D FfsFindSectionData (=0D + EFI_SECTION_FIRMWARE_VOLUME_IMAGE,=0D + FileHeader,=0D + &SectionData,=0D + &SectionDataSize=0D + );=0D + if (!EFI_ERROR (Status)) {=0D + InnerFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)SectionData;=0D + MmCoreFfsFindMmDriver (InnerFvHeader);=0D + }=0D +=0D Status =3D FfsFindSectionData (=0D EFI_SECTION_GUID_DEFINED,=0D FileHeader,=0D --=20 2.29.2.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109986): https://edk2.groups.io/g/devel/message/109986 Mute This Topic: https://groups.io/mt/102152694/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-