From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web10.26445.1678471051807368801 for ; Fri, 10 Mar 2023 09:57:32 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=TLUAMgPG; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1A81C5C0158; Fri, 10 Mar 2023 12:57:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 10 Mar 2023 12:57:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678471051; x=1678557451; bh=b0qgFqRsA2f38jFqNrWINKom7BIAM70Q3ub yx+DtSCM=; b=TLUAMgPGvGQwCM/ZHKkp8jZmEp9bjaxz0TFtF3+MU8sLHOzDcI3 Qpa4NtgT0Xfn+xuT+ry3avr7Iw2gIyfESw9gl48wE39pJYCWa+unkqwmv14xbCvG sxpr6rJXbIaZc2e/IrtD2aCXeMtjmukT7EzdCUgZ3eZq/JEJR7IqR1x2HtMZ5qZj da3pIFLC1Z+/gZ3npowjw+4/Pbw1GTW7dHtgY5FjE21bmrbnLZsbkfx6kVbYlNjE gghXvS7mAiS3A97cEQO1anzvmgym40QR5pX01k9M4MigCQmQkBgY34qqCzNMubqH kKoqKzS+TcqrOGW6ai/ceRwNlac154WXKPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1678471051; x= 1678557451; bh=b0qgFqRsA2f38jFqNrWINKom7BIAM70Q3ubyx+DtSCM=; b=N PxW2pkaeiYE0H3bdvkejVR6tz7eNgOpVV2PirUYeRogphkc2Ye1Ms5KF74TMechX kigJQyTdr95E/ylpNuNgOwZt1+qkqzv2gA4L5xdKoSlkUbvOCWoofclRQj5VKrxq Buth5wklttC5zSWMtP4xgyGbZZw6jCrUpkPObK23IPCr6HYQnrGddFZubOg9F0De aWU2XBNmhsQObCIZTi5rp1ecHs1oW2sS2+90ly1zeGTrnJLqJDNuE+bzmShm5F4Y KymmYGZA/9KESYnRPKm+1MbHXEjcMXORJ6k8ZXsJLQ1P1ZDbi8uMPh/n976a+0dN IJFKe3yTrB7NVrtz7cp7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddukedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeuheffgeefleeuudefffefjeeiueeggedvfefghfeuteehueehgeeifedt udefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Mar 2023 12:57:30 -0500 (EST) Message-ID: Date: Fri, 10 Mar 2023 10:57:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW1BBVENIIDAvM10gQmFzZVRvb2xzOiBGaXggZG9jIGJsb2NrIGxvY2F0aW9uIGFuZCBmb3JtYXR0aW5nOyBydW4gdW5jcnVzdGlmeQ==?= To: gaoliming , devel@edk2.groups.io, 'Bob Feng' , 'Yuwei Chen' References: <20230225005431.12173-1-rebecca@bsdio.com> <009c01d952fc$03d139e0$0b73ada0$@byosoft.com.cn> From: "Rebecca Cran" In-Reply-To: <009c01d952fc$03d139e0$0b73ada0$@byosoft.com.cn> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I'm not aware of a tool: I converted the comments manually. -- Rebecca Cran On 3/9/23 7:57 PM, gaoliming wrote: > Rebecca: > I think these changes are good. Reviewed-by: Liming Gao > > > Besides, which tool is used to convert function comments to Doxygen > format? > > Thanks > Liming >> -----邮件原件----- >> 发件人: Rebecca Cran >> 发送时间: 2023年2月25日 8:54 >> 收件人: devel@edk2.groups.io; Bob Feng ; Liming >> Gao ; Yuwei Chen >> 抄送: Rebecca Cran >> 主题: [PATCH 0/3] BaseTools: Fix doc block location and formatting; run >> uncrustify >> >> Fix the formatting and location of documentation blocks in > Source/C/Common, >> and replace the duplicate prototype of __PcdSet with __PcdGet. Those >> patches >> will fail CI because it appears Uncrustify was never run on BaseTools? >> >> Patch 3/3 reformats the files in Source/C/Common according to >> Uncrustify. >> >> Rebecca Cran (3): >> BaseTools: Source/C/Common: Fix doc block locations and convert to >> Doxygen >> BaseTools: Replace duplicate __PcdSet prototype with __PcdGet >> BaseTools: Run Uncrustify over files in Source/C/Common >> >> BaseTools/Source/C/Common/BinderFuncs.h | 27 +- >> BaseTools/Source/C/Common/CommonLib.h | 267 ++-- >> BaseTools/Source/C/Common/Compress.h | 45 +- >> BaseTools/Source/C/Common/Crc32.h | 36 +- >> BaseTools/Source/C/Common/Decompress.h | 122 +- >> BaseTools/Source/C/Common/EfiUtilityMsgs.h | 38 +- >> BaseTools/Source/C/Common/FirmwareVolumeBufferLib.h | 101 +- >> BaseTools/Source/C/Common/FvLib.h | 51 +- >> BaseTools/Source/C/Common/MemoryFile.h | 76 +- >> BaseTools/Source/C/Common/MyAlloc.h | 196 +-- >> BaseTools/Source/C/Common/OsPath.h | 92 +- >> BaseTools/Source/C/Common/ParseGuidedSectionTools.h | 101 +- >> BaseTools/Source/C/Common/ParseInf.h | 228 ++-- >> BaseTools/Source/C/Common/PcdValueCommon.h | 196 +-- >> BaseTools/Source/C/Common/PeCoffLib.h | 66 +- >> BaseTools/Source/C/Common/SimpleFileParsing.h | 24 +- >> BaseTools/Source/C/Common/StringFuncs.h | 203 +-- >> BaseTools/Source/C/Common/WinNtInclude.h | 28 +- >> BaseTools/Source/C/Common/BasePeCoff.c | 1068 >> +++++++-------- >> BaseTools/Source/C/Common/BinderFuncs.c | 31 +- >> BaseTools/Source/C/Common/CommonLib.c | 914 >> ++++++------- >> BaseTools/Source/C/Common/Crc32.c | 38 +- >> BaseTools/Source/C/Common/Decompress.c | 795 >> +++++------ >> BaseTools/Source/C/Common/EfiCompress.c | 1189 >> ++++++++-------- >> BaseTools/Source/C/Common/EfiUtilityMsgs.c | 663 ++++----- >> BaseTools/Source/C/Common/FirmwareVolumeBuffer.c | 1426 >> ++++++++------------ >> BaseTools/Source/C/Common/FvLib.c | 638 >> ++++----- >> BaseTools/Source/C/Common/MemoryFile.c | 131 +- >> BaseTools/Source/C/Common/MyAlloc.c | 265 ++-- >> BaseTools/Source/C/Common/OsPath.c | 180 +-- >> BaseTools/Source/C/Common/ParseGuidedSectionTools.c | 142 +- >> BaseTools/Source/C/Common/ParseInf.c | 401 +++--- >> BaseTools/Source/C/Common/PcdValueCommon.c | 618 >> ++++----- >> BaseTools/Source/C/Common/PeCoffLoaderEx.c | 277 ++-- >> BaseTools/Source/C/Common/SimpleFileParsing.c | 737 >> +++++----- >> BaseTools/Source/C/Common/StringFuncs.c | 310 ++--- >> BaseTools/Source/C/Common/TianoCompress.c | 1075 >> ++++++--------- >> 37 files changed, 5544 insertions(+), 7251 deletions(-) >> >> -- >> 2.37.1 (Apple Git-137.1) > >