From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Jul 2019 01:34:12 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6737B85546; Thu, 4 Jul 2019 08:34:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-165.ams2.redhat.com [10.36.117.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3557C795B7; Thu, 4 Jul 2019 08:33:55 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Only import DxeTpmMeasurementLib when TPM is enabled To: Gary Lin , "devel@edk2.groups.io" Cc: Jordan Justen , Stefan Berger , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <20190703102228.25441-1-glin@suse.com> <5f74464e-1a3a-455a-ba46-0f00e20f4ce7@redhat.com> <20190704035808.GC32340@GaryWorkstation> From: "Laszlo Ersek" Message-ID: Date: Thu, 4 Jul 2019 10:33:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190704035808.GC32340@GaryWorkstation> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 04 Jul 2019 08:34:01 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07/04/19 05:58, Gary Lin wrote: > On Wed, Jul 03, 2019 at 09:49:26PM +0200, Laszlo Ersek wrote: >> Hi Gary, >> >> On 07/03/19 12:22, Gary Lin wrote: >>> DxeTpmMeasurementLib is only useful when TPM is enabled. >>> >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Marc-Andr=C3=A9 Lureau >>> Cc: Stefan Berger >>> Signed-off-by: Gary Lin >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc | 10 +++++++--- >>> OvmfPkg/OvmfPkgIa32X64.dsc | 10 +++++++--- >>> OvmfPkg/OvmfPkgX64.dsc | 10 +++++++--- >>> 3 files changed, 21 insertions(+), 9 deletions(-) >> >> This is a good patch, thank you for it. I see two opportunities for >> improvement. >> >> (1) There's something weird going on with your newline characters. The >> view I get (in both my INBOX and in my list folder) is identical to >> mail-archive.com's view: >> >> http://mid.mail-archive.com/20190703102228.25441-1-glin@suse.com >> >> Can you double check your settings, please? >> > I didn't change my git settings except the mail server due to our > recent server migration. Not sure if it's caused by the new mail server > or not... Not sure... your v2 on the list doesn't seem to suffer from this issue, thankfully :) >=20 >> >> (2) The commit message should be more convincing. How about this: >> > Will follow your suggestion to update the patch. >=20 > BTW, just found that there is a TPM2_ENABLE block below the > SECURE_BOOT_ENABLE block. I'll move TpmMeasurementLib there to reduce > the lines of change. Good idea! Thanks Laszlo