Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Himanshu,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 04/01/2024 08:02 am, Himanshu Sharma wrote:
> Taking reference from Table 2-1 of the Arm Generic Interrupt Controller
> Architecture Specification, Issue H, January 2022, add macros for the
> SPI and extended SPI ranges with the purpose of reusability on including
> the ArmPkg.
>
> Signed-off-by: Himanshu Sharma <Himanshu.Sharma@arm.com>
> ---
>   ArmPkg/Include/Library/ArmGicArchLib.h | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h
> index 72ac17e13b5a..ed6fe6fecb09 100644
> --- a/ArmPkg/Include/Library/ArmGicArchLib.h
> +++ b/ArmPkg/Include/Library/ArmGicArchLib.h
> @@ -1,9 +1,15 @@
>   /** @file
>
>   *
>
>   *  Copyright (c) 2015, Linaro Ltd. All rights reserved.
>
> +*  Copyright (c) 2024, Arm Limited. All rights reserved.
>
>   *
>
>   *  SPDX-License-Identifier: BSD-2-Clause-Patent
>
>   *
>
> +*  @par Reference(s):
>
> +*  - Arm Generic Interrupt Controller Architecture Specification,
>
> +*    Issue H, January 2022.
>
> +*    (https://developer.arm.com/documentation/ihi0069/)
>
> +*
>
>   **/
>
>   
>
>   #ifndef ARM_GIC_ARCH_LIB_H_
>
> @@ -23,4 +29,12 @@ ArmGicGetSupportedArchRevision (
>     VOID
>
>     );
>
>   
>
> +//
>
> +// GIC SPI and extended SPI ranges
>
> +//
>
> +#define ARM_GIC_ARCH_SPI_MIN      32
>
> +#define ARM_GIC_ARCH_SPI_MAX      1019
>
> +#define ARM_GIC_ARCH_EXT_SPI_MIN  4096
>
> +#define ARM_GIC_ARCH_EXT_SPI_MAX  5119
>
> +
>
>   #endif // ARM_GIC_ARCH_LIB_H_
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113185): https://edk2.groups.io/g/devel/message/113185
Mute This Topic: https://groups.io/mt/103518972/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-