public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ashish Singhal <ashishsingha@nvidia.com>
To: <edk2-devel@lists.01.org>
Cc: Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH 4/4] NetworkPkg/IScsiDxe: Update UEFILib Usage
Date: Fri, 4 Jan 2019 15:16:00 -0700	[thread overview]
Message-ID: <f49c3bd272c58277aa10ece5b80a083bc17aebda.1546633673.git.ashishsingha@nvidia.com> (raw)
In-Reply-To: <cover.1546633673.git.ashishsingha@nvidia.com>

Update interfaces as exposed by UEFILib for protocol
installation and uninstallation abstraction.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
 NetworkPkg/IScsiDxe/IScsiDriver.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/NetworkPkg/IScsiDxe/IScsiDriver.c b/NetworkPkg/IScsiDxe/IScsiDriver.c
index 8747de7..fa0ea00 100644
--- a/NetworkPkg/IScsiDxe/IScsiDriver.c
+++ b/NetworkPkg/IScsiDxe/IScsiDriver.c
@@ -1863,14 +1863,20 @@ Error3:
 
 Error2:
   EfiLibUninstallDriverBindingComponentName2 (
+    ImageHandle,
+    SystemTable,
     &gIScsiIp6DriverBinding,
+    NULL,
     &gIScsiComponentName,
     &gIScsiComponentName2
     );
 
 Error1:
   EfiLibUninstallDriverBindingComponentName2 (
+    ImageHandle,
+    SystemTable,
     &gIScsiIp4DriverBinding,
+    NULL,
     &gIScsiComponentName,
     &gIScsiComponentName2
     );
-- 
2.7.4



      parent reply	other threads:[~2019-01-04 22:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 22:15 [PATCH 0/4] Provide UEFILib functions for protocol uninstallation Ashish Singhal
2019-01-04 22:15 ` [PATCH 1/4] MdePkg/UefiLib: Abstract driver model " Ashish Singhal
2019-01-04 22:15 ` [PATCH 2/4] NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols Ashish Singhal
2019-01-04 22:15 ` [PATCH 3/4] MdePkg/UefiLib: Simplify protocol un/installation abstraction Ashish Singhal
2019-01-04 22:16 ` Ashish Singhal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f49c3bd272c58277aa10ece5b80a083bc17aebda.1546633673.git.ashishsingha@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox