From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@dell.com header.s=smtpout1 header.b=Mozjgs43; spf=pass (domain: dell.com, ip: 148.163.133.20, mailfrom: jayanth.raghuram@dell.com) Received: from mx0a-00154904.pphosted.com (mx0a-00154904.pphosted.com [148.163.133.20]) by groups.io with SMTP; Wed, 28 Aug 2019 18:19:56 -0700 Received: from pps.filterd (m0170393.ppops.net [127.0.0.1]) by mx0a-00154904.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7T1Jn3u006230 for ; Wed, 28 Aug 2019 21:19:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=smtpout1; bh=a4eWWzJiexJ/+8L3cXOyz4QMCefB/5co2u8KMGQeHLo=; b=Mozjgs43W5QhrCGA++sQuuPi57QWb0cZoUiyll7m/ppdpVVEA0TOahxbKRrbSb0yzjMZ 6NFh/Lq9igXyjHAYIIZF7+Etp5xijqCulKRxpuuDxuZDezKTKB1oYvfsrww3QFBYk+hO IFJJHNaipXYC9iDKo2dl6GB4Gm19OpjFzX9RANkhKn9QNvc8O9c+Z804eij9yjhm6CZR QmNkzxioD8KSBZfXtibarhbwLCURi5oSXgOLiQOdhTOlgq8PdsmicSPPH4QfxqgSGZC5 4Jl+jpHL5bq43fTDtn2lYVXFu5SBTOIRLNTeR1ZJvsesYSTbJa4WSI7uBSdCuLbk31Ot sw== Received: from mx0b-00154901.pphosted.com (mx0b-00154901.pphosted.com [67.231.157.37]) by mx0a-00154904.pphosted.com with ESMTP id 2uk2wsbtas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 28 Aug 2019 21:19:54 -0400 Received: from pps.filterd (m0089483.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7T1HUHJ022832 for ; Wed, 28 Aug 2019 21:19:54 -0400 Received: from ausxippc110.us.dell.com (AUSXIPPC110.us.dell.com [143.166.85.200]) by mx0b-00154901.pphosted.com with ESMTP id 2umvj3xc09-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 28 Aug 2019 21:19:53 -0400 X-LoopCount0: from 10.166.132.127 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,349,1549951200"; d="scan'208,217";a="849365262" From: To: , , , , , , CC: , Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Topic: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Index: AdVcR+OPrxJmOcouRhWzA1r7t1m4TQAMoO6AACKbwDAAHEv/sAAT9+pwABBi6MA= Date: Thu, 29 Aug 2019 01:19:51 +0000 Message-ID: References: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DD7DA@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C2A1B73@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C2A1B73@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Enabled=True; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Owner=Jayanth_Raghuram@Dell.com; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SetDate=2019-08-29T01:19:47.8936916Z; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Name=External Public; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Application=Microsoft Azure Information Protection; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Extended_MSFT_Method=Manual; aiplabel=External Public x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [143.166.24.60] MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-08-29_01:2019-08-28,2019-08-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 suspectscore=0 mlxlogscore=812 spamscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1908290012 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 bulkscore=0 mlxlogscore=947 clxscore=1015 mlxscore=0 spamscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1908290012 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_f49e7ce938cf4c25aca609918a41a72dausx13mps324AMERDELLCOM_" --_000_f49e7ce938cf4c25aca609918a41a72dausx13mps324AMERDELLCOM_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Per your request, I have created an pull request as below: https://github.com/tianocore/edk2/pull/147 MdePkg/DxeHstiLib: Added checks to improve error handling. #147 Open JayRaghuram wants to merge 1 commit into t= ianocore:master from JayRaghuram:master<= https://github.com/JayRaghuram/edk2> Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 From: Ni, Ray Sent: Wednesday, August 28, 2019 12:33 PM To: Gao, Liming; Cetola, Stephano; Kinney, Michael D; leif.lindholm@linaro= .org; Raghuram, Jayanth; 'Andrew Fish (afish@apple.com)'; Laszlo Ersek Cc: Liu, Wei G; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to impro= ve error handling. [EXTERNAL EMAIL] Liming, Stephano and all stewards, My understanding is the requirement of embedding patch into the mail body = is due to a limitation in old system (01.org). That system couldn't support= mail attachments. With the existence of mail attachments capability in new groups.io system,= can we accept such kind of patch submission? Or any side effect you see if= allowing mail attachments? Thanks, Ray From: devel@edk2.groups.io > On Behalf Of Liming Gao Sent: Wednesday, August 28, 2019 12:59 AM To: Jayanth.Raghuram@dell.com; devel@edk= 2.groups.io Cc: Wei.G.Liu@dell.com Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to impro= ve error handling. OK. So, you can't use git send-email to send this patch. Another way is to= fork edk2 and create the branch to include this change. Then, send the mail to let people review this patch in your branch. And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ fir= st? Then, update its commit message format based on this wiki. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: Jayanth.Raghuram@dell.com [mailto:= Jayanth.Raghuram@dell.com] Sent: Wednesday, August 28, 2019 2:30 AM To: Gao, Liming >; devel= @edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error hand= ling. Hi Liming, I sent the review request based on the description in the links that you m= entioned below. I sent it in an Dell Email since I cannot use GIT SMTP to send email out f= rom our servers. Please let me know what is wrong and I can help rectify that. Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 From: Gao, Liming > Sent: Monday, August 26, 2019 8:57 PM To: devel@edk2.groups.io; Raghuram, Jayanth Cc: Liu, Wei G Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error hand= ling. [EXTERNAL EMAIL] Can you follow this process to send this patch again? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-P= rocess And, the commit message format is https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2= .groups.io] On Behalf Of Jayanth.Raghuram@dell.com Sent: Tuesday, August 27, 2019 3:55 AM To: devel@edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve e= rror handling. Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling= . Added checks for return parameters of LocateHandleBuffer & GetSupportedTyp= es function calls in InternalHstiFindAip to improve error handling. An issue = was observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI driver returned InfoTypesBuffer =3D NULL, InfoTypesBufferCount =3D 0 and c= aused an FreePool assert. Signed-off-by: Jayanth Raghuram > Cc: Wei G Liu > Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 --_000_f49e7ce938cf4c25aca609918a41a72dausx13mps324AMERDELLCOM_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Liming,

 

Per your request, I have created an pull request as= below:

https://github.com/tianocore/edk2/pull/147

 

MdePkg/DxeHstiLib: Added = checks to improve error handling. #147

 Open

JayRaghuram wants to merge=  1 = commit into tianocore<= span style=3D"color:#0366D6">:master from JayRaghu= ram:master

 

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Wednesday, August 28, 2019 12:33 PM
To: Gao, Liming; Cetola, Stephano; Kinney, Michael D; leif.lindholm= @linaro.org; Raghuram, Jayanth; 'Andrew Fish (afish@apple.com)'; Laszlo Ers= ek
Cc: Liu, Wei G; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks t= o improve error handling.

 

[EXTERNAL EMAIL]

Liming, Stephano and all stewards,

My understanding is the requirement of embedding pa= tch into the mail body is due to a limitation in old system (01.org). That = system couldn’t support mail attachments.

 

With the existence of mail attachments capability i= n new groups.io system, can we accept such kind of patch submission? Or any= side effect you see if allowing mail attachments?

 

Thanks,

Ray

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Liming Gao
Sent: Wednesday, August 28, 2019 12:59 AM
To: Jayanth.Raghuram@d= ell.com; devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks t= o improve error handling.

 

OK. So, you can’= ;t use git send-email to send this patch. Another way is to fork edk2 and c= reate the branch to include this change.

Then, send the mail t= o let people review this patch in your branch.

 

And, for this patch, = can you submit BZ https://bugzilla.tianoc= ore.org/ first?

Then, update its comm= it message format based on this wiki.

https://github.com/tianocore/tianocore= .github.io/wiki/Commit-Message-Format

 

Thanks

Liming

From: Jayanth.Raghuram@dell.com [mailto:Jayanth.Raghuram@dell.com]
Sent: Wednesday, August 28, 2019 2:30 AM
To: Gao, Liming <liming.= gao@intel.com>; devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve err= or handling.

 

Hi Liming,

 

I sent the review request based on the description = in the links that you mentioned below.

I sent it in an Dell Email since I cannot use GIT S= MTP to send email out from our servers.

Please let me know what is wrong and I can help rec= tify that.

 

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

 

[EXTERNAL EMAIL]

Can you follow this p= rocess to send this patch again?

https://github.com/tianocore/tian= ocore.github.io/wiki/EDK-II-Development-Process

 

And, the commit messa= ge format is

https://github.com/tianocore/tianocore= .github.io/wiki/Commit-Message-Format

 

Thanks

Liming

From: devel@edk2.groups.io [mailto:= devel@edk2.groups.io] On Behalf Of Jayanth.R= aghuram@dell.com
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to im= prove error handling.

 

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to= improve error handling.

Added checks for return parameters of LocateHandleB= uffer & GetSupportedTypes

function calls in InternalHstiFindAip to improve er= ror handling. An issue was

observed on Dell Poweredge R740, where the Dell PER= C H740P controller UEFI

driver returned InfoTypesBuffer =3D NULL, InfoTypes= BufferCount =3D 0 and caused

an FreePool assert.

 

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram@Dell.com><= /p>

Cc: Wei G Liu <Wei_G_Liu@Dell.com>

 

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-im= prove-error-hand.patch

 

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

--_000_f49e7ce938cf4c25aca609918a41a72dausx13mps324AMERDELLCOM_--