From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 82780211D6177 for ; Tue, 12 Mar 2019 07:18:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60391C057F5D; Tue, 12 Mar 2019 14:18:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-59.rdu2.redhat.com [10.10.120.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4ACF11797C; Tue, 12 Mar 2019 14:18:39 +0000 (UTC) To: "Dong, Eric" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" References: <20190311005516.2864-1-shenglei.zhang@intel.com> <20190311005516.2864-4-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: Date: Tue, 12 Mar 2019 15:18:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 12 Mar 2019 14:18:40 +0000 (UTC) Subject: Re: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 14:18:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/11/19 02:15, Dong, Eric wrote: > Reviewed-by: Eric Dong Thanks. I'm on the verge of email bankruptcy, so I'll skip this review. Laszlo >> -----Original Message----- >> From: Zhang, Shenglei >> Sent: Monday, March 11, 2019 8:55 AM >> To: edk2-devel@lists.01.org >> Cc: Dong, Eric ; Ni, Ray ; Laszlo >> Ersek >> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help >> information >> >> The prompt and help information are missing in UefiPkg.uni. >> https://bugzilla.tianocore.org/show_bug.cgi?id=1600 >> >> Cc: Eric Dong >> Cc: Ray Ni >> Cc: Laszlo Ersek >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Shenglei Zhang >> --- >> UefiCpuPkg/UefiCpuPkg.uni | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index >> b132ce62cf..0e57b6ac98 100644 >> --- a/UefiCpuPkg/UefiCpuPkg.uni >> +++ b/UefiCpuPkg/UefiCpuPkg.uni >> @@ -114,6 +114,10 @@ >> >> #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_HELP >> #language en-US "Specifies stack size in bytes for each processor in SMM." >> >> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_PROMPT >> #language en-US "Processor stack size in SMM." >> + >> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_Help >> #language en-US "Specifies stack size in bytes for each processor in SMM." >> + >> #string >> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_PROMPT >> #language en-US "AP synchronization timeout value in SMM" >> >> #string >> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_HELP >> #language en-US "Specifies timeout value in microseconds for the BSP in >> SMM to wait for all APs to come into SMM." >> -- >> 2.18.0.windows.1 >