[PATCH 0/3] Add the prompt and help information in .uni files

[PATCH 0/3] Add the prompt and help information in .uni files

[Shenglei Zhang]

The prompt and help information are missing in
MdePkg/UefiPkg/SecurityPkg.uni

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Shenglei Zhang (3):
  MdePkg/MdePkg.uni: Add the prompt and help information
  SecurityPkg/SecurityPkg.uni: Add the prompt and help information
  UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information

 MdePkg/MdePkg.uni           | 7 +++++++
 SecurityPkg/SecurityPkg.uni | 6 ++++++
 UefiCpuPkg/UefiCpuPkg.uni   | 4 ++++
 3 files changed, 17 insertions(+)

-- 
2.18.0.windows.1

[PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help information

[Shenglei Zhang]

The prompt and help information are missing in MdePkg.uni.
https://bugzilla.tianocore.org/show_bug.cgi?id=1600

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdePkg/MdePkg.uni | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni
index 863a68d025..4f86432eb2 100644
--- a/MdePkg/MdePkg.uni
+++ b/MdePkg/MdePkg.uni
@@ -148,6 +148,13 @@
                                                                                          "0  - No length check for unicode string.<BR>\n"
                                                                                          ">0 - Maximum length of unicode string.<BR>"
 
+#string STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMask_PROMPT  #language en-US "Maximum Length of Unicode String."
+
+#string STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMask_HELP  #language en-US  "Indicates the maximum length of unicode string used in the following\n"
+                                                                                                  "BaseLib functions: StrLen(), StrSize(), StrCmp(), StrnCmp(), StrCpy(), StrnCpy()<BR><BR>\n"
+                                                                                                  "0  - No length check for unicode string.<BR>\n"
+                                                                                                  ">0 - Maximum length of unicode string.<BR>"
+
 #string STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_PROMPT  #language en-US "Maximum Length of Ascii String"
 
 #string STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_HELP  #language en-US "Sets the maximum number of ASCII characters used for string functions.  This affects the following BaseLib functions: AsciiStrLen(), AsciiStrSize(), AsciiStrCmp(), AsciiStrnCmp(), AsciiStrCpy(), AsciiStrnCpy(). <BR><BR>\n"
-- 
2.18.0.windows.1

Re: [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help information

[Yao, Jiewen]

HI
I am confused why the help info is " Indicates the maximum length of Unicode string used in the following " ?

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Shenglei Zhang
> Sent: Monday, March 11, 2019 8:55 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help
> information
> 
> The prompt and help information are missing in MdePkg.uni.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1600
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdePkg/MdePkg.uni | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni
> index 863a68d025..4f86432eb2 100644
> --- a/MdePkg/MdePkg.uni
> +++ b/MdePkg/MdePkg.uni
> @@ -148,6 +148,13 @@
> 
> "0  - No length check for unicode string.<BR>\n"
> 
> ">0 - Maximum length of unicode string.<BR>"
> 
> +#string
> STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas
> k_PROMPT  #language en-US "Maximum Length of Unicode String."
> +
> +#string
> STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas
> k_HELP  #language en-US  "Indicates the maximum length of unicode
> string used in the following\n"
> +
> "BaseLib functions: StrLen(), StrSize(), StrCmp(), StrnCmp(), StrCpy(),
> StrnCpy()<BR><BR>\n"
> +
> "0  - No length check for unicode string.<BR>\n"
> +
> ">0 - Maximum length of unicode string.<BR>"
> +
>  #string
> STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_PROMPT
> #language en-US "Maximum Length of Ascii String"
> 
>  #string
> STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_HELP
> #language en-US "Sets the maximum number of ASCII characters used for
> string functions.  This affects the following BaseLib functions: AsciiStrLen(),
> AsciiStrSize(), AsciiStrCmp(), AsciiStrnCmp(), AsciiStrCpy(), AsciiStrnCpy().
> <BR><BR>\n"
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and help information

[Zhang, Shenglei]

Sorry that's my mistake. I'll fix the error in v2.

Thanks,
Shenglei

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Monday, March 11, 2019 9:49 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: RE: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and
> help information
> 
> HI
> I am confused why the help info is " Indicates the maximum length of
> Unicode string used in the following " ?
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Shenglei Zhang
> > Sent: Monday, March 11, 2019 8:55 AM
> > To: edk2-devel@lists.01.org
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: [edk2] [PATCH 1/3] MdePkg/MdePkg.uni: Add the prompt and
> help
> > information
> >
> > The prompt and help information are missing in MdePkg.uni.
> > https://bugzilla.tianocore.org/show_bug.cgi?id=1600
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  MdePkg/MdePkg.uni | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni
> > index 863a68d025..4f86432eb2 100644
> > --- a/MdePkg/MdePkg.uni
> > +++ b/MdePkg/MdePkg.uni
> > @@ -148,6 +148,13 @@
> >
> > "0  - No length check for unicode string.<BR>\n"
> >
> > ">0 - Maximum length of unicode string.<BR>"
> >
> > +#string
> >
> STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas
> > k_PROMPT  #language en-US "Maximum Length of Unicode String."
> > +
> > +#string
> >
> STR_gEfiMdePkgTokenSpaceGuid_PcdControlFlowEnforcementPropertyMas
> > k_HELP  #language en-US  "Indicates the maximum length of unicode
> > string used in the following\n"
> > +
> > "BaseLib functions: StrLen(), StrSize(), StrCmp(), StrnCmp(), StrCpy(),
> > StrnCpy()<BR><BR>\n"
> > +
> > "0  - No length check for unicode string.<BR>\n"
> > +
> > ">0 - Maximum length of unicode string.<BR>"
> > +
> >  #string
> >
> STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_PROMPT
> > #language en-US "Maximum Length of Ascii String"
> >
> >  #string
> > STR_gEfiMdePkgTokenSpaceGuid_PcdMaximumAsciiStringLength_HELP
> > #language en-US "Sets the maximum number of ASCII characters used for
> > string functions.  This affects the following BaseLib functions: AsciiStrLen(),
> > AsciiStrSize(), AsciiStrCmp(), AsciiStrnCmp(), AsciiStrCpy(), AsciiStrnCpy().
> > <BR><BR>\n"
> > --
> > 2.18.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

[PATCH 2/3] SecurityPkg/SecurityPkg.uni: Add the prompt and help information

[Shenglei Zhang]

The prompt and help information are missing in SecurityPkg.uni.
https://bugzilla.tianocore.org/show_bug.cgi?id=1600

Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 SecurityPkg/SecurityPkg.uni | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni
index 400fe6015e..5f387672e8 100644
--- a/SecurityPkg/SecurityPkg.uni
+++ b/SecurityPkg/SecurityPkg.uni
@@ -248,6 +248,12 @@
 #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdTpm2PossibleIrqNumBuf_HELP  #language en-US "This PCD defines possible TPM2 interrupt number in a platform reported by _PRS control method.\n"
                                                                                          "If PcdTpm2CurrentIrqNum set to 0, _PRS will not report any possible TPM2 interrupt numbers."
 
+#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdSkipOpalDxeUnlock_PROMPT  #language en-US "Skip Opal DXE driver unlock device flow."
+
+#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdSkipOpalDxeUnlock_HELP  #language en-US "Indicates if Opal DXE driver skip unlock device flow.<BR><BR>\n"
+                                                                                     "TRUE  - Skip unlock device flow.<BR>\n"
+                                                                                     "FALSE - Does not skip unlock device flow.<BR>"
+
 #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdActiveTpmInterfaceType_PROMPT  #language en-US "Current active TPM interface type"
 
 #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdActiveTpmInterfaceType_HELP  #language en-US "This PCD indicates current active TPM interface type.\n"
-- 
2.18.0.windows.1

[PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information

[Shenglei Zhang]

The prompt and help information are missing in UefiPkg.uni.
https://bugzilla.tianocore.org/show_bug.cgi?id=1600

Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 UefiCpuPkg/UefiCpuPkg.uni | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni
index b132ce62cf..0e57b6ac98 100644
--- a/UefiCpuPkg/UefiCpuPkg.uni
+++ b/UefiCpuPkg/UefiCpuPkg.uni
@@ -114,6 +114,10 @@
 
 #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_HELP  #language en-US "Specifies stack size in bytes for each processor in SMM."
 
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_PROMPT  #language en-US "Processor stack size in SMM."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_Help  #language en-US "Specifies stack size in bytes for each processor in SMM."
+
 #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_PROMPT  #language en-US "AP synchronization timeout value in SMM"
 
 #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_HELP  #language en-US "Specifies timeout value in microseconds for the BSP in SMM to wait for all APs to come into SMM."
-- 
2.18.0.windows.1

Re: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information

[Dong, Eric]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Monday, March 11, 2019 8:55 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> Ersek <lersek@redhat.com>
> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help
> information
> 
> The prompt and help information are missing in UefiPkg.uni.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1600
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.uni | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index
> b132ce62cf..0e57b6ac98 100644
> --- a/UefiCpuPkg/UefiCpuPkg.uni
> +++ b/UefiCpuPkg/UefiCpuPkg.uni
> @@ -114,6 +114,10 @@
> 
>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_HELP
> #language en-US "Specifies stack size in bytes for each processor in SMM."
> 
> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_PROMPT
> #language en-US "Processor stack size in SMM."
> +
> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_Help
> #language en-US "Specifies stack size in bytes for each processor in SMM."
> +
>  #string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_PROMPT
> #language en-US "AP synchronization timeout value in SMM"
> 
>  #string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_HELP
> #language en-US "Specifies timeout value in microseconds for the BSP in
> SMM to wait for all APs to come into SMM."
> --
> 2.18.0.windows.1

Re: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help information

[Laszlo Ersek]

On 03/11/19 02:15, Dong, Eric wrote:
> Reviewed-by: Eric Dong <eric.dong@intel.com>

Thanks. I'm on the verge of email bankruptcy, so I'll skip this review.

Laszlo

>> -----Original Message-----
>> From: Zhang, Shenglei
>> Sent: Monday, March 11, 2019 8:55 AM
>> To: edk2-devel@lists.01.org
>> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
>> Ersek <lersek@redhat.com>
>> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help
>> information
>>
>> The prompt and help information are missing in UefiPkg.uni.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1600
>>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>> ---
>>  UefiCpuPkg/UefiCpuPkg.uni | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index
>> b132ce62cf..0e57b6ac98 100644
>> --- a/UefiCpuPkg/UefiCpuPkg.uni
>> +++ b/UefiCpuPkg/UefiCpuPkg.uni
>> @@ -114,6 +114,10 @@
>>
>>  #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_HELP
>> #language en-US "Specifies stack size in bytes for each processor in SMM."
>>
>> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_PROMPT
>> #language en-US "Processor stack size in SMM."
>> +
>> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_Help
>> #language en-US "Specifies stack size in bytes for each processor in SMM."
>> +
>>  #string
>> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_PROMPT
>> #language en-US "AP synchronization timeout value in SMM"
>>
>>  #string
>> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_HELP
>> #language en-US "Specifies timeout value in microseconds for the BSP in
>> SMM to wait for all APs to come into SMM."
>> --
>> 2.18.0.windows.1
>