From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 85DDC7803EC for ; Tue, 3 Oct 2023 15:53:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iwJCbCv8EykA25h3vs6g/S61oQxJ6gFldIP6dJlN0m8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696348423; v=1; b=Xhon9zTFJR4JBb4iI2IEeWn0zKnebEM9PI8EDkWoDzt7l7R9jPFRzKiFoP4oJuULgEkqHs68 9d0xasrEmGLeBL1PcFB6LiWQt6pTsirT2Aqt7EtJAFddjcVep0Hqgz+A0ST7DNfHyTvptPUEmVf fib9VbPSJaf++hlWwCVTlpvY= X-Received: by 127.0.0.2 with SMTP id ZUDFYY7687511xI6nqdfVWn5; Tue, 03 Oct 2023 08:53:43 -0700 X-Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web10.89437.1696269625514456890 for ; Mon, 02 Oct 2023 11:00:25 -0700 X-Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40652e570d9so520605e9.1 for ; Mon, 02 Oct 2023 11:00:25 -0700 (PDT) X-Gm-Message-State: wEg9PMr8kYX1immoXRbJ6Vi9x7686176AA= X-Google-Smtp-Source: AGHT+IG1Vv3N/C7tpj3PmsNQe1ZChvuJ6oie3HW58XoYZ1LS5VX0qrFHfEnq0oXaTke8BPcYL3usNg== X-Received: by 2002:a5d:45c9:0:b0:320:66:cf67 with SMTP id b9-20020a5d45c9000000b003200066cf67mr10156317wrs.18.1696269623796; Mon, 02 Oct 2023 11:00:23 -0700 (PDT) X-Received: from [192.168.69.115] (176-131-222-246.abo.bbox.fr. [176.131.222.246]) by smtp.gmail.com with ESMTPSA id j2-20020a5d4642000000b00317e77106dbsm28539859wrs.48.2023.10.02.11.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 11:00:23 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 20:00:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations To: Leif Lindholm , devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar References: <20230926171523.368706-1-quic_llindhol@quicinc.com> <20230926171523.368706-4-quic_llindhol@quicinc.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230926171523.368706-4-quic_llindhol@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Xhon9zTF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Leif, On 26/9/23 19:15, Leif Lindholm wrote: > There may be architectures on which there are benefits to > eor r0, r0(, r0) > but ARM was never one of them. Change to more readable > mov r0, #0 > instead. >=20 > Signed-off-by: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > --- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 +- > MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Libr= ary/BaseLib/Arm/SetJumpLongJump.asm > index e1eff758f7ab..ef02d85e0e66 100644 > --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm > @@ -33,7 +33,7 @@ > SetJump > MOV R3, R13 > STM R0, {R3-R12,R14} > - EOR R0, R0 > + MOV RO, #0 Hmm. s/RO/R0/ ? > BX LR > =20 > ;/** -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109290): https://edk2.groups.io/g/devel/message/109290 Mute This Topic: https://groups.io/mt/101600809/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-