From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.11756.1580227686898094059 for ; Tue, 28 Jan 2020 08:08:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PAryIteq; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580227685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U3mfLk+IDb2j3y7K+N+PdvGU1TJRSJT0Pa35XRod4UY=; b=PAryIteqojxLxpVVd6FE+aavWCbYQRs1cP2jo5pqWnvUrYuSJwwvQF8DlC245VA3kzmSlK C+l7X/LV02fHK2BF0l/SpMTxcJ5m3NjmZfkNKGB5nAYvnJEqJ90h8LAE9fvfF2CQY+qeAk P/9D67JOYVQx6X/7p7CcgmoDtOrEaZA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-UYqksxgwPeupQRYyv8-ZgA-1; Tue, 28 Jan 2020 11:07:53 -0500 Received: by mail-wr1-f69.google.com with SMTP id j4so8252519wrs.13 for ; Tue, 28 Jan 2020 08:07:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U3mfLk+IDb2j3y7K+N+PdvGU1TJRSJT0Pa35XRod4UY=; b=ig/0kxwUzVd5e5fUO3tfVPjX5eGpOMV/lw+k/KyNrpRtZgVKVwAVNF+NGvTYDXA9K4 FLSHE0dAqL6fNIZUbMTqDQtM4/pmEmhOplsjx20cBmbenQAub3Qwz5pqkDh6lZ+3IDjd uDVsOGojusi0dIUqNRaopBiL8LSdSmCRD9DCFGw0nz6cT3wosYNUc/HpQQxrBen2yZdC rR41T7/SbQJ08WOQtMYW4ll1OhMRZlz1fvPb+jXggIPPOAYFTKFWz3anQa1F8+kdiH5I cJEHXEXOYFjAW5XjbmnXlYHjVszuGm+6Y7uPhsXHUqzIP3glHSJMFV2O7BeIuLzvoQtW GxxQ== X-Gm-Message-State: APjAAAVU6aR5RI7dZhja+6TbrhsmEQOlKnDPL5WH65gXA/nHfh7F38iG hCRreqUsgYJ6I12roPl07MVYXMI6XgFlyS2i466tj3mKgUh/7ekAU+Jc1Cu/4OuhBcb/8Pkm7rY KXS2rAizsr4LzYg== X-Received: by 2002:a1c:3906:: with SMTP id g6mr6160554wma.49.1580227672129; Tue, 28 Jan 2020 08:07:52 -0800 (PST) X-Google-Smtp-Source: APXvYqzjsmbklgvOJJtksuZ5b/nn4oiN+5HToWgG4gREGCLZWrcc6xIYyDaeGqhhICZyEUbbX4p3Ww== X-Received: by 2002:a1c:3906:: with SMTP id g6mr6160523wma.49.1580227671840; Tue, 28 Jan 2020 08:07:51 -0800 (PST) Return-Path: Received: from [192.168.1.35] (113.red-83-57-172.dynamicip.rima-tde.net. [83.57.172.113]) by smtp.gmail.com with ESMTPSA id a13sm1006219wrp.93.2020.01.28.08.07.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 08:07:51 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables To: devel@edk2.groups.io, krzysztof.koch@arm.com Cc: Ard Biesheuvel , Leif Lindholm , Michael D Kinney , leif@nuviainc.com, Sami.Mujawar@arm.com, Matteo.Carlini@arm.com, nd@arm.com References: <20200128150505.45700-1-krzysztof.koch@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 28 Jan 2020 17:07:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200128150505.45700-1-krzysztof.koch@arm.com> X-MC-Unique: UYqksxgwPeupQRYyv8-ZgA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 1/28/20 4:05 PM, Krzysztof Koch wrote: > Fix 'mAcpiRegistration defined but not used' compiler error for > Dynamic Tables Framework builds. > > Do not declare the mAcpiRegistration variable in the Dynamic Tables > Framework context. > > Commit 484a683ab9f made mAcpiRegistration variable STATIC. Reducing > scope made scope resolution simpler, thus, the 'defined but not used' > error got raised. > > Signed-off-by: Krzysztof Koch > --- > > Changes can be seen at: https://github.com/KrzysztofKoch1/edk2-platforms/tree/723_fix_unused_variable_juno_dxe_v2 > > Notes: > v2: > - Specify which previous commit inroduced the error [Philippe] Thanks for the update. Since the change is minor, you could have kept my R-b tag. Anyway: Reviewed-by: Philippe Mathieu-Daude > > v1: > - Fix 'defined but not used' Dynamic Tables build error [Krzysztof] > > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > index e3b64992e02c003f7e3a6636340a6afa573f477a..cd7a205f90f131560419cfd744dd5c22df726c99 100644 > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > @@ -1,6 +1,6 @@ > /** @file > * > -* Copyright (c) 2013-2019, ARM Limited. All rights reserved. > +* Copyright (c) 2013-2020, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -30,9 +30,9 @@ > #ifndef DYNAMIC_TABLES_FRAMEWORK > // This GUID must match the FILE_GUID in ArmPlatformPkg/ArmJunoPkg/AcpiTables/AcpiTables.inf > STATIC CONST EFI_GUID mJunoAcpiTableFile = { 0xa1dd808e, 0x1e95, 0x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } }; > -#endif > - > STATIC VOID *mAcpiRegistration = NULL; > +#endif > + > STATIC VOID *mPciIoNotificationRegistration = NULL; > > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > >