From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.88]) by mx.groups.io with SMTP id smtpd.web12.6553.1666786024466953181 for ; Wed, 26 Oct 2022 05:07:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=NOYqjjs6; spf=pass (domain: arm.com, ip: 40.107.7.88, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=I01WqiebyOLCaSSrkkHuu4jcgKh8batyzK5ffBsGY/yCEP3MU8qm3oTxTUCcYYfrUXpvkis0Lfze3uIXPjfEv0y5/B84ObE+kNgut8o4iNJmDVu8NXNeAY6Da/pCsTiFXzIbDTHP32H5aP75CCnBhV5JPvSPJV1BJZVOXO1qEPeHQwU5TD0VWlTwXSrtXR3usb0uSBncT6TKrB8Nxj14p3DOpPcFDjC/GgDioRxLOWfk22cZ8fba9Rr9Fkyp1plwrjj5TeqqKQ3WjU29pOba6e17heEUZtYVg4zHnO24UJ/w1JfkVdABLmHQEuR33s5ebovTt8SLWw5bHlY1QlkFMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qVOJqBazBQ8zeHVYKzloOfDCLZkp/rcXrz/nW0hLWvg=; b=QQdVXiTIrC9ElPAKwdjD2PD2knKygXpqgHwDCeFXdYdbsGFNsakBnif5RCwfv1JsNfC/P73Bo1Yj3xdatjKo5bbqOeA5D+ng7/5fzE6y6xuZAiZUTv5B6ZRBOQxGlVEQmxhOlhOrxq+ZaV4QAR4n1X5Slkkz79u6d61XtB+gPscVubION+NprOGuO8A9KPXhx2W+35vzIqWHGEvATmQRSgIanO4LXSkO44SnW4BrYkzua3uO1SrQoH3lwIpH1/hrm4Frj4ebK/pk/i9o1FaiRrPP19gLRUMpbawpjMxexL5VhX4MYOsct3+NGCKt6zDeJQucPGbeT1SrVXm+/p+uHA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qVOJqBazBQ8zeHVYKzloOfDCLZkp/rcXrz/nW0hLWvg=; b=NOYqjjs62nprfQTux+WAEtcq+xvoL5tyxmNsybTve4xix4MIu9aFXpiYSnoqGoFDvM1m9Nt1AsQAPZKhhH2hiCxNg1SxhIpwYtFNrZnafbuW93qjjT6xgfB3eBn/ElhXeDQH+oC+xrotT2ab4xQ6bhAc+PZh1zw0nNSbGm7RxHY= Received: from FR0P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::20) by PAXPR08MB6606.eurprd08.prod.outlook.com (2603:10a6:102:157::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26; Wed, 26 Oct 2022 12:07:00 +0000 Received: from VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a9:cafe::83) by FR0P281CA0105.outlook.office365.com (2603:10a6:d10:a9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.10 via Frontend Transport; Wed, 26 Oct 2022 12:07:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT052.mail.protection.outlook.com (100.127.144.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend Transport; Wed, 26 Oct 2022 12:07:00 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Wed, 26 Oct 2022 12:06:59 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b965fd4947faa82c X-CR-MTA-TID: 64aa7808 Received: from 7c19dfe734a6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E208E901-20C5-4B0D-9656-DCD070796B2C.1; Wed, 26 Oct 2022 12:06:48 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7c19dfe734a6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Oct 2022 12:06:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gBbVgl+RWn6gklj2KMdZIwQyw50BcvLasHDjd/Li//TWcDfaTLS88QEJq5bfcmp5eD6maHmbaUqMKVcBwDk4LjbZ4CmqIm25ikU7oab3o+kXbMKyDkj6y449DInVB4TJ5GN0BArim4g/DqZVpvdex0AaLeXi5Kf0SjVwnp8N7GQDMv2K0Fbyvd2P2ZQA2mfLkPPbu1bb1CnMfwLL/bx7GvslnXb7rq2U700PUZajlgZsRr6PEBxCr+62qPfc3G4LgLCH/7aYDw/Cv/WQJH0bX+fukOP+O4hENkwVZGtG3ropsBecnbOayufD7QVHKJP+MHL3p+bstOAt3+xvQqgwjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qVOJqBazBQ8zeHVYKzloOfDCLZkp/rcXrz/nW0hLWvg=; b=cmP7+2mG1ynnVStZAukefn4nmNlzNzqCkzugWD+/xZkFGfIb38RdaBK2QkIu558BFW82p8hzPZnZZTGEaWEwKgOwwtt5cYSryvyViLbfZDKtfVhMuIAorDLXdNZxb4INU4THFmyzCZGTsq07btD7k2VCE35mA0avtUWqMRugkiWqeHjNut+xBD/Oe3RDzhFp6yGCf4MRZjKUEar/Yb9remq5sucXUNi1kpBSKfr6FcJ/nQe4X9npF4QiqqtTqpdSwsuX0/ZmwJiYmcWwngatXd8FLAlE7w7Sj6Vs2cU99pMJOCjUQa7PsZbfGqcGMJjYPZB2xB9FnpzO1bz0F8WhPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qVOJqBazBQ8zeHVYKzloOfDCLZkp/rcXrz/nW0hLWvg=; b=NOYqjjs62nprfQTux+WAEtcq+xvoL5tyxmNsybTve4xix4MIu9aFXpiYSnoqGoFDvM1m9Nt1AsQAPZKhhH2hiCxNg1SxhIpwYtFNrZnafbuW93qjjT6xgfB3eBn/ElhXeDQH+oC+xrotT2ab4xQ6bhAc+PZh1zw0nNSbGm7RxHY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by GV1PR08MB7938.eurprd08.prod.outlook.com (2603:10a6:150:8d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.24; Wed, 26 Oct 2022 12:06:36 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::283c:fe2e:699d:2bf%5]) with mapi id 15.20.5746.027; Wed, 26 Oct 2022 12:06:36 +0000 Message-ID: Date: Wed, 26 Oct 2022 13:06:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5 To: Pierre.Gondois@arm.com, devel@edk2.groups.io, Ray Ni , Zhichao Gao Cc: Alexei Fedorov , "nd@arm.com" References: <20221010092058.118714-1-Pierre.Gondois@arm.com> <20221010092058.118714-15-Pierre.Gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20221010092058.118714-15-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO4P123CA0370.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|GV1PR08MB7938:EE_|VI1EUR03FT052:EE_|PAXPR08MB6606:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cbc4e3f-2351-4997-9c8c-08dab74a9642 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1iVKbCfSu8RrVQ/KrfQD4PbqFBC/zlFOh4IhbkwBZ8BvOjrNTZYPwvTCvV9j1gDduXywVsKuRKP/4npgF9vA2bueJqGUiZykfsYhBE1FaBoY+S89XsS7puXZpIFYh+xlP2VrKbg6aLjRWPBLsvh/+iklX0qS5HTvimib1y13Gyuao5p21Qyckcu1gwz480uGPCLeZDSnd2RotOIso6gzMpMJ49K8oE+iWJcQzCLFIlQkMPzNwira3UNWXGF4wXVXgQfpd+e8RR3u1z7/ddMydhAlH2yjZvRCwjiyrPOAEiBd+tqnM1kp46ipmxCcj7dRYuqPO0uOpPPF5zE03pJTlEwEgj3fRV0xlu6Ey5ktpkGIf0+CDkAT0dbqBhO4as5IKUDmQlI3gj0mEAw9m7vOanjtQ/lTK7CQ8MDQmKLEpQNDek3Vdgo+kgtYwLC2b03j48IWEyCDA/Bf63+FXvhdhhU45Cv9wmYN/sVAdKvTfHx0zDKehA65cKpZnt/BGgQJI3gF3elLkcEDzRkGRmYcKvw7FR1EjtMN1cxSIWJgDHtIM3Ik0LqRvipEq8LqtA/IPLcDO1wXPtQd9oqvtnPpKECsxCvduQRjfoYs3z4E5YGlAbWu/Cwc6OM3rb0sJ21O1WJI2+cFWjof8/q/hRDmoRk0HYKZ9NnAQQBOV3HD8auvfw68u0nlj39FjXSOS4h2NH5esHYe7bm2QIabH4ue5osBMMVxJ6mqznD+wyzQwyEwbQfVGQcvRpeH+dijpYsxARzoEUiaASQSaJyIX5e2quZTcM8PfPv+m0cbBoO5lDA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(396003)(346002)(376002)(451199015)(31696002)(8676002)(4326008)(36756003)(44832011)(86362001)(2906002)(66556008)(66946007)(8936002)(110136005)(5660300002)(41300700001)(15650500001)(54906003)(26005)(66476007)(53546011)(6512007)(316002)(6506007)(186003)(2616005)(83380400001)(38100700002)(6486002)(478600001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7938 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f8c8d54c-5048-476c-f436-08dab74a87da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Os1YzKiS/QG/3UtVx+8KHDPeAfOGIXK7+wBwip76DuYNsfDxkVtVKiuRYi5dDluTbliYIk7Dc+HxfD1qMPLgdlob8oNo9DE14queqaMY+tx4zj4zZqxfCvAT8oIsdgUvKJsIHrX5mCcXPlttxFjw+0eJplkk6uhuL7ll5VBBzJ8+Lf0fakxgiIT3nL5qoAyHA7cZVmEs+6unK7KO71rcx720VxsjtlXyYWOZ7IkoXBB9wCMOsq+7YCrL/IO+ZCvOsVA2mJYItD4xKkuaKutH+Usv5sng9YVpentqI+rsRHYrriZ4BHwMVd/9TWraWbxBq6q6pyZ3v2UbNiQO9G4CVh2a3vWnskdjw5eJLzL7ZKwpe3GWJY34b/Xa97E6ALZUM8DiPqY2JxOsDqbx0sNY4Uko5Ab/+5P5qYZjwJG2XvHyyGwAdmtG/Nv5RXRTfEMD2AaDcjh0swLmPNPeqhHBP5tVNzRgE5uC/umuTQfKvQat6Nlpp/Q3e6O4HO+OsNWCvZVoU303OyVc++iaGWB2sOzWOCAS9IGdjxAYZybRb+nQLgblEJwJRbClUE2qMboUHAyJI+4+YfSuC5CVEKPhTmLEreYSGpADI5d4tp1xahs6XfDBGoVz8PxxJltdaVvbevzfqRK6H7CwmTtmpeZfVcM6BQ3p+2aar1Z3QEz5kEY8NXCVjRtRdH/lKN9awFnjOffhPXJxBK8oV7gp3gL3CM6EHbOGxgdVpTWEsKgOCpUuP/1h8drDUGGu89B6/8UUjuevpJ2fclDm0Pi4vuky/JzxmpHaD/sDWxfEgjhgIpM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(39860400002)(136003)(451199015)(40470700004)(36840700001)(46966006)(36860700001)(8676002)(316002)(40480700001)(4326008)(54906003)(41300700001)(110136005)(15650500001)(70586007)(70206006)(8936002)(336012)(478600001)(2616005)(82740400003)(26005)(53546011)(6506007)(83380400001)(356005)(6512007)(40460700003)(81166007)(47076005)(86362001)(5660300002)(6486002)(31696002)(44832011)(186003)(82310400005)(36756003)(31686004)(2906002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2022 12:07:00.1663 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cbc4e3f-2351-4997-9c8c-08dab74a9642 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6606 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > The ACPI specification updated some terms in accordance with: > s1.1.1 Principle of Inclusive Terminology > > Update the PCCT parser accordincly with these new terms. > > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Pierre Gondois > --- > .../UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c > index 8cffdaaf0716..8ad39090afe3 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c > @@ -146,7 +146,7 @@ ValidatePccDoorbellGas ( > IN VOID *Context > ) > { > - // For slave subspaces this field is optional, if not present the field > + // For responder subspaces this field is optional, if not present the field > // should just contain zeros. > if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) { > if (IsZeroBuffer ( > @@ -214,7 +214,7 @@ ValidatePccErrStatusGas ( > IN VOID *Context > ) > { > - // This field is ignored by the OSPM on slave channels. > + // This field is ignored by the OSPM on responder channels. > if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) { > return; > } > @@ -237,7 +237,7 @@ ValidatePlatInterrupt ( > IN VOID *Context > ) > { > - // If a slave subspace is present in the PCCT, then the global Platform > + // If a responder subspace is present in the PCCT, then the global Platform > // Interrupt flag must be set to 1. > if ((*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) && > ((*PccGlobalFlags & EFI_ACPI_6_4_PCCT_FLAGS_PLATFORM_INTERRUPT) !=