From: "Laszlo Ersek" <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, devel@edk2.groups.io
Subject: Re: [PATCH 1/1] OvmfPkg/LinuxInitrdDynamicShellCommand: fix uninitialized status return
Date: Wed, 4 Mar 2020 17:58:35 +0100 [thread overview]
Message-ID: <f4d352fd-f41e-c6c5-ff4e-0578d0a1dc6a@redhat.com> (raw)
In-Reply-To: <20200304114919.8746-1-ard.biesheuvel@linaro.org>
On 03/04/20 12:49, Ard Biesheuvel wrote:
> The Linaro CI reports:
>
> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c:132:7:
> error: variable 'Status' is used uninitialized whenever 'if' condition is
> false [-Werror,-Wsometimes-uninitialized]
> if (mInitrdLoadFile2Handle != NULL) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c:141:10:
> note: uninitialized use occurs here
> return Status;
> ^~~~~~
> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c:132:3:
> note: remove the 'if' if its condition is always true
> if (mInitrdLoadFile2Handle != NULL) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c:130:23:
> note: initialize the variable 'Status' to silence this warning
> EFI_STATUS Status;
> ^
> = 0
>
> Fix this by pulling the return of Status into the conditional block where
> it is assigned, and return EFI_SUCCESS otherwise.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c b/OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c
> index ed8fbaa77069..021b072826a9 100644
> --- a/OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c
> +++ b/OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.c
> @@ -137,8 +137,9 @@ UninstallLoadFile2Protocol (
> if (!EFI_ERROR (Status)) {
> mInitrdLoadFile2Handle = NULL;
> }
> + return Status;
> }
> - return Status;
> + return EFI_SUCCESS;
> }
>
> STATIC
>
I should have caught this in review. :/
Please add the following to the commit message:
Fixes: 2632178bc683f1f28f9dbe269f85d6b26b1800de
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
next prev parent reply other threads:[~2020-03-04 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 11:49 [PATCH 1/1] OvmfPkg/LinuxInitrdDynamicShellCommand: fix uninitialized status return Ard Biesheuvel
2020-03-04 16:58 ` Laszlo Ersek [this message]
2020-03-04 17:43 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d352fd-f41e-c6c5-ff4e-0578d0a1dc6a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox