From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 10BC4211AEA4B for ; Fri, 4 Jan 2019 09:51:12 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92A61EBD; Fri, 4 Jan 2019 09:51:11 -0800 (PST) Received: from supven01-VirtualBox (unknown [10.119.49.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D43533F5D4; Fri, 4 Jan 2019 09:51:10 -0800 (PST) Message-ID: From: Supreeth Venkatesh To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Achin Gupta , Jiewen Yao , Leif Lindholm , Jagadeesh Ujja , Thomas Panakamattam Abraham , Sami Mujawar Date: Fri, 04 Jan 2019 11:51:05 -0600 In-Reply-To: <20190104110315.18339-4-ard.biesheuvel@linaro.org> References: <20190104110315.18339-1-ard.biesheuvel@linaro.org> <20190104110315.18339-4-ard.biesheuvel@linaro.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Subject: Re: [PATCH 3/8] StandaloneMmPkg/StandaloneMmCoreEntryPoint: use %a modifier for ASCII strings X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:51:12 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2019-01-04 at 12:03 +0100, Ard Biesheuvel wrote: > PE/COFF section names are ASCII strings so use %a not %s. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Supreeth Venkatesh > --- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermis > sions.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi > ssions.c > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi > ssions.c > index 60c1f66b83fa..3ca7f6660f47 100644 > --- > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi > ssions.c > +++ > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermi > ssions.c > @@ -78,7 +78,7 @@ UpdateMmFoundationPeCoffPermissions ( > "%a: Section %d of image at 0x%lx has 0x%x > permissions\n", > __FUNCTION__, Index, ImageContext->ImageAddress, > SectionHeader.Characteristics)); > DEBUG ((DEBUG_INFO, > - "%a: Section %d of image at 0x%lx has %s name\n", > + "%a: Section %d of image at 0x%lx has %a name\n", > __FUNCTION__, Index, ImageContext->ImageAddress, > SectionHeader.Name)); > DEBUG ((DEBUG_INFO, > "%a: Section %d of image at 0x%lx has 0x%x address\n",