From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Jul 2019 01:30:37 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58239882F5; Thu, 4 Jul 2019 08:30:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-165.ams2.redhat.com [10.36.117.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id A1C13176AD; Thu, 4 Jul 2019 08:30:14 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe To: "Desai, Imran" , Leif Lindholm , "devel@edk2.groups.io" Cc: "Wang, Jian J" , "Justen, Jordan L" , Ard Biesheuvel , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Berger , "Cetola, Stephano" , "Kinney, Michael D" , Andrew Fish References: <20190528204049.86463-1-imran.desai@intel.com> <20190528204049.86463-6-imran.desai@intel.com> <9c92afaf-b368-628e-f686-64257831343b@redhat.com> <20190703211802.3wieoi5imbg76v6i@bivouac.eciton.net> <688D07BB9E3A9E4A852BA1336D1910FF83FE9869@fmsmsx104.amr.corp.intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 4 Jul 2019 10:30:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <688D07BB9E3A9E4A852BA1336D1910FF83FE9869@fmsmsx104.amr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 04 Jul 2019 08:30:26 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/04/19 00:48, Desai, Imran wrote: > Hello Lersek/ Leif, > > Like Lersek hinted, this in fact was an inadvertent issue with the git configuration. > I suspect the suppresscc in my configuration may have been the source of all confusion. My apologies. That explains why the CC's didn't occur in reality. It doesn't excuse that the series was pushed. > I will send in a new version v5 of the full series of the patches. Let's wait for the revert first, please. > I appreciate all the help and comments. Thanks. > > PS: > > Being used to GitHub pull request methods where in all reviews and conversation happen on the same page i was a little thrown by this process to be honest. In any case as a first time contributor this was a hard way to find out. Perhaps it could be helpful to update the https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process. Particularly the line "git send-email *.patch" could use further commentary regarding CC list. https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers In particular, the permanent git config given there does not include "sendemail.suppresscc" at all, and contributor step#24 suggests, git send-email \ --suppress-cc=author \ --suppress-cc=self \ --suppress-cc=cc \ --suppress-cc=sob \ *.patch Note that "bodycc" is specifically absent from this option list. That's deliberate. Also, now we have a script that automates most if not all of the permanent git settings, for one's edk2 clone: "BaseTools/Scripts/SetupGit.py". Thanks Laszlo