From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ECF84941598 for ; Mon, 13 Nov 2023 13:42:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Y2YTELAHZcAHDaQAV+DBIR02zlSEC+bpXmp+6r1t5D0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699882927; v=1; b=iLj7tmyzskwPMoCpI1WIo9pMmEF+rOYL3n5kmcAMg3vCMagrOgY3/5KQa/SAvAISBgYUgHii F6F+gkpTyFRqRVPtq9ST048AxFbhOtIVuqEbYrzoPi96gxoZrUgnrKpdHwD0pWh9xPhiUTaQwHr rw0yVQjNrbMjFF/C+KoyexdM= X-Received: by 127.0.0.2 with SMTP id vsOIYY7687511xcwSdYTb8VN; Mon, 13 Nov 2023 05:42:07 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.36745.1699882926870875814 for ; Mon, 13 Nov 2023 05:42:07 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-S2phEDHMOkujlB1NQlFn4A-1; Mon, 13 Nov 2023 08:42:04 -0500 X-MC-Unique: S2phEDHMOkujlB1NQlFn4A-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 77B348870E0; Mon, 13 Nov 2023 13:42:04 +0000 (UTC) X-Received: from [10.39.192.220] (unknown [10.39.192.220]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0EFA51121306; Mon, 13 Nov 2023 13:42:03 +0000 (UTC) Message-ID: Date: Mon, 13 Nov 2023 14:42:02 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] CodeQL Analysis in edk2 From: "Laszlo Ersek" To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <7c8e4787-74e4-f144-123f-9d44d094ce86@redhat.com> In-Reply-To: <7c8e4787-74e4-f144-123f-9d44d094ce86@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tOLDdW7lVYmucN3cybEjUxGlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iLj7tmyz; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io sorry, unfinished thought: On 11/13/23 14:39, Laszlo Ersek wrote: > - the "sarif emacs" output seems a bit broken, actually, so it's not usab= le. Consider the following entry from the original JSON file: >=20 > }, { > "ruleId" : "cpp/missing-null-test", > "ruleIndex" : 0, > "rule" : { > "id" : "cpp/missing-null-test", > "index" : 0 > }, > "message" : { > "text" : "Value may be null; it should be checked before derefere= ncing." > }, > "locations" : [ { > "physicalLocation" : { > "artifactLocation" : { > "uri" : "MdeModulePkg/Application/UiApp/FrontPageCustomizedUi= Support.c", > "uriBaseId" : "%SRCROOT%", > "index" : 0 > }, > "region" : { > "startLine" : 355, > "startColumn" : 48, > "endColumn" : 52 > } > } > } ], > "partialFingerprints" : { > "primaryLocationLineHash" : "f374f6e6dfc92010:1", > "primaryLocationStartColumnFingerprint" : "43" > } > }, { >=20 > In the "emacs" output, it appears as: >=20 > -------- > ModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c:355: cpp/missi= ng-null-test Value may be null; it should be checked before dereferencing. > -------- >=20 > Note that the first three characters, "Mde" of "Mde" are lost. I meant '"Mde" of "ModulePkg"'. >=20 > This issue (first three chars cut) affects all other pathnames in the ema= cs output too. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111154): https://edk2.groups.io/g/devel/message/111154 Mute This Topic: https://groups.io/mt/102444916/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-