From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.47]) by mx.groups.io with SMTP id smtpd.web09.238.1652117382606069926 for ; Mon, 09 May 2022 10:29:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Xb+g3of5; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.47, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D8CVk0xdv1pYKfMRnSo0M7j5cpPrL8WYvGu7usfvRnbwRncIIUOZmc7WBCGSuKhvLK8A3+rs+rc1XSIzBi1AEvOtm/M15mtVPk+Hsr2SihAzUBfF4ZRg2pQJsmWdQQcegOKevLFuGaCJ9GmtFAsLTtZx1C5DY4c2ACSGP4xTYhEi07c5ACQ30iEXvXqz2Lu2gI33Wm3V7wZGqizfwW7sAKz+Sax4IdU9gnw+8bHR4HlVFCGLPGdJKDVbXk2vBfehwV8+eALxfeQPkOrL2S1ksvw/SbcuPvD3ZEGijXkl2QiHCPz+fGZ3xaJDXlMhSleXFEDeHBKvWRQqKkAH3g/HtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=64Kpd8Pqjev/svyCLzlpPUz9NcGE6OxF6rn3K8+/Z6A=; b=Sh32e4fCelktGrrv2Xvy90KtZCstIiMJBkXTcAXp+6fWf/bI5igRKrEp3qW4iTwkoTx244MpmNwWX+gE6Akw0elwJHqP47Kp6Rgtbi9DA9btshmWbYA+dmb+Tz0zPeB6zsvZhGhJX1dVw0ATGFSFjmar7pKyNBj661PsW0ZuJR1OyuJkkjVdgxk1dWfnS4+8BdPPyWDMmPdpg7UBa+NE7V75PPktOjUmR58kplex1LjnZCZAZSckyux23njF9IudXMgjQ7FckOlNZeve8LD/qBXfT1RR3Mh0lVKtxovqpcI1AiFe2vDNPr2FlZnY2xFCxyAR5ggcDoiVcWAqwtvXBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=64Kpd8Pqjev/svyCLzlpPUz9NcGE6OxF6rn3K8+/Z6A=; b=Xb+g3of5x65NPoutyM7oJjGd8fcVKvEj7L16ETlpXvvvENqZhFzSCxpHew05UOvI6QFb/cN9+4hVrMbuJNwUzKvxzINC2nmBvf3zDIbOx34lC1szrmOX7P5Rav7o9mQHSa+2EnRzK9x/Nb6EgWQHgJD8yXxzJkbSjq5sQ8Kghds= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DM6PR12MB3595.namprd12.prod.outlook.com (2603:10b6:5:118::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 17:29:36 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a%4]) with mapi id 15.20.5227.023; Mon, 9 May 2022 17:29:36 +0000 Message-ID: Date: Mon, 9 May 2022 12:29:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image To: "Xu, Min M" , "devel@edk2.groups.io" Cc: "Dong, Eric" , "Ni, Ray" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Gerd Hoffmann References: From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: SN4PR0501CA0010.namprd05.prod.outlook.com (2603:10b6:803:40::23) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ee98cb1-3d80-4492-3a4c-08da31e17d45 X-MS-TrafficTypeDiagnostic: DM6PR12MB3595:EE_ X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ShQ0yuXAAoc/nzYRTHxiiST2dxTX2tDJUnf50SXoUlPxuZHajaGMpCcuZ/C8o7V39TqJH7LVZEH+2GILot/37JVkC82OkooTnY3UrAywSspYm4FPjuazo0IYAbTZfIFJNryP8aK7G00VvZZ/TU6cHFCthChCbEAUCUzfpKqzdKOKQhL4cSeYFWk4edUhX7Xtj/Q74oms7lofLMNtPNwLglg0wZAvclrg7rwYKd1kYGiHg8GuE/8T5hQdDELbl4MeHTaU9FrUQ0ty55rfkRatnV6P3DgrpV6r0n6h/yXuPBfsWqeiDrYGW8XXlZ6xpdq7GUVzhbBWo0LIjLNxYxXvIgUnFwPO6wvhFCctqtej/rF1b7pQxoPNTOZGcNMQ/vvjNmK+gcGVSwZWEBSWzoLASsPKbcB7WV8g9VJ30a2RM7YWyk506yv/mLV+Hq9RnU6plWcU1HM143U70elx2AejRGz54zOpgzw+7mBmuwckB5Eey1Yv2lOPDMkViFcttslY3iB69jKxS8JF/UD0S+DDhZ0+K3eQHs98jJL21rms0uf4D9OqfVD4DIncX4Lqrsskt2vsEIP+ZnVdVJDAE7rtzVqp2FZ3rb4rMvUJflg8dtkDR6o8E1F2kiwxM/hfdfjMJLR0VeeXZd4RYveSm14z3PpkAOkcRr5+TVqzdmo/qLrXmjZviHSX4DgUNqyLIOJVt2qLDZeJ8rEuWRlBv0yVuObt7PHy6EEec0ilIdZMgTnLDn5J9TNa+He/UIpYWq1HZrckbtvudGVpRaj718MHCsdeiC6342aaPIoY+7LcZvzVynu+LCu0bIO9GzCsJrN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(4636009)(366004)(966005)(31696002)(86362001)(53546011)(6486002)(508600001)(38100700002)(6506007)(8936002)(83380400001)(26005)(186003)(2616005)(6512007)(36756003)(5660300002)(54906003)(110136005)(19627235002)(2906002)(316002)(4326008)(66476007)(66556008)(8676002)(66946007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk04N1lDZlNVQWt3NnV2bjhvYnhyVUFqNnVvU1p1dUlxU0xlbzJyTFRScDJL?= =?utf-8?B?ZnEwM2tPOERzREhNazA1a0plOWY4UTlMdkJJbGJxTURzV2NPaHRaSHZ5MUU4?= =?utf-8?B?Wjl5QW5iNHFZcnY1NmhoYXdpK3RtUk90VDczNFpiRVMzMk9GbWg5T1Q4dUtV?= =?utf-8?B?elZPbkt5UURSbSt2NWlPU1dkdy92blN3VThGa3JIZWxKTDNaVG50MEJYS2hy?= =?utf-8?B?RytyaVhJWXpwSzhHMGtvWC9kdGszTWRTZllUSElGK1lwYVlhRmFGY1hIa1BG?= =?utf-8?B?TkZwcWVhcXYzZExxZnhHa2JjS0FLQkMzdUk5VEF0cnFramVwcUNWdjdRL2xF?= =?utf-8?B?MWdwbysrMnhNSkd5YTRzdmlaWk1JYjljMU0rMGZxcVI1dXlpbnkrY0xXVFdz?= =?utf-8?B?SUlwdkwxZ2dXLzFVcEpuVDhQZnJDa3JXU1JZQUY2N2tCMUxOV2FROWtxMlFB?= =?utf-8?B?Zm1pSUN0S2x6a3FpbnJaQ1BKci9hTHhzS1VNOFh4KzBtTFk4QXByVmFJaTU3?= =?utf-8?B?T1lOWnhzRzBqalZ6QnpPSFhIcGlReUFMeVp2a2dPbFZUTTRpUFladkhQSUdF?= =?utf-8?B?a2hyZ0IxRWJQQmlKV0djVndMMGZTK0dKNDVyMVBZS0N4dkhMaERNV0xUWUFp?= =?utf-8?B?UTFXWUxGa3U1YmZTaEF1YUNvRk5oZmxLUEJTZ2tjWWhUaXYrblArYkdadzUz?= =?utf-8?B?THR4clJtRVNhTjk1T2lDdlJSNTA3SVVBbXoxa3h2UEdTMzM1NUI0RmJxemxk?= =?utf-8?B?eG5FdVVDNGdPWVVPKzAwNElodXR3aWVWTEY2Skw5VVZoRXVvTitoM1dmZ3ZN?= =?utf-8?B?SnRTRkhyTzFuZWRxUzJlRGpqNG11UGlqVFZIK0Y3TW9zTzJnakxpRHUyUjFC?= =?utf-8?B?dHZMeHc1Qk5Ea21va2ZIeno5ZE10SVN1UHNadGdhcnNJWDM3b2I4S3ZYTDdD?= =?utf-8?B?LzFpOTJBVGtaL0ZUOGgrOWpVTGhqa3FlS3Fxc0kyV21yWTN0T0QxQStmL3BJ?= =?utf-8?B?d1Vhb21sVzlHeU1YbUViSTNScDFGdGVOZnhIU1lkaEhaa1hWZ2I4UWtlZU9v?= =?utf-8?B?cjk3Tmh1QnBhM2VpZTQyU1BEc1pUQktrWnc5YzA0K0tvdmpLTGN2UVVYZWpq?= =?utf-8?B?bFAvb2N3R2E1dGQ3MGk1Q0ZPZ2JEZUt6Y0NDRGk3Nk1EeVBFaGk0dWtwaEZ2?= =?utf-8?B?d0Nna1cyOVNVSjBHNmkyNVo2WEtYTkgrUDJ6TENBb1hnNEVRbFNRNm81czJk?= =?utf-8?B?aUNIRUF5VHJDV3Ftd2hjK08zMkc5TitGSGpTQlJUNm54YkJSZ29reVpwOHZl?= =?utf-8?B?Z2ZZUGlyanJKTTlxY0dJZVhDb1RLaW81eE1SM0ZzdUMyblZ2SnMvVVhLY3V3?= =?utf-8?B?TThrMHFZZ0JWbDFIMkJWaEtqdzBkUW5wVG1NTDN3K0dmZlU0SmliRzBvWDYv?= =?utf-8?B?Q25IOHdmY1hBd1g2K2NHUXFacGRHRTdsYVBpTG5uTmRSKzlnRFhOdG1zR2NJ?= =?utf-8?B?UFpjSVJzcjVrYVUvTUlkeW9iQmwzY003VkZzWmpBYkNNb0ZsbEQya3BJempJ?= =?utf-8?B?YkJaU012M3kxcituL202R1VGb3lPellDRXlJS1RMZ204a29tbEFuV091aUMv?= =?utf-8?B?d1BFT1hua2VPOXEyTTVlLzRSd1ZZMDRXa0pHekVhWWtXZTFkei8rVHVrbCtW?= =?utf-8?B?dEJKRndMME90a0kvaWtUOEZlS3h0dGUwR0xOY3lwTThmSklsem5UdkI0RWxt?= =?utf-8?B?RTA4M3BHZFBuSEsrZkFWZUdOTWl0TlU1UTZRaEtLZWRPQnRtVFdrMkYxcUh1?= =?utf-8?B?a3J5cUwyMEE2dEsrNTVnOU8wbFljWFl4VmlzcXNvOHVxL1dVRnIxekRVUXor?= =?utf-8?B?ZFZsMUFjanpFcERBamVLUXFVZ2ZnK1dTWmlqc3FId2ZqMHNwWElkTVNEUExW?= =?utf-8?B?KzZsMGxZZUtuc3l0ZW9abmFUQzhpUjkyZGhDL3pmRnRBWm5wcFd2anZGMDBq?= =?utf-8?B?UlhtcXpSQ0NKVXo2Z1JzMjAycmE1eTAyMjlQM1YybURQVXA0N1Q4STZoOVRN?= =?utf-8?B?OTREZGlrVlpnL3l4S0s5NEJ4dFBoaEQ4QjJqZ2x1UjBHSXMvVGV1enZlOEtJ?= =?utf-8?B?d2FlcVNSR2ZHVVZleW9NekpIK2ExZFV0SEFYRDg3ZmVJQWdnWWp0YmhTdWly?= =?utf-8?B?aG1yRVptczRZcTA1eGVYbVArV2dmQlZwNGdGeDc3dWdYbE53WHI5SEdkSVpL?= =?utf-8?B?eHJiNHVjQ3lHQ3REdkZrOXdPb0FuVHdvUHFlR2FmbVFUS0k2djNUTWdDZnc5?= =?utf-8?B?cE5KaS9uTFFOME1MTHQ4Ylp1YVM3N1poTTZrRFlxSkNLMnhBa0VQUT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ee98cb1-3d80-4492-3a4c-08da31e17d45 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 17:29:36.7156 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OwY8SwMtniMWe0RF4MNV+qrKLnJCp10SJoU3TBF2jRBCfQprmKIdjDFdVcOOYZD603hiWgMvPIlUpu28AUastQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3595 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/9/22 07:44, Xu, Min M wrote: > Gerd & Tom > What are your comments about this patch-set? Hi Min, This appears to resolve the issue. I was able to boot a 64 vCPU guest in legacy, SEV, SEV-ES and SEV-SNP modes without any asserts. I'm assuming that you were able to see the ASSERTs on your end and validate, too? Thanks, Tom > >> -----Original Message----- >> From: Xu, Min M >> Sent: Saturday, May 7, 2022 9:36 AM >> To: devel@edk2.groups.io >> Cc: Xu, Min M ; Dong, Eric ; Ni, >> Ray ; Brijesh Singh ; Aktas, >> Erdem ; James Bottomley ; >> Yao, Jiewen ; Tom Lendacky >> ; Gerd Hoffmann >> Subject: [PATCH V2 0/6] Support 2 CpuMpPei/CpuDxe in One image >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 >> >> Above BZ reports an issue that commit 88da06ca triggers ASSERT in some >> scenario. This patch-set is to fix this issue. >> >> As commit 88da06ca describes TDVF BSP and APs are simplied and it can >> simply use MpInitLibUp instead of MpInitLib. To achieve this goal, we >> include 2 CpuMpPei/CpuDxe drivers in OvmfPkgX64 and IntelTdxX64. This is >> done by setting different FILE_GUID to these drivers (of the same name). In >> the other hand, we import a set of MpInitLibDepLib. These libs simply >> depend on the PPI/Protocols. While these PPI/Protocols are installed >> according to the guest type. >> >> This patch-set is a replacement of >> https://edk2.groups.io/g/devel/message/89381 >> - https://edk2.groups.io/g/devel/message/89382 >> - https://edk2.groups.io/g/devel/message/89455 >> - https://edk2.groups.io/g/devel/message/89522 >> - https://edk2.groups.io/g/devel/message/89535 >> >> The code is at: https://github.com/mxu9/edk2/tree/Rework-MpInitLib.v2 >> >> v2 changes: >> - Remove the un-used FILE_GUID definitions. >> - Delete un-used EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST in >> DispatchTable. >> - Add more comments. >> >> Cc: Eric Dong >> Cc: Ray Ni >> Cc: Brijesh Singh >> Cc: Erdem Aktas >> Cc: James Bottomley >> Cc: Jiewen Yao >> Cc: Tom Lendacky >> Cc: Gerd Hoffmann >> Signed-off-by: Min Xu >> >> Min M Xu (4): >> UefiCpuPkg: Revert "UefiCpuPkg: Enable Tdx support in MpInitLib" >> OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c >> OvmfPkg/TdxDxe: Install MpInitLibDepLib protocols >> OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers >> >> Min Xu (2): >> OvmfPkg: Add MpInitLibDepLib related PPI/Protocol definitions >> OvmfPkg: Add MpInitLibDepLib >> >> OvmfPkg/Include/Ppi/MpInitLibDep.h | 28 +++++ >> .../Include/Protocol/MpInitLibDepProtocols.h | 28 +++++ >> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 30 ++++- >> OvmfPkg/IntelTdx/IntelTdxX64.fdf | 3 + >> .../MpInitLibDepLib/DxeMpInitLibMpDepLib.inf | 27 >> +++++ .../MpInitLibDepLib/DxeMpInitLibUpDepLib.inf | 27 >> +++++ .../Library/MpInitLibDepLib/MpInitLibDepLib.c | 23 >> ++++ .../MpInitLibDepLib/PeiMpInitLibMpDepLib.inf | 27 >> +++++ .../MpInitLibDepLib/PeiMpInitLibUpDepLib.inf | 27 +++++ >> OvmfPkg/OvmfPkg.dec | 5 + >> OvmfPkg/OvmfPkgX64.dsc | 55 ++++++++- >> OvmfPkg/OvmfPkgX64.fdf | 4 + >> OvmfPkg/Sec/SecMain.c | 34 +++++- >> OvmfPkg/Sec/SecMain.inf | 2 + >> OvmfPkg/TdxDxe/TdxDxe.c | 22 +++- >> OvmfPkg/TdxDxe/TdxDxe.inf | 2 + >> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 3 - >> UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h | 69 ------------ >> UefiCpuPkg/Library/MpInitLib/MpLib.c | 63 +---------- >> UefiCpuPkg/Library/MpInitLib/MpLibTdx.c | 106 ------------------ >> UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c | 69 ------------ >> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 3 - >> 22 files changed, 343 insertions(+), 314 deletions(-) create mode 100644 >> OvmfPkg/Include/Ppi/MpInitLibDep.h >> create mode 100644 OvmfPkg/Include/Protocol/MpInitLibDepProtocols.h >> create mode 100644 >> OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibMpDepLib.inf >> create mode 100644 >> OvmfPkg/Library/MpInitLibDepLib/DxeMpInitLibUpDepLib.inf >> create mode 100644 OvmfPkg/Library/MpInitLibDepLib/MpInitLibDepLib.c >> create mode 100644 >> OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibMpDepLib.inf >> create mode 100644 >> OvmfPkg/Library/MpInitLibDepLib/PeiMpInitLibUpDepLib.inf >> delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpIntelTdx.h >> delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdx.c >> delete mode 100644 UefiCpuPkg/Library/MpInitLib/MpLibTdxNull.c >> >> -- >> 2.29.2.windows.2 >