From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 16 Jul 2019 11:53:11 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 859343093382; Tue, 16 Jul 2019 18:53:10 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-187.ams2.redhat.com [10.36.117.187]) by smtp.corp.redhat.com (Postfix) with ESMTP id 12F2C5C231; Tue, 16 Jul 2019 18:53:05 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl To: devel@edk2.groups.io, philmd@redhat.com Cc: Liming Gao , =?UTF-8?Q?Marvin_H=c3=a4user?= , Michael D Kinney , Zhichao Gao References: <20190702102836.27589-1-lersek@redhat.com> <20190702102836.27589-2-lersek@redhat.com> <6dd4f56b-b7df-7986-11cf-1780981c1d0e@redhat.com> <4865d268-7867-a8c3-c1f0-2613d7667679@redhat.com> <4bea421a-43af-2c97-9885-d3266785222c@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 16 Jul 2019 20:53:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 16 Jul 2019 18:53:10 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07/16/19 16:59, Philippe Mathieu-Daud=C3=A9 wrote: > On 7/16/19 4:14 PM, Laszlo Ersek wrote: >> On 07/16/19 11:41, Philippe Mathieu-Daud=C3=A9 wrote: >>> Hi Laszlo, >>> >>> On 7/16/19 10:38 AM, Philippe Mathieu-Daud=C3=A9 wrote: >>>> On 7/2/19 12:28 PM, Laszlo Ersek wrote: >>>>> Rewrite Base64Decode() from scratch, due to reasons listed in the se= cond >>>>> reference below. >>>>> >>>>> As first step, redo the interface contract, and replace the current >>>>> implementation with a stub that asserts FALSE, then fails. >>>>> >>>>> Cc: Liming Gao >>>>> Cc: Marvin H=C3=A4user >>>>> Cc: Michael D Kinney >>>>> Cc: Philippe Mathieu-Daud=C3=A9 >>>>> Cc: Zhichao Gao >>>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1891 >>>>> Ref: http://mid.mail-archive.com/c495bd0b-ea4d-7206-8a4f-a7149760d19= a@redhat.com >>>>> Signed-off-by: Laszlo Ersek >>>>> --- >>>>> MdePkg/Include/Library/BaseLib.h | 99 +++++-- >>>>> MdePkg/Library/BaseLib/String.c | 285 ++++++-------------- >>>>> 2 files changed, 168 insertions(+), 216 deletions(-) >>> >>> You forgot to update the copyright in both files. >> >> I didn't: I never intended to. >> >> Updating or extending *existing* copyright notices is not a general edk= 2 >> requirement. Some companies insist that their associates do that, when >> they contribute patches. Red Hat doesn't (we don't extend copyright >> notices like that in QEMU either). >=20 > Oh OK, I did not know :S In retrospect, I may have mislead you, unwittingly -- perhaps you recall me pointing out the same issue to other contributors. But, in those cases, I must have raised the topic only for one of two reasons: - I had known from experience that the contributor's employer would expect an update to the (C) notice - there was an update already in the patch, but it looked incorrect (extending a (C) notice to a year different from the current year, inadvertently deleting a different (C) notice, and so on). Thanks! Laszlo > Thanks for telling me, >=20 > Phil. >=20 >=20 >=20