[PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c

[PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c

[Tomas Pilar (tpilar)]

This fixes unused const variable compilation error with gcc 7.3.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
---
 ShellPkg/Application/Shell/Shell.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index 397cfd1994..3f3bcbb4b0 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -2750,9 +2750,6 @@ RunCommand(
   return (RunShellCommand(CmdLine, NULL));
 }

-
-STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
-
 /**
   Function to process a NSH script file via SHELL_FILE_HANDLE.

--
2.17.1

The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.

Re: [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Tomas Pilar (tpilar)
> Sent: Wednesday, September 26, 2018 3:16 AM
> To: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> Subject: [edk2] [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in
> Shell.c
> Importance: High
> 
> This fixes unused const variable compilation error with gcc 7.3.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
> ---
>  ShellPkg/Application/Shell/Shell.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index 397cfd1994..3f3bcbb4b0 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -2750,9 +2750,6 @@ RunCommand(
>    return (RunShellCommand(CmdLine, NULL));
>  }
> 
> -
> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"',
> 0x0001, 0x0002};
> -
>  /**
>    Function to process a NSH script file via SHELL_FILE_HANDLE.
> 
> --
> 2.17.1
> 
> The information contained in this message is confidential and is intended for
> the addressee(s) only. If you have received this message in error, please
> notify the sender immediately and delete the message. Unless you are an
> addressee (or authorized to receive for an addressee), you may not use,
> copy or disclose to anyone this message or any information contained in this
> message. The unauthorized use, disclosure, copying or alteration of this
> message is strictly prohibited.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH v2] ShellPkg: Remove unused InvalidCharacters[] in Shell.c

[Ni, Ruiyu]

On 9/26/2018 6:15 PM, Tomas Pilar (tpilar) wrote:
> This fixes unused const variable compilation error with gcc 7.3.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
> ---
>   ShellPkg/Application/Shell/Shell.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
> index 397cfd1994..3f3bcbb4b0 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -2750,9 +2750,6 @@ RunCommand(
>     return (RunShellCommand(CmdLine, NULL));
>   }
> 
> -
> -STATIC CONST UINT16 InvalidChars[] = {L'*', L'?', L'<', L'>', L'\\', L'/', L'\"', 0x0001, 0x0002};
> -
>   /**
>     Function to process a NSH script file via SHELL_FILE_HANDLE.
> 
> --
> 2.17.1
> 
> The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray