* [PATCH] CorebootPayloadPkg: don't use serial output for Release build
@ 2018-10-15 22:44 Wonkyu Kim
2018-10-16 0:13 ` Ma, Maurice
2018-10-17 2:45 ` You, Benjamin
0 siblings, 2 replies; 3+ messages in thread
From: Wonkyu Kim @ 2018-10-15 22:44 UTC (permalink / raw)
To: edk2-devel
Cc: benjamin.you, prince.agyeman, gaumless, stefan.reinauer,
hannah.williams, wonkyu.kim, lijian.zhao
From: Wonkyu Kim <wonkyu.kim@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wonkyu Kim <wonkyu.kim@intel.com>
---
CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 4 ++++
CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
index b6cdb697a5b0..7d5052be9301 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
@@ -263,7 +263,11 @@
#
################################################################################
[PcdsFeatureFlag]
+!if $(TARGET) == DEBUG
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
+!else
+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
+!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
index c3fe099e5fec..0484e941cce7 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
@@ -263,7 +263,11 @@
#
################################################################################
[PcdsFeatureFlag]
+!if $(TARGET) == DEBUG
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
+!else
+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
+!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] CorebootPayloadPkg: don't use serial output for Release build
2018-10-15 22:44 [PATCH] CorebootPayloadPkg: don't use serial output for Release build Wonkyu Kim
@ 2018-10-16 0:13 ` Ma, Maurice
2018-10-17 2:45 ` You, Benjamin
1 sibling, 0 replies; 3+ messages in thread
From: Ma, Maurice @ 2018-10-16 0:13 UTC (permalink / raw)
To: Wonkyu Kim, edk2-devel@lists.01.org
Cc: Williams, Hannah, gaumless@gmail.com, Zhao, Lijian, Kim, Wonkyu,
stefan.reinauer@coreboot.org, Agyeman, Prince
Hi, Kim,
Looks good to me.
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
-Maurice
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wonkyu Kim
Sent: Monday, October 15, 2018 15:45
To: edk2-devel@lists.01.org
Cc: Williams, Hannah <hannah.williams@intel.com>; gaumless@gmail.com; Zhao, Lijian <lijian.zhao@intel.com>; Kim, Wonkyu <wonkyu.kim@intel.com>; stefan.reinauer@coreboot.org; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2] [PATCH] CorebootPayloadPkg: don't use serial output for Release build
From: Wonkyu Kim <wonkyu.kim@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wonkyu Kim <wonkyu.kim@intel.com>
---
CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 4 ++++
CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
index b6cdb697a5b0..7d5052be9301 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
@@ -263,7 +263,11 @@
#
################################################################################
[PcdsFeatureFlag]
+!if $(TARGET) == DEBUG
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
+!else
+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
+!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
index c3fe099e5fec..0484e941cce7 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
@@ -263,7 +263,11 @@
#
################################################################################
[PcdsFeatureFlag]
+!if $(TARGET) == DEBUG
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
+!else
+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
+!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
--
2.17.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] CorebootPayloadPkg: don't use serial output for Release build
2018-10-15 22:44 [PATCH] CorebootPayloadPkg: don't use serial output for Release build Wonkyu Kim
2018-10-16 0:13 ` Ma, Maurice
@ 2018-10-17 2:45 ` You, Benjamin
1 sibling, 0 replies; 3+ messages in thread
From: You, Benjamin @ 2018-10-17 2:45 UTC (permalink / raw)
To: Wonkyu Kim, edk2-devel@lists.01.org
Cc: Agyeman, Prince, gaumless@gmail.com, stefan.reinauer@coreboot.org,
Williams, Hannah, Kim, Wonkyu, Zhao, Lijian
Hi,
Reviewed-by: Benjamin You <benjamin.you@intel.com>
Thanks,
- ben
> -----Original Message-----
> From: Wonkyu Kim [mailto:norwayforest92@gmail.com]
> Sent: Tuesday, October 16, 2018 6:45 AM
> To: edk2-devel@lists.01.org
> Cc: You, Benjamin <benjamin.you@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; gaumless@gmail.com;
> stefan.reinauer@coreboot.org; Williams, Hannah <hannah.williams@intel.com>;
> Kim, Wonkyu <wonkyu.kim@intel.com>; Zhao, Lijian <lijian.zhao@intel.com>
> Subject: [PATCH] CorebootPayloadPkg: don't use serial output for Release build
>
> From: Wonkyu Kim <wonkyu.kim@intel.com>
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wonkyu Kim <wonkyu.kim@intel.com>
> ---
> CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 4 ++++
> CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> index b6cdb697a5b0..7d5052be9301 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> @@ -263,7 +263,11 @@
> #
>
> #################################################################
> ###############
> [PcdsFeatureFlag]
> +!if $(TARGET) == DEBUG
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> +!else
> + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> +!endif
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> index c3fe099e5fec..0484e941cce7 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> @@ -263,7 +263,11 @@
> #
>
> #################################################################
> ###############
> [PcdsFeatureFlag]
> +!if $(TARGET) == DEBUG
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> +!else
> + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> +!endif
> gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-17 2:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-15 22:44 [PATCH] CorebootPayloadPkg: don't use serial output for Release build Wonkyu Kim
2018-10-16 0:13 ` Ma, Maurice
2018-10-17 2:45 ` You, Benjamin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox