From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.54]) by mx.groups.io with SMTP id smtpd.web09.1568.1652132395024083664 for ; Mon, 09 May 2022 14:39:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=yALRg4Of; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.54, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KUzsFEI4/xC5xRGjsAb1onqqx8iThNVgs/0XWKs2VBco8RhdLP90dakDyQcy0/+kuwMFPWjdnI6OltjXDdTu+Kxx8buenPIQ8c7CFrM8A3pRZaTGtOhZYdjqPgQiPxmN02I8qejbb6kOskw6AUExfR0txNIWgb/fxUvXmpzmILgsjP50HH5alejeN9L1vs0KkbWbQGwh9l1aQwK8hU/tydR5rnmz5u3cxbkrNUPLhuzvszIPT1jgpysQK8jxg73+9jlDft1guoaK2JRbroxc9qB9UmhlV9GpJCqjBbpklGe2/th6Uw5Dx8ijAk31lMpnB0NYqcRooSNNzb1cvOk0Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lR36LHjQS+eyZ3R48TEAUeVQWyQ7GkfGMhqK1upPLiA=; b=BpzdhufJ/Y+BD9HcyRR9ngBlAwdjySJ/MmkIt7+eMzxmBnM/HSClVmm6saxkZ5tooEJoWlrgJ5OY/vss6UTa6Edgo70IvQtxDgvAjtCDILVnBsbnjE98kaz9AAH44mzMuLeb27DIAnmbg4xXt8MDesdcC8BwtvT92y9sxBDbGHuPWLzInU9lC+yuPsioseNYDi+tDkJf59uUJzkScwfs4puZmKv4jlRxViYf23/TQpKO6XcQ6uZ2eU18k7Aq/Y3Psd03ISfRCBSkuJmgzI308tUeChuO6zH8kwiM1sz2ryUuzdXtMngdFQ/oq0U8AbF2r6pxOAhgW8q8U6tnCsTQ6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lR36LHjQS+eyZ3R48TEAUeVQWyQ7GkfGMhqK1upPLiA=; b=yALRg4Of7hyoLvnqXzHpJJxMYVjpnBF1fLmaGj42rBnBh/GkARKJX421g9zF8gl/D2Ei1zU6rMmqKwRDeg/Zt0n7gl0mICJ8tC0BJmt5ndQaeqveNB/riNrwlMBpC5CdiQBbH4ye8XLgyPNGHHoKn4SXfbMu7O9msoiezzbLUw4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by CY4PR12MB1623.namprd12.prod.outlook.com (2603:10b6:910:6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Mon, 9 May 2022 21:39:53 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::db8:5b23:acf0:6f9a%4]) with mapi id 15.20.5227.023; Mon, 9 May 2022 21:39:53 +0000 Message-ID: Date: Mon, 9 May 2022 16:39:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [edk2-devel] [PATCH 0/4] Refactor MpInitLib To: devel@edk2.groups.io, ray.ni@intel.com References: <20220507151313.115-1-ray.ni@intel.com> From: "Lendacky, Thomas" In-Reply-To: <20220507151313.115-1-ray.ni@intel.com> X-ClientProxiedBy: SN7P222CA0029.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:124::23) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a103d55-8596-4a12-439b-08da3204739d X-MS-TrafficTypeDiagnostic: CY4PR12MB1623:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VTw/80n9jQKEe5mOfz9a/4XECnWcYztMzvZA6OfKExriAGDXTV9uV1PcVSpM/+RuU2+h3uloUSFm68rirKT/VtSmsTOyvS2802QhDYOmsLo21CKJilp++v30XLgLzp9yCN23H0oewXItHwy2aDJOLbB8K4fLFEuyx6IzBc9wTxQz/Z/EouUZI5zZ4s+TAHNEaRqyus8OOJq/+Djuc1q9L0Xz6dAkJ/fv2g8+tLZMqz0ZRWT9Bb54xsnSVZC/Y/nix4me3B9FvGpEpg0vYIzNANZCzk9p164bBGsm3l12hizDt4pP/3pYM8JUbqJOjbZPp/QDfVkzA3FLqTUbhpJmBm5aX9zExEjxHoqywWyPxAOR3nOy4fTqYrYQ8bq/8HtmL91uCMNnn43FpThTrNC7HMUVGwp80UDV+mNiVR203gDAYAAJW20mXKOwPowvj7/d/EYgRhFQELIMJ5v+fYP6/cgpQoiuGeT8w1N57VzI4IRjsFf5D4ZVt7+bsI0juZ9R495/AnHZRMJYhjvlbIw9dxFg4BSa6gqgz7UlHMo2k7o57OLWozJk1zMou7m8AlN9ALBrSsdkdrxtRJNa2TuRCvhVd9QzHGGzESCxAmmwZ2lZJo6/Og0RxU7ZFNyH38ecVhRfTWjYD0OvtH0kW10fmUJaikjRw16S/BbTQZOKHYVSyW+sc8Eux/clS4gkU3BC3ydNWgnpJG0BT2sYBGJgOzkIS2H1F/hpNZXcYZD73XKqpsqPqfRFEwGNbcJjYgHG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(4636009)(366004)(31686004)(83380400001)(186003)(2906002)(2616005)(6512007)(4744005)(26005)(36756003)(508600001)(5660300002)(86362001)(6486002)(38100700002)(8936002)(31696002)(66946007)(66476007)(66556008)(8676002)(6506007)(53546011)(316002)(19627235002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUNCR1pKNzF3eDJwWURTN09SMEd3WmMyNkNCZUNRQ0l6UDM5aU1MS2tHRUlH?= =?utf-8?B?b3Q1a1hLS2xvRnJYZlRQMGxkeW5wVTFNVHUwRm95ZXJWR09kbi9hb0Z1a01V?= =?utf-8?B?ck5aN0lsSGd0QlZXWnNPbWZuVUt1aTRWWnBjM2VPcmlwcTVGakRaZjBEZVMx?= =?utf-8?B?ZWVTNDg0N0Y3cEVuUGQ5NUh0RXc4aTVOc2x3S1g5K1MrWU1pVkExbnZpbzBU?= =?utf-8?B?WlZ2Y1hpQjFyMjE1RGNsTEwxYTZZOGl1MW5leCtjK2dSdWwyaU91d2k3aW5D?= =?utf-8?B?S1RMU2ZkQWFueWw0MlR5aXo4NlZLdnJFZjVGVDd2ck5MMVBjb2JMcy9yUzFH?= =?utf-8?B?cTZXL0YwNmFxb01iZGNrdDN2bHJjVUIySElhcGFaK285S1hNdUphUkNoYWZr?= =?utf-8?B?aG44elNTa3MzbGFGSXV1QmtiRHZ4V3VCUWxYeWJBVy8rQXJlVEIwdnFoenJY?= =?utf-8?B?RmxjUmlhNTNKSFFwNjZ6emFHY1FJMFllUzEyVHFtNWJyQmxjK1VUZjNLVkc3?= =?utf-8?B?VWNzUU5mRExtblZYNW1pNXRiZ2gyODAvcHQzaUhmTzVWaHhjbHFUK3ZQOFQx?= =?utf-8?B?N3phNmVGVklqQTB5L1BrdEdpakw0R2JRbEZFWmFwVGM0UWdDaUpWaUg5VFJO?= =?utf-8?B?QkNic0xjaFVTd3hydWlSOXp4aG5TRkswUmx2TEVLTzRMREJoN0oyVjBlcXNw?= =?utf-8?B?SWZ5SDFQK2VuMXl1ODgyMHAvZ0FpcGJlNEwyL2FOcEcySmZ3R1BhMWlhT05M?= =?utf-8?B?bi90N011OC85WXhIWUVsblJrNjJtTGZYSE00K3I3R0YwN010S0FzZ2V3L1Vs?= =?utf-8?B?NGFPTUVSVkh2bWhBam5SbGd2cUxtL2pwVGFndU0xUDdtREEwNmF0RTVrcWEw?= =?utf-8?B?bW0yaXl4L1E2T1dmZUp1My9obW05dUFONldUVk9rQUtiMFJObVdVL1FBbHVl?= =?utf-8?B?RFg5VTRMMkVLZWl5a0Q4enZJYnBGV0k5T2ttMktUUG9PUUE4SktjWUs1elZT?= =?utf-8?B?ejVucUxmMjErMllUY0lnMmc1N1NJWUhsSkdOaGhiSkFuOVZTVm4yL3hKazhK?= =?utf-8?B?UVQyS1EzS0dHZ21RRUlOT3M4Z1NhRzQ2QkYxWDVyYis3MjJPVnE3STNWMm13?= =?utf-8?B?U1RpYXkyL3VEeW14T3B1T0RsYzllSWVhaWpGSFN1Zy96WlNjN2pnUldyYjZY?= =?utf-8?B?OEFNdm9rUUhQYlBabmdtQnJrN3k5T1Z1WHN4cmw5b1E3MS9ka0tHdzJaTFhP?= =?utf-8?B?b0ZNSCtTR283dE9rU0xMYmcvamZNOGpueFl5QUZqZ1BjbVVKQld1RzMyaVl3?= =?utf-8?B?Unk0S2NRenVMUDRTZkwwQ3VhakZNcDlhT2w2M2dMMlN6NlAzWmoxOVYzZjlF?= =?utf-8?B?WERUajY0WUpsbnJiUC9Fb1oxcDlZbXJzVzlMdWs5dzVBYkR2YVduNFV6UWJz?= =?utf-8?B?LzJqNDc3TnA5RThWTGNva3EwUElNSk9vank5OUIzUWowNmNaZS9kMXpXY0Ux?= =?utf-8?B?eU10cHU2bW1uZGdyOGRKQmhkMlFIejdyeWRzWjJQSkpEUENha1RleDUzVThF?= =?utf-8?B?TG1ocy9vbzJXWnZrWUhFTzF3RXhDMlF5NnRnQU04Rmx0UktBUG5FMEIxQUl1?= =?utf-8?B?V2huYTVCc2trQ3h5Z3BPTDREbFV0M0ZGcG9UdEdhVUhNeWNQdmZJTWFuaXVF?= =?utf-8?B?bkVDcFR1VTVrVVhERHQ4TWM2U2ZnZGNKckQweWVwR2tkUEowTVFndVJKVjha?= =?utf-8?B?Sy94Y0VaRlVJTm9QeXRSSzgrMUJJazZsU0RmL1RaSlZ4VDhnanpXemhtUXBh?= =?utf-8?B?bGtnaHhta2pWTytjeHlvaHFGbXN1eXpJSVl4aUIyV0hObmlsbVBDZENLVGZS?= =?utf-8?B?a1pXcU42Z0dwcmZGc2h2SUNHdVA5ZENpQU9sQjYwa3c1OWlHT3VrS3lOZzZt?= =?utf-8?B?L3g1QnNRanFuQXlkMjRCNHdLTVNySWlwU3NqSml3Y1lXRndqODhlZjFQaGFU?= =?utf-8?B?VmRJVWNEWlR5MzZRdEtFTFRWZytIM3RtYkVLWFR1U2NwNERBTWh1ZWV4QVRj?= =?utf-8?B?QVBhaHZ1Vk96eVA3SHNLbnIybnlSN2twcFB6V1d1LzZUUDBWZFpYYnhyTlEx?= =?utf-8?B?MEREVloyaFRxWjRQZGR0S1lKSFV5cFdQdDBNcFltRUVUNS9FdG94VHVON1Bj?= =?utf-8?B?RkwwYzhxUCtMQ0w3ZUo2cHJVbjI0ZmZGenlRWjU4NG9MZVVUUitkeU91ekpo?= =?utf-8?B?cmNWbHhjRE91bEdxb3U2aXVzb0lFYnpPSUZ4czhGOWhWYk9UWXRFbzNkRWxQ?= =?utf-8?B?WTZmQkRyeTdvL1VFKy9VY3lEd05CaTgxY3ZJVHg0NE9QajVuaVFJUT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a103d55-8596-4a12-439b-08da3204739d X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 21:39:52.9166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 59YXnHbJ/sKhb8mTjJsO/uMr2tk5Gxz8HdAZ7+//x2+UU1Nz7Vs9AOzu5E9I6pIAyDQuvqVutfwTL6/Jt+3jXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1623 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ray, Do you have a public git tree with these patches that I can use to test with? I'm having lots of problems pulling these patches out of my mail client and applying them. Thanks, Tom On 5/7/22 10:13, Ni, Ray via groups.io wrote: > > Ray Ni (4): > MpInitLib: Allocate code buffer for PEI phase > MpInitLib: remove unneeded global ASM_PFX > MpInitLib: Put SEV logic in separate file > MpInitLib: Only allocate below 1MB memory for 16bit code > > UefiCpuPkg/Library/MpInitLib/AmdSev.c | 6 +- > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +- > .../Library/MpInitLib/Ia32/MpFuncs.nasm | 11 +- > UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 2 +- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 99 +++++------ > UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 15 +- > UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm | 148 ++++++++++++++++ > UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 167 +----------------- > 9 files changed, 216 insertions(+), 236 deletions(-) >