Re: [Patch v3 2/6] UefiCpuPkg/RegisterCpuFeaturesLib.h: Add new dependence types.

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 10/18/2018 3:34 PM, Eric Dong wrote:
> v3 changes:
>    1. Move CPU_FEATURE_DEPENDENCE_TYPE definition to AcpiCpuData.h.
>    2. Add comments for CPU_FEATURE_BEFORE/CPU_FEATURE_AFTER.
> 
> v1 changes:
> Add new core/package dependence types which consumed by different MSRs.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>   UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h | 21 +++++++++++++++++----
>   1 file changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
> index 9331e49d13..e41f0dc7f6 100644
> --- a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
> +++ b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h
> @@ -73,10 +73,23 @@
>   #define CPU_FEATURE_PPIN                            (32+11)
>   #define CPU_FEATURE_PROC_TRACE                      (32+12)
>   
> -#define CPU_FEATURE_BEFORE_ALL                      BIT27
> -#define CPU_FEATURE_AFTER_ALL                       BIT28
> -#define CPU_FEATURE_BEFORE                          BIT29
> -#define CPU_FEATURE_AFTER                           BIT30
> +#define CPU_FEATURE_BEFORE_ALL                      BIT23
> +#define CPU_FEATURE_AFTER_ALL                       BIT24
> +//
> +// CPU_FEATURE_BEFORE and CPU_FEATURE_AFTER only mean Thread scope
> +// before and Thread scope after.
> +// It will be replace with CPU_FEATURE_THREAD_BEFORE and
It is replaced with ...
> +// CPU_FEATURE_THREAD_AFTER, and should not been used anymore.
....should not be used anymore.

With the comment fix, Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> +//
> +#define CPU_FEATURE_BEFORE                          BIT25
> +#define CPU_FEATURE_AFTER                           BIT26
> +
> +#define CPU_FEATURE_THREAD_BEFORE                   CPU_FEATURE_BEFORE
> +#define CPU_FEATURE_THREAD_AFTER                    CPU_FEATURE_AFTER
> +#define CPU_FEATURE_CORE_BEFORE                     BIT27
> +#define CPU_FEATURE_CORE_AFTER                      BIT28
> +#define CPU_FEATURE_PACKAGE_BEFORE                  BIT29
> +#define CPU_FEATURE_PACKAGE_AFTER                   BIT30
>   #define CPU_FEATURE_END                             MAX_UINT32
>   /// @}
>   
> 


-- 
Thanks,
Ray