From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E66021163272 for ; Thu, 18 Oct 2018 01:06:59 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2018 01:06:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,395,1534834800"; d="scan'208";a="98454445" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by fmsmga004.fm.intel.com with ESMTP; 18 Oct 2018 01:06:57 -0700 To: Eric Dong , edk2-devel@lists.01.org Cc: Laszlo Ersek References: <20181018073448.11496-1-eric.dong@intel.com> <20181018073448.11496-3-eric.dong@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Thu, 18 Oct 2018 16:08:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181018073448.11496-3-eric.dong@intel.com> Subject: Re: [Patch v3 2/6] UefiCpuPkg/RegisterCpuFeaturesLib.h: Add new dependence types. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 08:06:59 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/18/2018 3:34 PM, Eric Dong wrote: > v3 changes: > 1. Move CPU_FEATURE_DEPENDENCE_TYPE definition to AcpiCpuData.h. > 2. Add comments for CPU_FEATURE_BEFORE/CPU_FEATURE_AFTER. > > v1 changes: > Add new core/package dependence types which consumed by different MSRs. > > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h | 21 +++++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > index 9331e49d13..e41f0dc7f6 100644 > --- a/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > +++ b/UefiCpuPkg/Include/Library/RegisterCpuFeaturesLib.h > @@ -73,10 +73,23 @@ > #define CPU_FEATURE_PPIN (32+11) > #define CPU_FEATURE_PROC_TRACE (32+12) > > -#define CPU_FEATURE_BEFORE_ALL BIT27 > -#define CPU_FEATURE_AFTER_ALL BIT28 > -#define CPU_FEATURE_BEFORE BIT29 > -#define CPU_FEATURE_AFTER BIT30 > +#define CPU_FEATURE_BEFORE_ALL BIT23 > +#define CPU_FEATURE_AFTER_ALL BIT24 > +// > +// CPU_FEATURE_BEFORE and CPU_FEATURE_AFTER only mean Thread scope > +// before and Thread scope after. > +// It will be replace with CPU_FEATURE_THREAD_BEFORE and It is replaced with ... > +// CPU_FEATURE_THREAD_AFTER, and should not been used anymore. ....should not be used anymore. With the comment fix, Reviewed-by: Ruiyu Ni > +// > +#define CPU_FEATURE_BEFORE BIT25 > +#define CPU_FEATURE_AFTER BIT26 > + > +#define CPU_FEATURE_THREAD_BEFORE CPU_FEATURE_BEFORE > +#define CPU_FEATURE_THREAD_AFTER CPU_FEATURE_AFTER > +#define CPU_FEATURE_CORE_BEFORE BIT27 > +#define CPU_FEATURE_CORE_AFTER BIT28 > +#define CPU_FEATURE_PACKAGE_BEFORE BIT29 > +#define CPU_FEATURE_PACKAGE_AFTER BIT30 > #define CPU_FEATURE_END MAX_UINT32 > /// @} > > -- Thanks, Ray