From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.122]) by mx.groups.io with SMTP id smtpd.web10.17012.1680065352815931648 for ; Tue, 28 Mar 2023 21:49:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=JEnOt/R8; spf=pass (domain: os.amperecomputing.com, ip: 40.107.92.122, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IBR7qClQ9d9IenWXH13liZprHKCoUT03DxgwnSwNeB6FP2SpIpFQyDI+0SL7qgnWr+w9pKa41KJ7taw4rdV+33TO4yKsGlyL47Z4cLrCt9aScp0jTtWttrUlv1jZW85vFUpJP9QhmJXlYuqR9d5EwVgylHLtx5WSrXypNI7DGUwx/twDXE2+X0CdayBU4Am4l8FhNsbPw4oZLKLYdIpcVGYXk4leroA6uwNoYHHcFPwQ+cBMe4hACec5KKUGnTIeZG9u06n5Rwy+FL4MWY3iZEL7JOOFzqx2fO/3T18aGlC4ms5baquRvW100CtfeVK0mbtIxa6ozqYFcOu4xy8IEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b8ogcXNJ5NS/idTNTOQKZiJtFxcy2TvE1P1LE1XG7zg=; b=ZUTAjpPbtngHl8ONZ3KAu2KI5gaD6TSONohaJvYuRhZifGxoCMeo6ZEHw/z3V5A/vTUubni5cSjC4g2RPZeEs09h7lyZHucoIPtTPNm7J60mILXnrqtl9ZnJ3hpuQ3CRAP//R5pL49HvoWYw5Sep3ShDkavQMq7QNkw7NiwquHDADSYRwNLVCehZscebntm1zI522XulVEwAp3E/Uto54i7winh84dJxJ3NkYYZzgkJD8cFxT9MXYSNuOiEFyTpFddHHZIZImVYXxJZRN8qWtg9rJolXpK/reDRc0WuZfnN8//QmkM36+LcQbjn354YOlQpuN8PfB3uEUVdWhLk3sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b8ogcXNJ5NS/idTNTOQKZiJtFxcy2TvE1P1LE1XG7zg=; b=JEnOt/R8BzwHXyJEMjf5ZqJTsNX2zbb8aqKB2heeVc0bBhQNBC2sKzDYQf9WElMsQa6K0Aps8XcxO3dhQYgrcpFcZLGU9Krf1T0l9SUwNq943zDPgEtO8B/Yr4jM90OpXF6Mn8qV4Qp2ytwkiZRi8iz0xtnTu3W/yTM5XHsatLc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by BN6PR01MB2433.prod.exchangelabs.com (2603:10b6:404:5d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.16; Wed, 29 Mar 2023 04:49:09 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::4904:fc7d:35e6:f99]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::4904:fc7d:35e6:f99%5]) with mapi id 15.20.6254.015; Wed, 29 Mar 2023 04:49:09 +0000 Message-ID: Date: Wed, 29 Mar 2023 11:49:01 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-platforms][PATCH 0/2] Support Ampere Altra Max processor To: quic_llindhol@quicinc.com Cc: devel@edk2.groups.io, patches@amperecomputing.com, ardb+tianocore@kernel.org, Nhi Pham References: <20230113042517.3107802-1-nhi@os.amperecomputing.com> From: "Nhi Pham" In-Reply-To: <20230113042517.3107802-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2PR01CA0001.apcprd01.prod.exchangelabs.com (2603:1096:4:191::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|BN6PR01MB2433:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e0727e2-efd2-41d1-2765-08db3010ef24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SOs8YqGdJci6yEhNm5U3BZ8DiL/tZOdpXkMbsoB/FDu31cvbbEUWtBvIh1RvDmFkCBkoY8BT9aaGw+NtiXhzxZUnLHbhBXIfeJHqDxmvNmU7GmYkU3LFe35W9laSrmqyVD2ywdqGJnLG/LivLiytfhOeFq8YQmloV7nvWeas+tpx8woT8IJpS71mvDzfLTl98IiZec8JO68q+4eedfHoJbIjVD/eSTSQg9zEKPKoXXxTF6d6kdy2K8U/k9IigTi2tUWKxL40SdCSx7hirpaFRID1jm+udV/6GbjdDTcoZfRH3EjUtlmog+GdSCodJT2Mg9F7fZ3u46kooqy7LYnVUaUstLes6KbE0PrexPiA/FC1JwEIe2/Mhxg/kc6SMX7ZUS3I7iN2H7/e9fO8U44pjwDQngXqoeeP3Dy4zpi0qQ3yncXIYYV82jQItDoLylohuWe8AJKmLfnwa8WTTOARzkY7YJxhasBh+eTd7S42ZKZ2z89Pv9iFdUkVxJQb2pQaSGvoDYYYLOmn8ZIzcZJsxTcRr1z9zFoyfALMVlQHn9TWg7pDoKdkv97vBTWUqcEYsePy8h1dv2tNhh7+TBHj5XQLM3riPe6Bh8tmVG0Tb34= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(136003)(39850400004)(346002)(366004)(451199021)(38100700002)(6486002)(26005)(6506007)(186003)(6512007)(53546011)(5660300002)(83170400001)(2906002)(8936002)(6916009)(66476007)(2616005)(66556008)(6666004)(66946007)(107886003)(4326008)(31696002)(41300700001)(8676002)(19627235002)(42882007)(478600001)(83380400001)(316002)(31686004)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXFlajUwajRWSGNoZks1elo5M29NbVhjSXY4eXUvUDB5K1BzTGp3Nk9hdUd0?= =?utf-8?B?UXZydU5JUmZCZ3RQd3VLRmZrRVZMcmtCb0NIaFpEc2xnZWVRaE9RWDJwRTNI?= =?utf-8?B?c3NrODhMb0plY3NTc2V5cncvZXNObkIwa1dzbzBLZi9CN2YwWjRSbWQ2dWg5?= =?utf-8?B?NU1XdnJvUVhsVk1oZXRlYWNZK2JQaWhId25rMHJKb0syb2k4Snk3VWZEZURC?= =?utf-8?B?eWoyQXFENWhnd3d2b3dnUEV5eGwvZnhSZ1RzUHJ4eHdOaHUwMzZRVmprbGtF?= =?utf-8?B?ZkJSQzlCelFKaGlHdktlUWp2REtZZlRyeGtLNDQvb0RVOWxGTlhBSkhHVjhL?= =?utf-8?B?VzcxR0MvODgydnJPUlh2LzRRMzN6WjNpVVk3RDdRQ0pQMkpHQjJyalRWNEM1?= =?utf-8?B?RUp1NFRKcStmcDEyZ3NaWVB6ZC85Tzk1SkhWNDg2bHFJQmlvMkNjd2tMWjUv?= =?utf-8?B?YXNZMzAyRm93VmcxVVFBdFkwZjA3ZUJmMDdIemk2a2c3UUJLYmZWMWUwVWwz?= =?utf-8?B?TGVnSU5QSDBEV1JCWmovcFFWRDJYd1FOYUZTeUkzeHF1Si9YSDhTU2pLVTZP?= =?utf-8?B?NlhoQkNUNG54UzVBdEVWOHZ4Z1FDaUEyOFhwQlhDUUJZVEdjNVhoT3hldENz?= =?utf-8?B?TkNNYmZISXdaRE5WOXJFVnYweENHMXBKcDZGQ09yYnNDZU9pWGFobkpCZkp6?= =?utf-8?B?cVJLK0JyYnpiNVV4ZUVXcUtlRzIrS1VlSmNjd1J2Q3lXVWZIaWF5T2pqNjNk?= =?utf-8?B?c3hqOEg5UVc3cmFHaXI3YnBCeHlwTHk2YnpmS0hjWkEwK2hFQnFhczRPcHlq?= =?utf-8?B?eDFubFhBVjlxazJhS3pyKzZTOVBSMUNhcFNLSTJUNzRFdHBiaW1mTkF6a0tZ?= =?utf-8?B?aUhheUtEUnRYcFoybE1nYm5md3pyelNHY29VQ2J4S2J5MjNMa3QwTVhPVnVz?= =?utf-8?B?VXBBOHVLelZ5YTJ4N2R0dzBjR1ZzL3NKRGhSdCsxZTlHOCt5K3BQRVNUdmZL?= =?utf-8?B?clZqODkwZjNGUitBQVFPY2tNTWxmQ0hNVkdPWTFrcVZqemtMcVMydi8rMGJl?= =?utf-8?B?ZEsxeVNrYTZFd1hQd3owNnZkRmM4Z2FZUGszZDJmUFk2RCt3ZXVDMDBiOUFu?= =?utf-8?B?aHgxZ1VFRVJlL1BmMWE3MktwbUZtSzNENE9CaXAweWtlYWlWdXF0azFPM3hv?= =?utf-8?B?L2FVZ2JLZVZ2QkM5WmYydGNTTXBtNlFFWmVrZW5JdWtTc1Erd0ZvSmlSVGxv?= =?utf-8?B?U0ZadmtQcTMyQWE4RjRmWXdKUXZrMk95dWVhMGF2MEVqYm1kWTdsa25teGZ0?= =?utf-8?B?Q2JwNHBicGx3czJnT1VaT1hRb2o4V28xNlRPcmMxN3JRTGk5L250VGMxbG5Y?= =?utf-8?B?M1lOL0g2enFJa2FySlZhYUVjVVlRY0VndllxMVJOOFFsaTMzMXREdGNZK2cw?= =?utf-8?B?Nkg3VWwxa2xpYWEyOVBYU2EranJLVnZPNDdvakdWU2hxeVY5a0JwUWVjTngv?= =?utf-8?B?S1UxcjNQaHNYVkhFSVBEbnVCTlVIb0xGSWJNY3o3dzQ0OThOY096TnlxZFlL?= =?utf-8?B?Ny9Gb1B5bkoyYkw3eGpqc1NGN3hkRmFNTkh3WUJIZzFFclNtU21GNDJzODhZ?= =?utf-8?B?bkZuUlh6b2dXRTJaNUQzaGJzVEVwNjFmUlM0MWxoUllFbG1aTkx2Z2d4a21B?= =?utf-8?B?UlVLdW9vTUZzWGlkaDJsUS8vbUpWMUpzOXJVTHZLQnJvWWE1R1ltZWMrbjh0?= =?utf-8?B?OTBwZlNjeGNnZ08xc25tZGF0TUtTZmpJL05Kc3Brdldhb2RIU2lTcWlET3ky?= =?utf-8?B?bkFrL21OUVJTZlJUZWRINHlsQUN1Y1UyOFNzdFgwZTlJOTdRcmltQTlRMTVW?= =?utf-8?B?Q0ptU092d1F6b0NZY1c1ZDVUVXAxQzdIbiszRko1eW4yL013R01TczQ3YTlG?= =?utf-8?B?WEM4blB2MFM1QWdsQTE3RW13a3hLbUZXRnlEYmZVV21VTHNiS24xbE5BWVB5?= =?utf-8?B?S1FFVFcxbnhwU1NoWTcrRWVxNEpKM3hQZTlKSlpYdGNVcnE3U0dCbzRpNFFH?= =?utf-8?B?V0dWbnBKZ2hlVlBRVnltbHhPVzZHWGhkem9tK200VkpQb3VXVlYwaEJuQVVU?= =?utf-8?B?YVY2WXZWd21Wb2JTUUtPcm9oV0sxaFVLb1JCT3hFOHNVSVBhWVlXdkFDQ25h?= =?utf-8?Q?WM8V8WUeu6OL63U2g0I+FgQ=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e0727e2-efd2-41d1-2765-08db3010ef24 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 04:49:09.6162 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HOrUToTkw9HM6S7X41SH2slSBg1tqwfZTqTqsX5VLI/Mci6lU3bs/Hz4pii0ZXIrEUEI73fOFXImQB6FreAJBBlqKL+I7wYv7NECoIqdEK0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR01MB2433 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Leif, Sorry to have kept you waiting. I was not able to send the v2 out sooner than I wanted as the large refactor changes has been well-tested. I have just sent the v2. I hope all your comments are addressed. Thanks so much. Nhi On 1/13/2023 11:25 AM, Nhi Pham wrote: > This patchset adds support for Ampere Altra Max processor. > > Tinh Nguyen (1): > JadePkg: ACPI: Support ACPI tables for Ampere Altra Max > > Vu Nguyen (1): > Ampere: PCIe: Add support for Ampere Altra Max > > .../AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +- > Platform/Ampere/JadePkg/Jade.dsc | 3 +- > Platform/Ampere/JadePkg/Jade.fdf | 3 +- > .../JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf | 20 + > .../Include/Library/AmpereCpuLib.h | 31 +- > .../AmpereAltraPkg/Include/NVParamDef.h | 64 +- > .../AmpereAltraPkg/Include/Platform/Ac01.h | 5 +- > .../Library/Ac01PcieLib/PcieCore.h | 8 +- > .../Drivers/AcpiPlatformDxe/AcpiMadt.c | 103 +- > .../Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c | 10 +- > .../Library/BoardPcieLib/BoardPcieLib.c | 63 +- > .../Drivers/PcieInitPei/PcieInitPei.c | 16 +- > .../Drivers/PcieInitPei/RootComplexNVParam.c | 101 +- > .../Library/Ac01PcieLib/PcieCore.c | 150 +- > .../Library/AmpereCpuLib/AmpereCpuLibCommon.c | 243 +- > .../Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi | 6345 +++++++++++++++++ > .../Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi | 6345 +++++++++++++++++ > .../Ampere/JadePkg/Ac02AcpiTables/CPU.asi | 152 + > .../JadePkg/Ac02AcpiTables/CommonDevices.asi | 670 ++ > .../Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl | 39 + > .../JadePkg/Ac02AcpiTables/PCI-PDRC.asi | 217 + > .../JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi | 669 ++ > .../Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi | 2041 ++++++ > .../Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi | 2051 ++++++ > .../Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi | 1292 ++++ > .../Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi | 1292 ++++ > .../Ampere/JadePkg/Ac02AcpiTables/PMU.asi | 10 + > 27 files changed, 21699 insertions(+), 250 deletions(-) > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Ac02AcpiTables.inf > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S0.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU-S1.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CPU.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/CommonDevices.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/Dsdt.asl > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-PDRC.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.Rca01.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S0.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PCI-S1.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S0.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU-S1.asi > create mode 100644 Platform/Ampere/JadePkg/Ac02AcpiTables/PMU.asi >