From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2FF84209574E2 for ; Fri, 2 Mar 2018 06:28:54 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F63340796A2; Fri, 2 Mar 2018 14:35:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-104.rdu2.redhat.com [10.10.120.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04E691C735; Fri, 2 Mar 2018 14:34:57 +0000 (UTC) To: "Yao, Jiewen" , "marcandre.lureau@redhat.com" Cc: "edk2-devel@lists.01.org" , "pjones@redhat.com" , "qemu-devel@nongnu.org" , "javierm@redhat.com" References: <20180223132311.26555-1-marcandre.lureau@redhat.com> <20180223132311.26555-2-marcandre.lureau@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C503AACEB43@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Fri, 2 Mar 2018 15:34:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AACEB43@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 02 Mar 2018 14:35:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 02 Mar 2018 14:35:03 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 14:28:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02/24/18 01:09, Yao, Jiewen wrote: > Reviewed-by: Jiewen.yao@intel.com Given that Jiewen co-maintains SecurityPkg as of commit 3db2823f1e27 ("Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg.", 2018-03-02), I pushed this patch in isolation: commit a39e72267034. However, Marc-André, something seems to be wrong with the way you formatted the patch. The patch email is base64 encoded (which I guess shouldn't be a problem per se), and I had to pass "--ignore-whitespace" to git-am. It means that the *context* lines in your patch didn't have the correct CRLF terminators. That seems very strange because the files being modified are fully CRLF (I checked). The git settings that I personally recommend to edk2 contributors are written up here: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers Also, if you could push every version of the patch set to a separate branch in your public edk2 clone (e.g. on github, or elsewhere), that would be great -- please just mark the repo URL and the branch name in the cover letter of that version, when you post it. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> marcandre.lureau@redhat.com >> Sent: Friday, February 23, 2018 9:23 PM >> To: edk2-devel@lists.01.org >> Cc: qemu-devel@nongnu.org; javierm@redhat.com; pjones@redhat.com; Yao, >> Jiewen ; lersek@redhat.com >> Subject: [edk2] [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib >> dependency >> >> From: Marc-André Lureau >> >> Apparently, unnecessary. Avoids extra build dependency and churn. >> >> CC: Laszlo Ersek >> CC: Stefan Berger >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Marc-André Lureau >> --- >> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 2 -- >> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - >> 2 files changed, 3 deletions(-) >> >> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> index a7ae3354b5..3758fc6a41 100644 >> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c >> @@ -18,7 +18,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY >> KIND, EITHER EXPRESS OR IMPLIED. >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> @@ -44,7 +43,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY >> KIND, EITHER EXPRESS OR IMPLIED. >> #include >> #include >> #include >> -#include >> >> #define PERF_ID_TCG2_PEI 0x3080 >> >> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> index f7b85444d9..bc910c3baf 100644 >> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf >> @@ -58,7 +58,6 @@ >> PerformanceLib >> MemoryAllocationLib >> ReportStatusCodeLib >> - Tcg2PhysicalPresenceLib >> ResetSystemLib >> >> [Guids] >> -- >> 2.16.1.73.g5832b7e9f2 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >