From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 380E3220C1C39 for ; Thu, 30 Nov 2017 04:17:52 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E062C0587C0; Thu, 30 Nov 2017 12:22:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-19.rdu2.redhat.com [10.10.120.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id A531E60621; Thu, 30 Nov 2017 12:22:16 +0000 (UTC) From: Laszlo Ersek To: Ruiyu Ni , edk2-devel@lists.01.org Cc: Ard Biesheuvel References: <20171129101500.288384-1-ruiyu.ni@intel.com> <20171129101500.288384-3-ruiyu.ni@intel.com> <751c492a-26bc-49a5-deb7-80ef44a94953@redhat.com> Message-ID: Date: Thu, 30 Nov 2017 13:22:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <751c492a-26bc-49a5-deb7-80ef44a94953@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 30 Nov 2017 12:22:17 +0000 (UTC) Subject: Re: [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 12:17:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/29/17 14:53, Laszlo Ersek wrote: > Ray, > > On 11/29/17 11:14, Ruiyu Ni wrote: >> The TFTP command was converted from a NULL class library >> instance to a dynamic shell command in commit 0961002352e9. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ruiyu Ni >> Reviewed-by: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Julien Grall >> --- >> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++++++---- >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- >> ArmVirtPkg/ArmVirtXen.fdf | 3 ++- >> 3 files changed, 11 insertions(+), 6 deletions(-) > > Can you please incorporate points (2) and (3) as well, from my v3 review? > > https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html I fixed up the commit message as described above. I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen platforms, with the patch applied, for ARM and AARCH64. [lersek@redhat.com: extend commit message] Reviewed-by: Laszlo Ersek Build-tested-by: Laszlo Ersek Commit 59fcf0706bf4. Thanks Laszlo