From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8072B211BFCA3 for ; Wed, 30 Jan 2019 04:30:12 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 04:30:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="139162899" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 30 Jan 2019 04:30:11 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id A163E580297; Wed, 30 Jan 2019 04:30:09 -0800 (PST) Message-ID: From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 13:30:07 +0100 In-Reply-To: <20181106175833.26964-10-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-10-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 X-List-Received-Date: Wed, 30 Jan 2019 12:30:12 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > UINT8 and CHAR8 are not the same underlying type on all > architectures, > so add an explicit cast where necessary. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/Hii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c > b/IntelUndiPkg/GigUndiDxe/Hii.c > index a5d8ae207819..737a59fbbbac 100644 > --- a/IntelUndiPkg/GigUndiDxe/Hii.c > +++ b/IntelUndiPkg/GigUndiDxe/Hii.c > @@ -817,7 +817,7 @@ HiiSetMenuStrings ( > > Status = ReadPbaString ( > &UndiPrivateData->NicInfo, > - PBAString8, > + (UINT8 *)PBAString8, > MAX_PBA_STR_LENGTH > ); > if (Status == EFI_SUCCESS) {