From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.4191.1622104111788220325 for ; Thu, 27 May 2021 01:28:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dGJu8tRy; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tfTKv0KCGYP+J41v3JjuRoa6uLeb1Rv8lrhV6WiIaac=; b=dGJu8tRyBwxD+w6nNPMVJr4xEtINZJxwXAEiOPRP8thCJ4MEHUDuIaQDo25CmxPQbNWmrd Qp8x74gdfBDJk1MMbqBM+FHJoxyZ3nSH1if9mk2f5/DeUfMP6RSiXrVi2dezzfm4Hqg4vS 0+Yx6dcpVg3QROtj8bv9k5CWHumhqDU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-h3b1ogYgMk6acfkf0sA7yA-1; Thu, 27 May 2021 04:28:29 -0400 X-MC-Unique: h3b1ogYgMk6acfkf0sA7yA-1 Received: by mail-wm1-f71.google.com with SMTP id u203-20020a1cddd40000b029016dbb86d796so1228525wmg.0 for ; Thu, 27 May 2021 01:28:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tfTKv0KCGYP+J41v3JjuRoa6uLeb1Rv8lrhV6WiIaac=; b=P+1qegmO+rf6d3x7C/MG9NYkaGetInHExDb/IV4/rs+USMvyDfn3Eljr3Ze+t0xyQd l2FwEhxIXDT3g7SsHJBu/DL+9el8OfFt23SbToYMuTfwDr0VAG83j+3gyjz9PpW0wIpJ xeY6g+OEIPI5R3Eh56kY97bhawZn+WdVwCexFA7eNlpNYeuviCu4m1i/CDz4zh5GogjV LbrG/f9pj0YaSdQ1bNlcQXeN1pLgh+NjaMRJJY5JTcSYOhHPQmoHuK4DWuV3oXgYc8aW 4Hz5I78KvXuuyjw2F48vTJ5QFJNhJkNbwPWkHJNGlhN0/7GUY9pDdpcrz34+2ST7VGGD DN5w== X-Gm-Message-State: AOAM5314yLH4djPqH/aiPdwBCMTD//+vCgvX89f4TjseTiTqZcQbYh1N VCMaTNpS/9mRet9Oj5rtsQBpStk0kLd6ZQKV7g9UpvKc8duswhL2ciUsNOnRI4lol7Cy3KX2pQL tcuPVBFCpAO/pBg== X-Received: by 2002:a5d:6b09:: with SMTP id v9mr2036098wrw.297.1622104108038; Thu, 27 May 2021 01:28:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyL8aUGiGMBfWwnvwpX0nUhVgMij7E2y5EZWzFzG2gE2W7ihJkP1Q3JZkfY78pyLda47JaEsw== X-Received: by 2002:a5d:6b09:: with SMTP id v9mr2036084wrw.297.1622104107852; Thu, 27 May 2021 01:28:27 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id u14sm9471889wmc.41.2021.05.27.01.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:28:27 -0700 (PDT) Subject: Re: [PATCH 20/43] OvmfPkg/XenAcpiPlatformDxe: remove delayed ACPI table installation To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-21-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 10:28:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-21-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > Because "PcdPciDisableBusEnumeration" is always TRUE in the OvmfXen > platform, we can remove the delayed ACPI table installation from > XenAcpiPlatformDxe. A number of dependencies become useless this way; > remove them too. > > (Note that, conversely, in the QemuFwCfgAcpiPlatformDxe driver, we > *cannot* assume that "PcdPciDisableBusEnumeration" is always FALSE, > regardless of Xen: in the ArmVirtQemu platform, the PCD may carry either > FALSE or TRUE, dependent on whether or not the QEMU "virt" machine > configuration includes a PCIe host controller, respectively.) > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 8 --- > OvmfPkg/XenAcpiPlatformDxe/EntryPoint.c | 56 +------------------- > 2 files changed, 2 insertions(+), 62 deletions(-) Reviewed-by: Philippe Mathieu-Daude