From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smarthost01c.sbp.mail.zen.net.uk (smarthost01c.sbp.mail.zen.net.uk [212.23.1.5]) by mx.groups.io with SMTP id smtpd.web10.4625.1659685972631639724 for ; Fri, 05 Aug 2022 00:52:52 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=permerror, err=parse error for token &{10 18 sdn.klaviyomail.com}: permanent DNS error (domain: starlabs.systems, ip: 212.23.1.5, mailfrom: sean@starlabs.systems) Received: from [51.148.147.4] (helo=localhost.localdomain) by smarthost01c.sbp.mail.zen.net.uk with esmtp (Exim 4.90_1) (envelope-from ) id 1oJs8X-0006hN-El; Fri, 05 Aug 2022 07:52:49 +0000 From: "Sean Rhodes" To: devel@edk2.groups.io Cc: Sean Rhodes , Zhichao Gao , Ray Ni , Jian J Wang , Liming Gao Subject: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo Date: Fri, 5 Aug 2022 08:52:39 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: <83963289b879f8f69e8a385038cb88dd73a8c250.1659685959.git.sean@starlabs.systems> References: <83963289b879f8f69e8a385038cb88dd73a8c250.1659685959.git.sean@starlabs.systems> MIME-Version: 1.0 X-Originating-smarthost01c-IP: [51.148.147.4] Feedback-ID: 51.148.147.4 Content-Transfer-Encoding: quoted-printable When set to true, the Logo is positioned according to the BGRT specification, 38.2% from the top of the screen. When set to false, no behaviour is changed and the logo is positioned centrally. Cc: Zhichao Gao Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Sean Rhodes --- MdeModulePkg/Logo/Logo.c | 5 +++++ MdeModulePkg/Logo/LogoDxe.inf | 4 ++++ MdeModulePkg/MdeModulePkg.dec | 6 ++++++ MdeModulePkg/MdeModulePkg.uni | 6 ++++++ 4 files changed, 21 insertions(+) diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c index 8ab874d2da..1638d0f984 100644 --- a/MdeModulePkg/Logo/Logo.c +++ b/MdeModulePkg/Logo/Logo.c @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include =0D #include =0D #include =0D +#include =0D =0D typedef struct {=0D EFI_IMAGE_ID ImageId;=0D @@ -69,6 +70,10 @@ GetImage ( return EFI_NOT_FOUND;=0D }=0D =0D + if (FixedPcdGetBool (PcdFollowMicrosoftRecommended)) {=0D + mLogos[Current].Attribute =3D EdkiiPlatformLogoDisplayAttributeMicroso= ftRecommended;=0D + }=0D +=0D (*Instance)++;=0D *Attribute =3D mLogos[Current].Attribute;=0D *OffsetX =3D mLogos[Current].OffsetX;=0D diff --git a/MdeModulePkg/Logo/LogoDxe.inf b/MdeModulePkg/Logo/LogoDxe.inf index 41215d25d8..ce29950089 100644 --- a/MdeModulePkg/Logo/LogoDxe.inf +++ b/MdeModulePkg/Logo/LogoDxe.inf @@ -41,6 +41,7 @@ UefiBootServicesTableLib=0D UefiDriverEntryPoint=0D DebugLib=0D + PcdLib=0D =0D [Protocols]=0D gEfiHiiDatabaseProtocolGuid ## CONSUMES=0D @@ -48,6 +49,9 @@ gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES=0D gEdkiiPlatformLogoProtocolGuid ## PRODUCES=0D =0D +[Pcd]=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended ## CONSUMES= =0D +=0D [Depex]=0D gEfiHiiDatabaseProtocolGuid AND=0D gEfiHiiImageExProtocolGuid=0D diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 7d98910832..a503aaf58d 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -2098,6 +2098,12 @@ # @Prompt The shared bit mask when Intel Tdx is enabled.=0D gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x10000025= =0D =0D + ## This PCD sets the position of the Boot Logo.=0D + # TRUE - The Logo is positioned following the recommendations from Mi= crosoft.=0D + # FALSE - The logo is positioned in the center of the screen.=0D + # @ Prompt This position of the boot logo=0D + gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|FALSE|BOOLE= AN|0x10000026=0D +=0D [PcdsPatchableInModule]=0D ## Specify memory size with page number for PEI code when=0D # Loading Module at Fixed Address feature is enabled.=0D diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index b070f15ff2..e7050df7b7 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1334,3 +1334,9 @@ #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPcieResizableBarSupport_HELP= #language en-US "Indicates if the PCIe Resizable BAR Capability Supported.=

\n"=0D = "TRUE - PCIe Resizable BAR Capability is supported.
\= n"=0D = "FALSE - PCIe Resizable BAR Capability is not supported.<= BR>"=0D +=0D +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommended_P= ROMPT #language en-US "The position of the Boot Logo"=0D +=0D +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFollowMicrosoftRecommend_HEL= P #language en-US "Sets the position of the Logo. When set to true, the L= ogo is positioned following the recommendations"=0D + = " from Microsoft, 38.2% from the top of the screen."=0D +=0D --=20 2.34.1