From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7A54A21B02822 for ; Wed, 21 Nov 2018 02:56:07 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E5A8AC04959D; Wed, 21 Nov 2018 10:56:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-240.rdu2.redhat.com [10.10.120.240]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9CE75D75D; Wed, 21 Nov 2018 10:56:05 +0000 (UTC) From: Laszlo Ersek To: Fu Siyuan Cc: edk2-devel@lists.01.org, Ting Ye , Jiaxin Wu References: <20181121052819.15744-1-siyuan.fu@intel.com> <20181121052819.15744-2-siyuan.fu@intel.com> <1f37c165-aa7e-03d2-218d-b0c394c1e2fe@redhat.com> Message-ID: Date: Wed, 21 Nov 2018 11:56:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1f37c165-aa7e-03d2-218d-b0c394c1e2fe@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 21 Nov 2018 10:56:07 +0000 (UTC) Subject: Re: [PATCH 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 10:56:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/21/18 11:46, Laszlo Ersek wrote: > On 11/21/18 06:28, Fu Siyuan wrote: >> The "Network.dsc.inc" and "Network.fdf.inc" are added for platform owner to >> easily enable/disable network stack support on their platform, by adding >> !include NetworkPkg/Network.dsc.inc >> and >> !include NetworkPkg/Network.fdf.inc >> to their platform DSC/FDF files. >> >> A set of flags can be changed before the include line or in build command >> line ("-D FLAG=VALUE") to enable or disable related feature set. >> >> The default value of these flags are: >> DEFINE NETWORK_ENABLE = TRUE >> DEFINE NETWORK_SNP_ENABLE = TRUE >> DEFINE NETWORK_IP4_ENABLE = TRUE >> DEFINE NETWORK_IP6_ENABLE = TRUE >> DEFINE NETWORK_TLS_ENABLE = TRUE >> DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE >> DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = FALSE >> DEFINE NETWORK_IPSEC_ENABLE = TRUE >> DEFINE NETWORK_ISCSI_ENABLE = TRUE >> DEFINE NETWORK_VLAN_ENABLE = TRUE > > [...] I'd like to review the ArmVirtPkg and OvmfPkg patches in detail once the NetworkPkg patch stabilizes. In addition, I have some higher-level comments. This patch series effectively renames a few preexistent build flags, such as "HTTP_BOOT_ENABLE" to "NETWORK_HTTP_BOOT_ENABLE", "TLS_ENABLE" to "NETWORK_TLS_ENABLE", and so on. - Please grep the edk2 source tree for the original (disappearing) flags, and update them as necessary, not just in DSC/FDF files, but also in documentation. For example, "HTTP_BOOT_ENABLE" and "TLS_ENABLE" are mentioned in "OvmfPkg/README". - Please also grep the edk2 Wiki for the same (clone it locally and then run "git grep"). For example, the "Testing-SMM-with-QEMU,-KVM-and-libvirt.md" article also refers to HTTP_BOOT_ENABLE and TLS_ENABLE. - It is likely a good idea to list this change (that is, ), under . I see that #1278 is listed already, but the build flag renaming is an incompatible change, and it deserves a mention. Thanks! Laszlo