public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] edk2 Automatic PR Reviewers
@ 2024-07-25  2:35 Michael Kubacki
  2024-07-25  3:55 ` Michael Kubacki
  2024-07-25 16:00 ` Rebecca Cran
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Kubacki @ 2024-07-25  2:35 UTC (permalink / raw)
  To: devel@edk2.groups.io

A change was just pushed to edk2 to automatically add reviewers to pull 
request based on those listed in Maintainers.txt.

For more details and in case of any issues, I put some information on 
this wiki page:

https://github.com/tianocore/tianocore.github.io/wiki/Automatic-Pull-Request-Reviewer-Details

Thanks,
Michael


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120030): https://edk2.groups.io/g/devel/message/120030
Mute This Topic: https://groups.io/mt/107536057/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] edk2 Automatic PR Reviewers
  2024-07-25  2:35 [edk2-devel] edk2 Automatic PR Reviewers Michael Kubacki
@ 2024-07-25  3:55 ` Michael Kubacki
  2024-07-25 16:00 ` Rebecca Cran
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Kubacki @ 2024-07-25  3:55 UTC (permalink / raw)
  To: devel@edk2.groups.io

It looks like the permissions will need adjusted. That will come in a 
follow up change.

On 7/24/2024 10:35 PM, Michael Kubacki wrote:
> A change was just pushed to edk2 to automatically add reviewers to pull 
> request based on those listed in Maintainers.txt.
> 
> For more details and in case of any issues, I put some information on 
> this wiki page:
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Automatic-Pull-Request-Reviewer-Details
> 
> Thanks,
> Michael


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120031): https://edk2.groups.io/g/devel/message/120031
Mute This Topic: https://groups.io/mt/107536057/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] edk2 Automatic PR Reviewers
  2024-07-25  2:35 [edk2-devel] edk2 Automatic PR Reviewers Michael Kubacki
  2024-07-25  3:55 ` Michael Kubacki
@ 2024-07-25 16:00 ` Rebecca Cran
  1 sibling, 0 replies; 3+ messages in thread
From: Rebecca Cran @ 2024-07-25 16:00 UTC (permalink / raw)
  To: devel, mikuback

On 7/24/24 20:35, Michael Kubacki wrote:
> A change was just pushed to edk2 to automatically add reviewers to pull 
> request based on those listed in Maintainers.txt.
> 
> For more details and in case of any issues, I put some information on 
> this wiki page:
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Automatic-Pull- 
> Request-Reviewer-Details

On a related note, this tool looks useful for verifying the content of 
CODEOWNERS and/or REVIEWERS when we decide to move to those files: 
https://github.com/hmarr/codeowners.

Usage
By default, the command line tool will walk the directory tree, printing 
the code owners of any files that are found.

$ codeowners --help
usage: codeowners <path>...
   -f, --file string     CODEOWNERS file path
   -h, --help            show this help message
   -o, --owner strings   filter results by owner
   -u, --unowned         only show unowned files (can be combined with -o)

$ ls
CODEOWNERS       DOCUMENTATION.md README.md        example.go 
example_test.go

$ cat CODEOWNERS
*.go       @example/go-engineers
*.md       @example/docs-writers
README.md  product-manager@example.com

$ codeowners
CODEOWNERS                           (unowned)
README.md                            product-manager@example.com
example_test.go                      @example/go-engineers
example.go                           @example/go-engineers
DOCUMENTATION.md                     @example/docs-writers



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120041): https://edk2.groups.io/g/devel/message/120041
Mute This Topic: https://groups.io/mt/107536057/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-25 16:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-25  2:35 [edk2-devel] edk2 Automatic PR Reviewers Michael Kubacki
2024-07-25  3:55 ` Michael Kubacki
2024-07-25 16:00 ` Rebecca Cran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox