From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D510A9417C1 for ; Tue, 5 Dec 2023 11:49:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XaOr5fQWNyoK79pHBY5f3f7M+qCcSWcdpHRUe7/R/yw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:From:Subject:To:Cc:References:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701776958; v=1; b=NvxY0yiydBcSNDaHb+EvYP9P3i8eBubb55g32tYNScMoIAqy8ISyy4QJmmCIElnJt2T8fiq8 6bW2v6KLscrZjpnKqBHZpTef8EY6PCe3niWB1Run1KvcERzPHRhFEKGpBIc+lJXekeCc95JmhSo qpu2ahf06+lTGCMwhMns52mM= X-Received: by 127.0.0.2 with SMTP id ev9OYY7687511xBXKLzzEVJA; Tue, 05 Dec 2023 03:49:18 -0800 X-Received: from EUR02-AM0-obe.outbound.protection.outlook.com (EUR02-AM0-obe.outbound.protection.outlook.com [40.107.247.71]) by mx.groups.io with SMTP id smtpd.web11.97496.1701776952644617950 for ; Tue, 05 Dec 2023 03:49:13 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WBSHFDMJvDpgyf1H0u+j+UEeUjkB34nMO8vt781yf3YLuUqI4JqqZ+weURFOeqFQ2yI8QCahOUFfnPr1PWfpB6F1azyTY6SqnBUv3ltnqRJQEBZWhxZkQSlFSwkCV71mEcLZWHjMLTvwJTZ4f4yMR7+Ek8LGX9TnpJa4+Kb1qjXRkRNviqjR1/yzxM98nIMb8EvNndVHdnJEieECJ9qTwIwAda0TsCQ7anWoia0mhHI49K51OrFFUU53gR3NVorBJ6Df00+eaWmAZ9wC/GXOizxgIa1PBUD6q1QqR0dS1JAqapZ8J3eLVVz2L6O/g3pT3YiHeksk8Vc+WCXKFZGK9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0og/tMIJd/DcB1KBcg4LcpikQ+ggF40qQOldDune7ow=; b=ZYitn9Z0vwkWDzhVEPsutVcaAMKhATWlCWWNLjJ3S967zxdDXjOl1NfEymligg5KqV+5wIGLZqz6Qc5/t2udNKJZg16UIx6thv6K4BSoQSgXCuBQtvia+avvkshMwk29T/5hKvUaKiJcqhV+TqWtZzX4Qy95b9GOc+lI7CpjpzDLDgIuW2JrNU124QpG6DW/tur9/wSsetVsMu92Z29jIACH7gydHcPifP4agqnXU3F/oPl56cnOqIGRuyj2OpulszOcF8kGh8m1N/uXpHtKDBmI5t5qFOtqaDp8PixYadtiqQ1MxMEIJy/Z+KEwr13DxRbx4QDTwcJfXaMGzEe+CA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DU2PR04CA0031.eurprd04.prod.outlook.com (2603:10a6:10:234::6) by AS8PR08MB6469.eurprd08.prod.outlook.com (2603:10a6:20b:33c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Tue, 5 Dec 2023 11:49:08 +0000 X-Received: from DB1PEPF0003922E.eurprd03.prod.outlook.com (2603:10a6:10:234:cafe::2c) by DU2PR04CA0031.outlook.office365.com (2603:10a6:10:234::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.33 via Frontend Transport; Tue, 5 Dec 2023 11:49:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF0003922E.mail.protection.outlook.com (10.167.8.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.20 via Frontend Transport; Tue, 5 Dec 2023 11:49:07 +0000 X-Received: ("Tessian outbound 8289ea11ec17:v228"); Tue, 05 Dec 2023 11:49:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b44d3b5ae69c77e8 X-CR-MTA-TID: 64aa7808 X-Received: from 72e09187169d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 37CB1605-8278-4E66-95D0-DAA544CF67AA.1; Tue, 05 Dec 2023 11:48:56 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 72e09187169d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Dec 2023 11:48:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzDpiZRJOL1ATK0Rt37ljeuJ+NKtSIrNZJLXArO2FBehIbaAvSGjYstrP7LMAQXLavZt/BN60xwYhtDWJMQ7FV5rpvuSQD+Fv7Dkmfv2gzbwxrWxRXsiGLYcXJgYYq4XKB//entWAcoDgt1Nm7T5zKvb65QiJZRwN5nx7Oe8diyGreNpny7vgrYvPZr6+onqy+VA7y2pBaYvBY6cToQR1hl9YoYKGpdSBEq9YSuvyrZdcIRhTEh/b/1uN8VkVr7LGbM25m5AscbMn8dxnh5KC/BudmhRPCOkzrYI246x2HKKIMRc2sVFR9iSpBmTqXJAphj0A0rKHzGaKTKUZtH4Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0og/tMIJd/DcB1KBcg4LcpikQ+ggF40qQOldDune7ow=; b=EHWdAzzs3xvnFEIwoBOkgQCk9KzcJtlyCtYamog2sqa7xdEpHLgJm8CJMX+3q1aRMo8bI8mWV4OPV4NKxeN+0bN6aCXlkQzzl6ESNG9JTFmio70QHrjMgkXouqOWwi0cTqXAr35Ux31YMP4xu8ioWEU9i5f1pUuoey77yxYQIBH9nXSsw8j5nJS4nHVH8JO4gYWytBTkZe1TMA9Y8rY/TyDvo5tXK9dkfpSiWFbc9Eq41qCXVJdOBTJse40wvaW4UN8d0qhdm3n++fAghQ+OKYc23yiNt5Lopqq6N3wPxbw22e2LBPpxhHC83Nj7Uj7DwNmdLwpRRiKNSQVW/GHjBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAVPR08MB9795.eurprd08.prod.outlook.com (2603:10a6:102:31f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Tue, 5 Dec 2023 11:48:52 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7046.034; Tue, 5 Dec 2023 11:48:52 +0000 Message-ID: Date: Tue, 5 Dec 2023 11:48:52 +0000 User-Agent: Mozilla Thunderbird From: "Sami Mujawar" Subject: Re: [edk2-devel] [PATCH v5 5/6] ShellPkg: acpiview: Add routines to print reserved fields To: Rohit Mathew , devel@edk2.groups.io Cc: James Morse , Thomas Abraham , Zhichao Gao , "nd@arm.com" References: <20231002171720.901538-1-Rohit.Mathew@arm.com> In-Reply-To: <20231002171720.901538-1-Rohit.Mathew@arm.com> X-ClientProxiedBy: LO2P123CA0030.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAVPR08MB9795:EE_|DB1PEPF0003922E:EE_|AS8PR08MB6469:EE_ X-MS-Office365-Filtering-Correlation-Id: d9086e6a-84c4-4075-424f-08dbf5883038 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nw7Foxs1sew/zTKXsYe9CIDUpC3Rr7e34aVzlxpWfn/lx4szQ+vXKwA8/M3oPForuBHpimahXo3a8WGr4D43KUUKXaiC8/5dKZhGygB233ATe4ksbx/SOnZFFrGNhq2b1dnLxOD/By3yJjLja99Bh8OjxTjrxHspG5kpekEzJr5GmkoUO+OAHdMjE0Smx7HfSKQpx7nV9/OgwgKVtjhKUcQOt7mDZVr5pHy9mZzMSQqHU/IKQzlGuEIhbvCoh1ohO1Gc2lIolYZMpG0GMCP3rUpcJw3vXORbSmHohjm+S3KtYCqMJ06jHrx9fj22fuBXFSM3zhMFFmL+KvK2JvoMFfnI9rrcLu83dVpxdDpM9ayvM9nmbdOA/9lq1EkYUvJsjzdLpYor2+iKiWodmJvVZzWXflXvwsVAzkLgJp1qW6EDKqKZRVdggl3udhB6H3cZwM9/T0X+XQqhrhL9USekKxsEdBR0Iq2JkJkn6mv7OKKwldvZpzHOReEcTIBMBH5udsYJ+EgnzZet89L+zpF2pQh6MHnR24OiIWzXAEG4KBLgKIkXF9Xvb11ZXlLfhrQTPTo6KSPRnqKU3Xu/0quJg8CH8DqUmZZ+mPdWpeAEmT41am0v7KHU8DMevBsUzQk6WlcfhsQuIdV1QFCOcfTCbA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(396003)(136003)(366004)(39860400002)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(6512007)(26005)(38100700002)(31686004)(6506007)(2616005)(53546011)(6486002)(478600001)(66946007)(66556008)(66476007)(54906003)(316002)(8676002)(8936002)(4326008)(2906002)(41300700001)(36756003)(44832011)(86362001)(31696002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9795 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF0003922E.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 003019bf-ab34-4c28-a30e-08dbf588272f X-Microsoft-Antispam-Message-Info: IzfmT/j+u/SOL6sEMBu6fddeEbywx8d4iOSFey/7B6NL5vZzo4YGtwRtlrGGw5nODschHhyHl4tsfxg7203BuBq6lRnuXhsR3eMoyFJ+sBiMeI9D30dMjY+BcKI+m+6JR7/4mEWbwvrASuoyK0/U8xAKydeRl0RqxXMb4SJyMqWwQdB5+xmumt+dV8kGs/MxmxydgxkEfQk8BfErwu1ecGdFI/KB6BAG/is1oEG9nKwYXEEI4IQ9IAhcGASsMLbwejjKoV2T5QpgTDrZUcRZgw4i0oGMmSOMPHxfXKnrnknBuNKiHeivXpZ/fkwQAmMcWCLBy6ybFuwoIluKKSrqOB43kSol4UsianjCOwEGpWqPfnZ9pfqCRZbk/vQJhycpW2XlF9zw4zmOrmNppmgYmbsdcxOT2oMeX7D/OZMGrEvvHDnELSv7FpGwpNV8DmMoky/rznYlqNIzhHCAYskZVT6HvWc6SC13u0xCRcxt1glBystd8S/nV1CaDqmbjl+9EhvKIEy91j4TMzKAGDRNUwRHI4raqNFVvLGx5shBabS6RSQ1afSBiZnAouvwySsiYGr7/2I6OZtifXDa1AYohdyHxhm3qc4NVqZ4jKUo969G55MCvqd/BQ1exIf+k76RZptdEZnxVGxTb1xX7KRDHnkwUm2pxW5eXoRajVOc4gy1LdEeaNrxoeZrDSOhP9hSqYfnymnm7EV4Q17cYd8rjvt8Q2dy/d9V1cBIO0apjoafFWlinbC2QyeCxCwLX5dYW19CCeBMMTx6OKXWA256uQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2023 11:49:07.6407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9086e6a-84c4-4075-424f-08dbf5883038 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF0003922E.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6469 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9vU8em2Yis4G9YdO8PevvXFyx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NvxY0yiy; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Rohit, I have a minor suggestion marked inline as [SAMI]. Otherwise this patch looks good to me. With that addressed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 02/10/2023 06:17 pm, Rohit Mathew wrote: > Most of the ACPI tables have fields that are marked reserved. Implement > functions "DumpReserved" and "DumpReservedBits" aligning with the > print-formatter prototype to print out reserved fields. > > Signed-off-by: Rohit Mathew > Cc: James Morse > Cc: Sami Mujawar > Cc: Thomas Abraham > Cc: Zhichao Gao > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 126 +++++++= +++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 38 ++++++ > 2 files changed, 164 insertions(+) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/= ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > index 20d817e357..cc520d9b27 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > @@ -498,6 +498,132 @@ Dump16Chars ( > ); > } > =20 > +/** > + This function traces reserved fields up to 8 bytes in length. > + > + Format string is ignored by this function as the reserved field is pri= nted > + byte by byte with intermittent spacing . Use DumpxChars f= or any > + other use case. > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] Length Length of the field. > +**/ > +VOID > +EFIAPI > +DumpReserved ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr, > + IN UINT32 Length > + ) > +{ > + switch (Length) { > + case 8: > + Print ( > + L"%u %u %u %u %u %u %u %u", > + Ptr[0], > + Ptr[1], > + Ptr[2], > + Ptr[3], > + Ptr[4], > + Ptr[5], > + Ptr[6], > + Ptr[7] > + ); > + break; > + case 7: > + Print ( > + L"%u %u %u %u %u %u %u", > + Ptr[0], > + Ptr[1], > + Ptr[2], > + Ptr[3], > + Ptr[4], > + Ptr[5], > + Ptr[6] > + ); > + break; > + case 6: > + Print ( > + L"%u %u %u %u %u %u", > + Ptr[0], > + Ptr[1], > + Ptr[2], > + Ptr[3], > + Ptr[4], > + Ptr[5] > + ); > + break; > + case 5: > + Print ( > + L"%u %u %u %u %u", > + Ptr[0], > + Ptr[1], > + Ptr[2], > + Ptr[3], > + Ptr[4] > + ); > + break; > + case 4: > + Print ( > + L"%u %u %u %u", > + Ptr[0], > + Ptr[1], > + Ptr[2], > + Ptr[3] > + ); > + break; > + case 3: > + Print ( > + L"%u %u %u", > + Ptr[0], > + Ptr[1], > + Ptr[2] > + ); > + break; > + case 2: > + Print ( > + L"%u %u", > + Ptr[0], > + Ptr[1] > + ); > + break; > + case 1: > + Print ( > + L"%u", > + Ptr[0] > + ); > + break; > + default: > + return; > + } > +} > + > +/** > + This function traces reserved fields up to 64 bits in length. > + > + Format string is ignored by this function as the reserved field is pri= nted > + byte by byte with intermittent spacing. eg: <0 0 0 0>. When the field = length > + isn't a multiple of 8, the number of bytes are "ceil"-ed by one. eg fo= r 27 > + bits <0 0 0 0> > + > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] Length Length of the field. [SAMI] I think the documentation for the Length filed should say=20 something like 'Length of the field as number of bits.' > +**/ > +VOID > +EFIAPI > +DumpReservedBits ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr, > + IN UINT32 Length > + ) > +{ > + UINT32 ByteLength; > + > + ByteLength =3D (Length + 7) >> 3; > + DumpReserved (Format, Ptr, ByteLength); > +} > + > /** > This function indents and prints the ACPI table Field Name. > =20 > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/= ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > index 80bac6a584..89930fdc6d 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > @@ -230,6 +230,44 @@ Dump16Chars ( > IN UINT32 Length > ); > =20 > +/** > + This function traces reserved fields up to 8 bytes in length. > + > + Format string is ignored by this function as the reserved field is pri= nted > + byte by byte with intermittent spacing . Use DumpxChars f= or any > + other use case. > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] Length Length of the field. > +**/ > +VOID > +EFIAPI > +DumpReserved ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr, > + IN UINT32 Length > + ); > + > +/** > + This function traces reserved fields up to 64 bits in length. > + > + Format string is ignored by this function as the reserved field is pri= nted > + byte by byte with intermittent spacing. eg: <0 0 0 0>. When the field = length > + isn't a multiple of 8, the number of bytes are "ceil"-ed by one. eg fo= r 27 > + bits <0 0 0 0> > + > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > + @param [in] Length Length of the field. [SAMI] Please see suggestion above. > +**/ > +VOID > +EFIAPI > +DumpReservedBits ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr, > + IN UINT32 Length > + ); > + > /** > This function indents and prints the ACPI table Field Name. > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112077): https://edk2.groups.io/g/devel/message/112077 Mute This Topic: https://groups.io/mt/101716966/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-